function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Peter CowenPeter Cowen 

trigger error record is read only

I have a trigger that uses the account name to populate a Service Contract field on the ticket. Sometimes we forget to add the account but instead add a contact with the account associated and we get

Error:Apex trigger UpdateServiceContract caused an unexpected exception, contact your administrator: UpdateServiceContract: execution of AfterUpdate caused by: System.FinalException: Record is read-only: Trigger.UpdateServiceContract: line 8, column 1

Is it possible for you to review the trigger and let me know how I can incorporate just having a contact name on the ticket
trigger UpdateServiceContract on Case (before insert,before update, after update) {
  Id caseRecordTypeId = [Select id from RecordType where sObjectType = 'Case' and developerName ='Service_Desk' ].id ; 
    for (Case c : {
    if (c.RecordTypeID == caseRecordTypeId )
      if (c.service_contract__c == NULL){
          //c.Service_Contract__c = [select Id from ServiceContract where AccountId ='810D0000000Cfza' and Primary_Service_Contract__c = True].id;
        c.Service_Contract__c = [select Id from ServiceContract where AccountId = :c.AccountId and Primary_Service_Contract__c = True limit 1].id;
        }catch(QueryException e) {
          //No records found. Maybe you should set it to Null
could you please check this field access  Service_Contract__c . and also please try to populate this field value manually for 1 record and see whther its got succeeded or not. And share ur result.
Siddharth ManiSiddharth Mani
Can you try removing "after update" from your trigger header and let me know if it works for you?
Amit Chaudhary 8Amit Chaudhary 8
Hi Peter Cowen,

Issue is coming because of After Update event in your trigger.

This is because you are in an after update trigger and the records are read only in that context as they have been written, but not committed, to the database.

Even i also found one more issue in your code you are using SOQL inside for loop

Please try below code.
trigger UpdateServiceContract on Case ( before insert,before update ) 
	Id caseRecordTypeId = [Select id from RecordType where sObjectType = 'Case' and developerName ='Service_Desk' ].id ; 

	Set<Id> setId = new Set<Id>();	
	for (Case c : 
		if (c.RecordTypeID == caseRecordTypeId )
			if (c.service_contract__c == NULL && c.AccountId != null)

	if( setId.size() > 0 )
		List<ServiceContract> lstServiceCont = [ select Id , AccountId from ServiceContract where AccountId = :setId and Primary_Service_Contract__c = True ];

		Map<String , ServiceContract > mapAccoutWishServiceCont = new Map<String , ServiceContract>();
		For(ServiceContract serCont : lstServiceCont )
		for (Case c : 
			if (c.RecordTypeID == caseRecordTypeId )
				if (c.service_contract__c == NULL && mapAccoutWishServiceCont.containsKey(c.AccountId ) )
					c.Service_Contract__c = mapAccoutWishServiceCont.get(c.AccountId).id ;

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Amit Chaudhary