function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
uHaveOptionsuHaveOptions 

Help on creating email test class

Help on passing test class.  I just need 5 lines more.  it's at 67%  The class is long I only added what's red and not passing.
 
public void send() {
        try {
            DM_Public_Page_URL__c siteCS = DM_Public_Page_URL__c.getValues('Default');
            String siteURL = siteCS.Site_URL__c;
            String logo = siteCS.Logo__c;
            
            List<Messaging.SingleEmailMessage> mails = new List<Messaging.SingleEmailMessage>();
            EmailTemplate emailT = [select Subject, HtmlValue from EmailTemplate where DeveloperName = 'Contact_Form' limit 1];
            
            for(Contact primaryContact : primaryContactList) {
                String body = emailT.HtmlValue.replace('{account_form}', siteURL + '/apex/AccountFormPage?id=' + accountId);
                body = body.replace('{primary_contact_name}', primaryContact.FirstName);
                body = body.replace('{account_name}', accountName);
               body = body.replace('{account_logo}', '<img src="'+siteURL + Logo+'"alt="Logo" height="225px" width="74px"');
                
                Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
                mail.setToAddresses(new String[]{primaryContact.Email});
                mail.setSubject(emailT.Subject);
                mail.setHtmlBody(body);
                mails.add(mail);
            }
            
            List<Messaging.SendEmailResult> results = Messaging.sendEmail(mails);
            if(results[0].isSuccess()) {
                ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.CONFIRM, 'Contact email successfully sent'));
            } else {
                System.debug('------------------- errors: ' + results[0].getErrors());
                ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 'Error while sending the contact update email: ' + results[0].getErrors()));
            }
        } catch(Exception e) {
            System.debug('------------------- ERROR: ' + e.getStackTraceString());
            ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 'Error while sending the contact update email: ' + e.getStackTraceString()));
            
        }
    }
    
    public PageReference cancel() {
        PageReference pref = new PageReference('/' + accountId);
        return pref;
    }
}


This is my test class

@isTest
private class AccountFormControllerTest {

    private static testMethod void test() {
        Account lender = new Account();
        lender.Name = 'Test Account';
        insert lender;
        System.debug('created account');
        
        Contact c = new contact();
        c.FirstName = 'JOhn';
        c.LastName = 'Doe';
        c.email='test@test.com';
        c.primary_contact__c = True;
        insert c;
        System.debug('created account');
                
        ApexPages.currentPage().getParameters().put('id', lender.Id);
        AccountFormController controller = new AccountFormController();
        controller.accountUpdate.Equity_Debt__c = 'Debt';
        controller.save();
        
        string options = controller.getOptions();
    }
    
    private static testMethod void test2() {
        Contact ca = new Contact();
            ca.FirstName = 'John';
            ca.LastName = 'Doe';
            ca.email='test@test.com';
            ca.Primary_Contact__c = true;
    
        ApexPages.currentPage().getParameters().put('id', 'some id');
        AccountFormController controller = new AccountFormController();
        controller.save();
        
        AccountFormController controller2 = new AccountFormController();
        controller2.save();
        
        ApexPages.currentPage().getParameters().put('id', '');
        AccountFormController controller3 = new AccountFormController();
        controller3.save();
        
        try{
        Insert ca;
        }
        catch(Exception ee){
        }   
    }
    
}
This is whats not passing...
 
String body = emailT.HtmlValue.replace('{account_form}', siteURL + '/apex/AccountFormPage?id=' + accountId);
                body = body.replace('{primary_contact_name}', primaryContact.FirstName);
                body = body.replace('{account_name}', accountName);
               body = body.replace('{account_logo}', '<img src="'+siteURL + Logo+'"alt="Logo" height="225px" width="74px"');
                
                Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
                mail.setToAddresses(new String[]{primaryContact.Email});
                mail.setSubject(emailT.Subject);
                mail.setHtmlBody(body);
                mails.add(mail);
            }

 
Best Answer chosen by uHaveOptions
Zuinglio Lopes Ribeiro JúniorZuinglio Lopes Ribeiro Júnior
Hello,

Can you post all the code? If these lines are not getting covered is because your primaryContactList list is empty. I've noticed that in your Test class you do not invoke the send method so that makes me wonder that there is another method, perhaps the save, invoking it. 

Without seeing the whole code and not knowing how do you fetch the contacts, I would guess that the problem is that you're creating your contacts in the Test without linking them to the Account.
 
Contact c = new contact();
        c.FirstName = 'JOhn';
        c.LastName = 'Doe';
        c.email='test@test.com';
        c.primary_contact__c = True;
        c.AccountId = lender.Id; // Maybe you should link the contact to the Account
        insert c;

If that's not the case, please, provide more information about your code.

Hope to have helped!

Regards.

Don't forget to mark your thread as 'SOLVED' with the answer that best helps you. 

All Answers

Zuinglio Lopes Ribeiro JúniorZuinglio Lopes Ribeiro Júnior
Hello,

Can you post all the code? If these lines are not getting covered is because your primaryContactList list is empty. I've noticed that in your Test class you do not invoke the send method so that makes me wonder that there is another method, perhaps the save, invoking it. 

Without seeing the whole code and not knowing how do you fetch the contacts, I would guess that the problem is that you're creating your contacts in the Test without linking them to the Account.
 
Contact c = new contact();
        c.FirstName = 'JOhn';
        c.LastName = 'Doe';
        c.email='test@test.com';
        c.primary_contact__c = True;
        c.AccountId = lender.Id; // Maybe you should link the contact to the Account
        insert c;

If that's not the case, please, provide more information about your code.

Hope to have helped!

Regards.

Don't forget to mark your thread as 'SOLVED' with the answer that best helps you. 
This was selected as the best answer
uHaveOptionsuHaveOptions

I cant beleive I missed that.  I added that and the exception and it passed to 75%
 
Zuinglio Lopes Ribeiro JúniorZuinglio Lopes Ribeiro Júnior
Hello,

Glad to have helped!

Regards.

Don't forget to mark your thread as 'SOLVED' with the answer that best helps you. 
Amit Chaudhary 8Amit Chaudhary 8

I will recommend you to start using trailhead to learn about test classes
1) https://trailhead.salesforce.com/modules/apex_testing

Also please check below post
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_qs_test.htm
2) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm

sample Test classes
1) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html


Try to update your class like below
@isTest
private class AccountFormControllerTest {

    private static testMethod void test() {

		Account lender = new Account();
			lender.Name = 'Test Account';
        insert lender;
        System.debug('created account');
        
        Contact c = new contact();
			c.FirstName = 'JOhn';
			c.LastName = 'Doe';
			c.email='test@test.com';
			c.primary_contact__c = True;
			c.AccountId = lender.Id; 
        insert c;
        System.debug('created account');
                
        ApexPages.currentPage().getParameters().put('id', lender.Id);
        AccountFormController controller = new AccountFormController();
        controller.accountUpdate.Equity_Debt__c = 'Debt';
        controller.save();
        
        string options = controller.getOptions();
    }
    
    private static testMethod void test2() {
        Contact ca = new Contact();
            ca.FirstName = 'John';
            ca.LastName = 'Doe';
            ca.email='test@test.com';
            ca.Primary_Contact__c = true;
    
        ApexPages.currentPage().getParameters().put('id', 'some id');
        AccountFormController controller = new AccountFormController();
        controller.save();
        
        AccountFormController controller2 = new AccountFormController();
        controller2.save();
        
        ApexPages.currentPage().getParameters().put('id', '');
        AccountFormController controller3 = new AccountFormController();
        controller3.save();
        
        try{
			Insert ca;
        }
        catch(Exception ee){
        }   
    }
    
}

Make sure you will call Send method in your test class. Can you please post your full apex class so that we can help you much better

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Let us know if this will help you