function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
m pandeym pandey 

illegal assignment from Map<Id,contact> to Map<Id,account>...........?

trigger newacconsal on Contact (after insert) {
    set<Id> ids=new set<Id>()
    
    map<id,Account> macc=new map<id,Account>();
    map<id,Contact> mcon=new map<id,Contact>();
    
        map<id,Account> macc=trigger.old;

}


Error

Illegal assignment from Map<Id,Contact> to Map<Id,Account>
Dilip_VDilip_V
panday,

try this code.
trigger newacconsal on Contact (after insert) {
    set<Id> ids=new set<Id>()
    
    map<id,Account> macc=new map<id,Account>();
    map<id,Contact> mcon=new map<id,Contact>();
    
    mcon=trigger.old;

}

Thanks
Dilip_VDilip_V
Pandy,

As trigger.old returns contact map(map<id,Contact>) not account map(map<id,Account>).Your trying to assign contact map to account map that is the reason for the error.


Make it as best answer if it helps.
Thanks.
m pandeym pandey
Illegal assignment from List<Account> to Map<Id,Contact>
Harish RamachandruniHarish Ramachandruni
Hi,




trigger newacconsal on Contact (after insert) {
    set<Id> ids=new set<Id>()
    
    map<id,Account> macc=new map<id,Account>();
    map<id,Contact> mcon=new map<id,Contact>();
    
        map<id,Account> macc=trigger.old;

}
check underlined line you are trinng trigger on contact .

if trigger.new or old it will hold object data how u can map to account .


  map<id,Contact> macc=trigger.old;



Regards ,
Harish.R 


 
Deepak agarwal 9Deepak agarwal 9
Hi Pandey,

Try this code.If it works please tell me.
trigger newacconsal on Contact (after insert) {
    set<Id> ids=new set<Id>()
    
    map<id,Account> macc=new map<id,Account>();
    map<id,Contact> mcon=new map<id,Contact>();
    
       for(account a:macc){
macc=trigger.old
}
}


Thanks,
Deepak Agarwal.

 
Amit Chaudhary 8Amit Chaudhary 8
You created the Trigger on Contact Trigger so Trigger.New and Trigger.newMap will return Contact record only. SO your code should be like below
trigger newacconsal on Contact (after insert) 
{
    set<Id> ids=new set<Id>()    
    map<id,Account> macc=new map<id,Account>();
    map<id,Contact> mcon=new map<id,Contact>();  
    map<id,Contact> macc=trigger.old;
}

If you want to know how to use List and Map in Trigger Please check below post
1) http://amitsalesforce.blogspot.com/2016/09/collection-in-salesforce-example-using.html

Please check below post for Trigger Best Pratice and framwork
1) http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org. 

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you
vishnu Rvishnu R
hi pandey,
trigger newacconsal on Contact (after insert) {
set<Id> ids=new set<Id>()
map<id,Account> macc=new map<id,Account>();
map<id,Contact> mcon=new map<id,Contact>();
map<id,Contact> macc=trigger.old;
}
 thanks 
Vishnu R
m pandeym pandey
https://developer.salesforce.com/forums/ForumsMain?id=9060G000000XbA4QAK
 
Shivani Shukla 14Shivani Shukla 14
I am getting Illegal assignmnet from Map to Account

  public static void updateEavtoAccount(Map<String, string> labeltoanswermap,String oppId){
     
       List <Opportunity> OpportunityId =new List <Opportunity>();
      
       List<Account> accounts=new List<Account>();
        accounts=[Select Id,name,NoOfResidents__c,Type_Of_House__c from Account where id =:oppId];
     
      if(labeltoanswermap.containsKey('Number of persons in the household')){
       accounts[2]=labeltoanswermap;
    }

Here getting error Illegal Assignmnet from Map to Account .What I am doing here ? .