Hi Shyam,

Greetings to you!

First, you never want to put a query inside of a For loop. As it stands right now, you're querying for each record when you could have made a collection first and then run one single query for all of the related records in obect2__c.

That said, since the record Id's in object2__c are the same as the Case Id's (from your query, object2.Id =: cs.id), you don't even need to run a query at all. Instead, all you need to do is determine whether or not your picklist values have changed, then update the related records using the same Id's.

Finally, this is an After Update trigger, not both a Before and an After update. a Before Update runs before the updates on Case are committed to the database. You don't want to update the related object until the updates have been written to the Case Object and you only want to write them once.

Here's your revised trigger:

trigger casetoupdate on Case (after update) {

   List<object2__c> toUpdate = new list<object2__c>();

   for(Case cs : Trigger.New) {     

      // compare new and prev picklist values to create a list of Object__2 records to update

      if(cs.picklist__c != trigger.oldMap.get(cs.Id).picklist__c) {

         object2__c toUp = new object2__c(Id = cs.Id, picklist__c = cs.picklist__c); 

         toUpdate.add(toUp);

      } // end of if statement

   } // end of for loop

   if(toUpdate.isEmpty() == false) Update toUpdate;

} // end of trigger


I hope you find the above solution helpful. If it does, please mark as Best Answer to help others too.

Thanks and Regards,
Deepali Kulshrestha.