You need to sign in to do that
Don't have an account?

test class error updating rating
Hello
I am updating account rating from opportunity trigger. whenever opportunity stagename='Closed won', then in acocount , rating = 'Hot'
public class AccountUpdates_from_oppor
{
public void updateaccount(list<Opportunity> accountid)
{
list<ID> accids = new list<ID>();
list<Account> accountratings_new = new list<Account>();
for(Opportunity o:accountid)
{
accids.add(o.accountid);
}
list<Account> acctratings = [select Id,rating from Account where ID=:accids];
for(Opportunity opp:accountid)
{
for(Account a:acctratings)
{
if (opp.StageName == 'Closed Won')
a.Rating='Hot';
accountratings_new.add(a);
}
}
Database.Update(accountratings_new);
}
}
trigger trg_updateaccountratings on Opportunity (before Insert,before Update)
{
if (trigger.IsBefore)
{
if (trigger.IsUpdate)
{
AccountUpdates_from_oppor a1 = new AccountUpdates_from_oppor();
a1.updateaccount(Trigger.New);
}
}
}
@istest(SeeAllData=false)
private class Accountopportunity_Test
{
private static testmethod void validatetest()
{
Profile p = [SELECT Id FROM Profile WHERE Name='System Administrator'];
User u = new User(Alias = 'sample', Email='standarduser@testorg.com',
EmailEncodingKey='UTF-8', LastName='sampleLname', LanguageLocaleKey='en_US',
LocaleSidKey='en_US', ProfileId = p.Id,
TimeZoneSidKey='America/Los_Angeles', UserName='testnamesss@testorg.com');
system.runAs(u)
{
Account acn = new Account();
acn.Name='test1';
Opportunity opp = new Opportunity();
opp.Name='test opp';
opp.CloseDate=System.Today();
opp.StageName='Closed Won';
Test.StartTest();
Database.Insert(acn);
Database.Insert(opp);
system.assertEquals(acn.Rating,''Hot');
Test.StopTest();
}
}
}
Apex class & trigger working fine.
But when I execute test class I am getting error as : " System.AssertException: Assertion Failed: Expected: None, Actual: Hot"
Thanks
sonali
I am updating account rating from opportunity trigger. whenever opportunity stagename='Closed won', then in acocount , rating = 'Hot'
public class AccountUpdates_from_oppor
{
public void updateaccount(list<Opportunity> accountid)
{
list<ID> accids = new list<ID>();
list<Account> accountratings_new = new list<Account>();
for(Opportunity o:accountid)
{
accids.add(o.accountid);
}
list<Account> acctratings = [select Id,rating from Account where ID=:accids];
for(Opportunity opp:accountid)
{
for(Account a:acctratings)
{
if (opp.StageName == 'Closed Won')
a.Rating='Hot';
accountratings_new.add(a);
}
}
Database.Update(accountratings_new);
}
}
trigger trg_updateaccountratings on Opportunity (before Insert,before Update)
{
if (trigger.IsBefore)
{
if (trigger.IsUpdate)
{
AccountUpdates_from_oppor a1 = new AccountUpdates_from_oppor();
a1.updateaccount(Trigger.New);
}
}
}
@istest(SeeAllData=false)
private class Accountopportunity_Test
{
private static testmethod void validatetest()
{
Profile p = [SELECT Id FROM Profile WHERE Name='System Administrator'];
User u = new User(Alias = 'sample', Email='standarduser@testorg.com',
EmailEncodingKey='UTF-8', LastName='sampleLname', LanguageLocaleKey='en_US',
LocaleSidKey='en_US', ProfileId = p.Id,
TimeZoneSidKey='America/Los_Angeles', UserName='testnamesss@testorg.com');
system.runAs(u)
{
Account acn = new Account();
acn.Name='test1';
Opportunity opp = new Opportunity();
opp.Name='test opp';
opp.CloseDate=System.Today();
opp.StageName='Closed Won';
Test.StartTest();
Database.Insert(acn);
Database.Insert(opp);
system.assertEquals(acn.Rating,''Hot');
Test.StopTest();
}
}
}
Apex class & trigger working fine.
But when I execute test class I am getting error as : " System.AssertException: Assertion Failed: Expected: None, Actual: Hot"
Thanks
sonali
You only insert the record in your test class ,
but trigger is before update.
so you shoud update the record in your test class.
I just modified the test class.
Pls let me know because i am getting error as " System.DmlException: Update failed. First exception on row 0; first error: MISSING_ARGUMENT, Id not specified in an update call: []"
Account acn = new Account();
acn.Name='test1';
Opportunity opp = new Opportunity();
opp.Name='test opp';
opp.AccountID=acn.ID;
opp.CloseDate=System.Today();
opp.StageName='Closed Won';
acn.ID=opp.AccountID;
Test.StartTest();
Database.Update(acn);
Database.Insert(opp);
system.assertEquals(acn.Rating,'Hot');
Test.StopTest();
I found some issue in your code:-
1) You are using before insert in your trigger. but due to your if else condition you before insert will not execute
Please try below code
Test Class should be:- Please check below post for test class. I hope that will help you
http://amitsalesforce.blogspot.in/search/label/Test%20Class
Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .
Please let us know if this post will help you
I am getting the same error.
also as per documentation, system.runas will make apex code run in user mode so that field level permisison and sharing settings will apply.
sonali