function readOnly(count){ }
Sign Up ›
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
Learn More

Browse by Topic
ShowAll Questionssorted byDate Posted
+ Start a Discussion
Raghu_devRaghu_dev 

loop through the map object

Hi, Can some one help me how to loop through the map object?

For eg., I have the following map variable declared and populated the values.. I want to query the map variable at the later stages in the code and loop through the results. Please advice


Code:
 Map<String, Lead> leadMap = new Map<String, Lead>();
 for (Lead lead : Trigger.new) {
  leadMap.put(lead.DUNS_NEW__c, lead);
 }

 Let me explain the requirement a little more..

I want to use the map as a resultset (or a recordset). Because of the governing rules in salesforce, I am trying to replace my repetitive soql statements align to maps and sets. Actual requirement is as follows.

There will be a huge load of leads from several vendors into our sfdc org. These leads will have DUNS numbers. The trigger on lead will have to look for the duns number on account (which was already populated from a different process) object and attach the lead to that account.

my earlier code was working perfect but because of the soql governing limits on trigger , I have to change that code to work.
Here is the actual code :
Code:
trigger dunsOnLeads on Lead (before insert, before update) {

 for (Lead ld : Trigger.new) {
        
        String str = ld.DUNS_NEW__c;
        String mstrSfdcId = '';
        Id sfdcId;
        // for customer identification
        String custmstrSfdcId = '';
        Id custsfdcId;
        // for prospect identification
        String prosmstrSfdcId = '';
        Id prossfdcId;
        
        System.debug('Duns on Lead ' + str);
        Integer custi=0;
        Integer prosi=0;
        
        Integer i=0;
        if (str != null) //find for null (or space)
        {
         // look for active customers 
         for (Account tmpAccnt : [select Id, Master_SFDC_ID__c, MODS_Account_Type__c, customer_number__c  from Account where IsDeleted = false and Duns__c = :ld.duns_new__c]) 
         {
             if ((tmpAccnt.MODS_Account_Type__c == 'Customer') && (tmpAccnt.customer_number__c != ''))
             {
              custmstrSfdcId = tmpAccnt.Master_SFDC_ID__c;
              custsfdcId = tmpAccnt.Id;
              custi++;
             }
             else
             {
              prosmstrSfdcId = tmpAccnt.Master_SFDC_ID__c;
              prossfdcId = tmpAccnt.Id;
              prosi++;
             } 
         }
         if (custi > 0) // there are no customers found with the same duns number
         {
          mstrSfdcId = custmstrSfdcId;
          sfdcId = custsfdcId;
          i = custi;
         }
         else if (prosi > 0)
         {
          mstrSfdcId = prosmstrSfdcId;
          sfdcId = prossfdcId;
          i = prosi;
         }
         // if no customers found with the same match, look for prospects
         /*if (i==0) 
         {
          for (Account tmpAccnt : [select Id, Master_SFDC_ID__c from Account where 
           IsDeleted = false and MODS_Account_Type__c = 'Prospect'
           and Duns__c = :ld.duns_new__c]) {
              mstrSfdcId = tmpAccnt.Master_SFDC_ID__c;
              sfdcId = tmpAccnt.Id;
              i++;
          }
         }*/
         // if the account is identified as slave, master sfdc id is the unique id of the master. 
         // in that case, lead will be attached to that master account.
         //System.debug('Master SFDC: ' + mstrSfdcId);
         //System.debug('Integer i: ' + i);
         //System.debug('SFDC Id: ' + sfdcId);
         if (i > 1 && mstrSfdcId == null)
         {
           ld.account__c = sfdcId;
           // Attach this lead to the last account from search and also, show this lead on the view
           ld.Dup_DUNS__c = True;
         }
         else if (i > 1 && mstrSfdcId != null)
         {
          ld.account__c = mstrSfdcId; 
         }
         else if (i == 1 && mstrSfdcId != null)
         {
          ld.account__c = mstrSfdcId;  
         }
         else if (i == 1 && mstrSfdcId == null && sfdcId != null)
         {
          ld.account__c = sfdcId;  
         }
         else if (i==0)
         {
          ld.account__c = null;
          ld.Dup_DUNS__c = False;
         }
        }
        else
        {
          ld.account__c = null;
          ld.Dup_DUNS__c = False;
        }
 
    }
}

 

Here is the idea how to replace that code align to maps and sets .. pls advice if the approach is wrong

1. Get all the lead duns # and the Ids associated to those leads into a map
Code:
 Map<String, Lead> leadMap = new Map<String, Lead>();
 for (Lead lead : Trigger.new) {
  leadMap.put(lead.DUNS_NEW__c, lead.Id);
 }

 

2. Query the account with the keys (duns) from the above map
Code:
for (Account newAccnt = new [select Id, Master_SFDC_ID__c, MODS_Account_Type__c, customer_number__c  from Account where IsDeleted = false and Duns__c IN : leadMap.keyset()])

3. The above query can result in bulk records as there are duplicate duns numbers in accounts.
4. Now, I have to loop  through the leadmap to identify the account associated to that lead (as the duns on lead and duns on account matches)
 ---- How to query or search the map object ?
 ---- How to loop through the map object  ?
5. Then populate the lead account id with the account id of the matching account record.

Please help





Thanks
Raghu

Message Edited by Raghu_dev on 09-08-2008 09:05 AM

Message Edited by Raghu_dev on 09-08-2008 09:46 AM
mikefmikef
I think all you need to do is loop through the Trigger again.
 
Try this:
Code:
1. loop through the leads and add the duns # to a set. 
 Set<String> leadDuns = new Set<String>();
 for (Lead lead : Trigger.new) {
  leadDuns.add(lead.DUNS_NEW__c);
 }

 
2. Query the account with the keys (duns) from the above map

Map<String,Account> dunsAccountId = new Map<String,Account>();
for (Account newAccnt :[select Id, Master_SFDC_ID__c, MODS_Account_Type__c, customer_number__c  from Account where IsDeleted = false and Duns__c IN : leadDuns]){
   dunsAccountId.put(newAccnt.Duns__c,newAccnt);
}

3. loop through the leads again to populate the Account id
for(Lead l : Trigger.new){
  if(dunsAccountId.containsKey(l.DUNS_NEW__c)){
    l.AccountId__c = dunsAccountId.get(l.DUNS_NEW__c).id;
  }
}

 
Raghu_devRaghu_dev
Hi Mike

Thanks for the response. Infact, I was just changing the code which was almost like the code you have published. I think I am stuck at the 3rd step.

This is what I want to do in the 3rd step. Since the step 2 might result in duplicate accounts (as duns could repeat on more than one account - duplicate accounts), I want to loop through the output (actually your suggestion would work if there is only one account with that duns). Here is the loop I am trying to put it together..

Code:
for (Account newAccnt : [select Id, Master_SFDC_ID__c, MODS_Account_Type__c, customer_number__c, Duns__c  from Account where IsDeleted = false and Duns__c IN : leadMap.KeySet()])
{
    acntMap.put(newAccnt.Duns__c, newAccnt);
} 
for (Lead lead : Trigger.new) {
 Account tmpAccnt = acntMap.Get(lead.DUNS_NEW__c);
 system.debug('Account map output ' + tmpAccnt.Id);
 for (tmpAccnt){
                 // this is where I am stuck. Not sure how to loop through the tmpAccnt as this is throwing the obvious syntax error
 }
}

 Please let me know if I am not clear.
mikefmikef
A map will replace the key value pair with the new entry if the keys match.

For example if you query the account object for duns # 1234 and 2 accounts come back.
The map will store only the second account as the value pair. You never know of the other account when you are getting ready to use the map.
This is because the keys 1234 matched.

There is no need to do your other for loop because there will always be only one key value pair in a map.
Raghu_devRaghu_dev
Aahh !! Then I am in trouble. :-( I actually want to store the duplicates too as my further processing will check for the duplicates and has to update the relevant fields in lead (like lead cannot be attached to the slave account, as we have master slave accounts based on the duns number and our deduplication process).

Can I use Lists to store the duplicate accounts as well ?

Thank you so much for your response.
mikefmikef
A list of Accounts will solve your issue.

There is no such think as a duplicate account in salesforce, because every account, or any SObject, has it's own ID.
Making is not a dup.

So a list of accounts with the same duns number will work, and you can use list methods to get back all accounts with that duns number.
Raghu_devRaghu_dev
Another hurdle !!

I cant query a list right ? (pls correct me if I am wrong). All I see in the documentation is List.get(index) .. is there a way I can query the list ?
Ron HessRon Hess
Here is another example using maps, avoiding duplicate ID's in the list of leads

http://wiki.apexdevnet.com/index.php/LeadDuplicatePreventer.apex

there are more to look thru on this page
http://wiki.apexdevnet.com/index.php/Apex_and_Visualforce