In your User_Create_Trigger, you also have a lot of calls that you don't need to make. I'll make the corrections while commenting out what you don't need.

---

JonSimmons wrote:
public class User_Contact_Trigger_Class  

{

 

 

//User Trigger support and unit test class

// Harvest Solutions 2009

 

 

//deal with new user create trigger

 public static void User_Create_Trigger(User newUser)

{

 

System.Debug('Inside User_Create_Trigger');

 

//grab the current user, so that we can do user DML (Correction, this doesn't seem to help)

// Don't need. If you are calling UserInfo.getUserId() in a query to get the ID, you're just wasting a query call, but I think you realized that in your comment above

// User theCurrentUser = [ select Id from User where Id = :UserInfo.getUserId() ];

 

 

 

//get the account that the new contact will belong to

// So what will happen if the company does not exist???

Account theAccount = [select id from Account where name = :newUser.companyname];

 

 

//create a contact record for this user, linking to account specified in Company field on user record

 Contact newContact = new Contact();

newContact.firstname = newUser.firstname; //first

newContact.lastname = newUser.lastname; //and last

newContact.recordtypeid = '012600000000ygPAAQ';

//newContact.nickname__c = 'user1';

newContact.accountid = theAccount.id;

newContact.contact_type__c = 'Employee';newContact.leadsource = 'Other';

newContact.currencyisocode = newUser.defaultcurrencyisocode;

newContact.eMail = newUser.eMail;

newContact.phone = newUser.phone;

newContact.Employee_UserId__c = newUser.id;

 

System.Debug('AccountId: ' + theAccount.id);

 

// Don't need to run as the current user since whoever calls it will be the running user

//System.runAs (theCurrentUser)

//{

insert newContact;

System.Debug('New ContactId: ' + newContact.id);

//}

 

 

//get list of all contacts in above company/Account

Contact[] theContacts = [select id,name,employee_userid__c from Contact where accountid = :theAccount.id];

 

 

//loop through all contacts and add new contactshare records

 for(Contact aContact :theContacts)

{

//create a new contact share record to give the new usercontact access to each contact

 ContactShare newContactShare = new ContactShare(); newContactShare.ContactAccessLevel = 'Read';

newContactShare.ContactId = aContact.id; //the contactid of the existing contactuser

newContactShare.UserOrGroupId = newUser.id; //the userid of the new user

 

insert newContactShare;

 

 

//create a new contactshare record to give each existing contact access to the new usercontact

 ContactShare newContactShare2 = new ContactShare(); newContactShare2.ContactAccessLevel = 'Read';

newContactShare2.ContactId = newContact.id; //the contactId of the new user

newContactShare2.UserOrGroupId = aContact.employee_userid__c; //the userId of the existing contactuser

 

insert newContactShare2;

 

}

 

}

 

 

 

}

 

 

---

 

And with your trigger you also have some wasted calls

 

trigger User_Create_ContactSharing_Trigger on User (after insert)  

{

 

  // User Create ContactShareing Trigger

  System.Debug('Inside Insert Trigger');

 

 

  //get the user data and pass to the function in our support class

  // Not needed since this same information is stored in Trigger.new. This should fail or return nothing

  // User[] theUsers = [select id,name,firstname,lastname,companyname, email, phone, defaultcurrencyisocode from User where id in :trigger.new];

 

  //loop through all new users

   for(User newUser : Trigger.new)

  {

    User_Contact_Trigger_Class.User_Create_Trigger(newUser);

  }

}

---

You can also streamline your code when you are creating your ContactShares that you are inserting. Create a list of ContactShares before your FOR loop:

List< ContactShare > newContactShares = new List< ContactShare >();

Now instead of saying doing your insert statements, do

newContactShares.add( newContactShare );

newContactShares.add( newContactShare2 );

Now AFTER your FOR loop is finished you can say

insert newContactShares;

This will do one DML statement for ALL your new ContactShares instead of the multiple DML statements each time you go through the FOR loop. This will help you in case you run into any govener limits where Salesforce prevents you from doing a certain number of DML statements (insert, update, delete, upsert, etc)

Hope this helps.