Hi Jim

I wrote my Trigger as below on the Opportunity as we discussed . But it is giving me a NullPointerException at below line . Can you please help me .

Thanks and Regards

trigger FFStatus on Opportunity (after update) {

Opportunity Opp;

List <OpportunityLineItem> OLIPEMAP  = new List <OpportunityLineItem> ();

OLIPEMAP = [Select o.PricebookEntryId ,o.PricebookEntry.ProductCode from OpportunityLineItem o where o.OpportunityId =: Opp.Id ]; <---here is the Exception
 
 
 
 for (Opportunity Op :Trigger.new){
 
 
  for (  OpportunityLineItem oli : OLIPEMAP ){
 
  String pc = Oli.PricebookEntry.ProductCode;
  String f ='FF';
  Boolean Result = pc.Contains(f);
 If ( (Op.StageName== 'Won' || Op.StageName=='Won - Future Activation Date' ) && Result == True ){
    
    
    Account a;
   
    
    a.Fit_Finder_Status__c = 'Active';
    
    }
    
    }
    }
}

Well, to start with, the reason you are getting the null pointer is becase your opportunity Opp is not defined to anything. You have declared an Opportunity variable called Opp, but it is assigned to any existing opportunity.  You did the same type of thing with the Account object.

You need to use the Trigger.new list to reference the actual opportunity or opportunties that caused the trigger to fire in the first place.

See how this works for you:

trigger FFStatus on Opportunity (after update) {
	String f ='FF';
	Set<ID> OppIDs = new Set<ID>();
	Set<ID> AcctIDs = new Set<ID>();
	for(Opportunity o:Trigger.New){
		OppIDs.add(o.id);
		AcctIDs.add(o.accountid);
	}
	Map<ID,Account> ACCTMAP = new Map<ID,Account>();  //create a map list of accounts with the Account ID as the key
	ACCTMAP= [select id,Fit_Finder_Status__c from Account where id in:AcctIDs];
	
	List<Account> updACCT = new List<Account>(); //accounts in this list will get updated
	
	Map <ID,List<OpportunityLineItem>> OLIOPPMAP  = new Map <ID,List<OpportunityLineItem>> (); //create a map list of OLI with the Opportunity ID as the key, note that each opp could have more than one OLI
	for(OpportunityLineItem oli: [Select o.PricebookEntryId ,o.PricebookEntry.ProductCode from OpportunityLineItem o where o.OpportunityId in :Trigger.New ]){
		if(OLIOPPMAP.containsKey(oli.OpportunityID){
			OLIOPPMAP.get(oli.OpportunityID).add(oli);
		}else{
			OLIOPPMAP.put(oli.OpportunityID,new List<OpportunityLineItem>{oli};
		}
	}
 
	for (Opportunity Op :Trigger.new){
 
 
		for (  OpportunityLineItem oli : OLIOPPMAP.get(Op.id) ){
 
			String pc = oli.PricebookEntry.ProductCode;
			Boolean Result = pc.Contains(f);
			if ( (Op.StageName== 'Won' || Op.StageName=='Won - Future Activation Date' ) && Result == True ){
				Account tmpAccount = ACCTMAP.get(Op.AccountID);
				tmpAccount.Fit_Finder_Status__c = 'Active';
				updACCT.add(tmpAccount);
			}
		}
    }
	try{
		update updACCT;
	}catch(DMLException d){
		system.debug('\n\nERROR UPDATING ACCOUNTS: '+d.getDMLMessage(0));
	}
}

Hi Jim,

I actually got an error for the below line as follows ,

Best Regards

Error :

llegal assignment from LIST<Account> to MAP<Id,Account> at line 10 column 5

 Map<ID,Account> ACCTMAP = new Map<ID,Account>();  //create a map list of accounts with the Account ID as the key
    ACCTMAP= [select id,Fit_Finder_Status__c from Account where id in:AcctIDs];

That should have worked.  I am just typing this in, so you may need to do some clean up to get it to compile.

Try it this way:

trigger FFStatus on Opportunity (after update) {
	String f ='FF';
	Set<ID> OppIDs = new Set<ID>();
	Set<ID> AcctIDs = new Set<ID>();
	for(Opportunity o:Trigger.New){
		OppIDs.add(o.id);
		AcctIDs.add(o.accountid);
	}
	Map<ID,Account> ACCTMAP = new Map<ID,Account>([select id,Fit_Finder_Status__c from Account where id in:AcctIDs]);  //create a map list of accounts with the Account ID as the key
	
	
	List<Account> updACCT = new List<Account>(); //accounts in this list will get updated
	
	Map <ID,List<OpportunityLineItem>> OLIOPPMAP  = new Map <ID,List<OpportunityLineItem>> (); //create a map list of OLI with the Opportunity ID as the key, note that each opp could have more than one OLI
	for(OpportunityLineItem oli: [Select o.PricebookEntryId ,o.PricebookEntry.ProductCode from OpportunityLineItem o where o.OpportunityId in :Trigger.New ]){
		if(OLIOPPMAP.containsKey(oli.OpportunityID){
			OLIOPPMAP.get(oli.OpportunityID).add(oli);
		}else{
			OLIOPPMAP.put(oli.OpportunityID,new List<OpportunityLineItem>{oli};
		}
	}
 
	for (Opportunity Op :Trigger.new){
 
 
		for (  OpportunityLineItem oli : OLIOPPMAP.get(Op.id) ){
 
			String pc = oli.PricebookEntry.ProductCode;
			Boolean Result = pc.Contains(f);
			if ( (Op.StageName== 'Won' || Op.StageName=='Won - Future Activation Date' ) && Result == True ){
				Account tmpAccount = ACCTMAP.get(Op.AccountID);
				tmpAccount.Fit_Finder_Status__c = 'Active';
				updACCT.add(tmpAccount);
			}
		}
    }
	try{
		update updACCT;
	}catch(DMLException d){
		system.debug('\n\nERROR UPDATING ACCOUNTS: '+d.getDMLMessage(0));
	}
}

hey Jim,

I am sorry if i am troubling you too much but i am not sure why i am getting the below error .

Thanks and Regards

System.NullPointerException: Attempt to de-reference a null object: Trigger.FFStatus: line 26, column

   for (Opportunity Op :Trigger.new){

        for (  OpportunityLineItem oli : OLIOPPMAP.get(Op.id) ){     <<--------- Here is the Exception
 
            String pc = oli.PricebookEntry.ProductCode;
            Boolean Result = pc.Contains(f);
            if ( (Op.StageName== 'Won' || Op.StageName=='Won - Future Activation Date' ) && Result == True ){
                Account tmpAccount = ACCTMAP.get(Op.AccountID);
                tmpAccount.Fit_Finder_Status__c = 'Active';
                updACCT.add(tmpAccount);
            }
        }
    }

My guess would be that you have an Opportunity being updated that has no products at all.

This error handling should catch that scenario (basically, ignore any opportunities with no products added:

trigger FFStatus on Opportunity (after update) {
	String f ='FF';
	Set<ID> OppIDs = new Set<ID>();
	Set<ID> AcctIDs = new Set<ID>();
	for(Opportunity o:Trigger.New){
		OppIDs.add(o.id);
		AcctIDs.add(o.accountid);
	}
	Map<ID,Account> ACCTMAP = new Map<ID,Account>([select id,Fit_Finder_Status__c from Account where id in:AcctIDs]);  //create a map list of accounts with the Account ID as the key
	
	
	List<Account> updACCT = new List<Account>(); //accounts in this list will get updated
	
	Map <ID,List<OpportunityLineItem>> OLIOPPMAP  = new Map <ID,List<OpportunityLineItem>> (); //create a map list of OLI with the Opportunity ID as the key, note that each opp could have more than one OLI
	for(OpportunityLineItem oli: [Select o.PricebookEntryId ,o.PricebookEntry.ProductCode from OpportunityLineItem o where o.OpportunityId in :Trigger.New ]){
		if(OLIOPPMAP.containsKey(oli.OpportunityID){
			OLIOPPMAP.get(oli.OpportunityID).add(oli);
		}else{
			OLIOPPMAP.put(oli.OpportunityID,new List<OpportunityLineItem>{oli};
		}
	}
 
	for (Opportunity Op :Trigger.new){
 
		if(OLIOPPMAP.containsKey(Op.id){
			for (  OpportunityLineItem oli : OLIOPPMAP.get(Op.id) ){
 
				String pc = oli.PricebookEntry.ProductCode;
				Boolean Result = pc.Contains(f);
				if ( (Op.StageName== 'Won' || Op.StageName=='Won - Future Activation Date' ) && Result == True ){
					Account tmpAccount = ACCTMAP.get(Op.AccountID);
					tmpAccount.Fit_Finder_Status__c = 'Active';
					updACCT.add(tmpAccount);
				}
			}
		}
    }
	try{
		update updACCT;
	}catch(DMLException d){
		system.debug('\n\nERROR UPDATING ACCOUNTS: '+d.getDMLMessage(0));
	}
}