Hi all,

I'm just starting Apex coding to try and get some custom functionality. I created a custom object called Settings__c in which I want to hold user configurable settings. There should only ever be one record there. I'm making a custom VF page to allow users to modify the settings.

I want my custom VF page to display the current settings. If a settings record does not exist, I want the code to insert a new record and populate it with the values from the form. If an existing record exists I want the form to  update the settings.

The problem is that the command button doesn't seem to do anything. I deleted all the records from my custom object so my understanding of the code I have written is that it should execute the insert statement resulting in a new record. But when I check, no record is created. I don't know why, can anyone tell me what the coding error is?

Controller code:

public class Settings {

  //Settings variables
  public String URL {get; set;}
  public ID SettingID{get; set;}
  
  //Constructor
  public Settings() {
    
    //Return list of settings
    list<Settings__c> settings = [select ID,URL__c from Settings__c limit 1];
    
    //Check for existing settings record
    if (!settings.isempty()) {
      //If one exists, loop through and assign settings variables
      for (Settings__c a : settings) {
        SettingID = a.ID;
        URL = a.URL__c;
      }
    }
  }
  
  //Save settings
  public void save() {

    //Check for existing settings record indicated by presence of SettingID
    if (SettingID == null) {
      //Create a new record
      Settings__c newSettings = new Settings__c(URL__c = URL);
        
        try {
            Insert newSettings;
        } catch (DMLException e) {
            newSettings.addError('There was a problem adding the settings. The error message returned is: ' + e.getMessage());
        }
    } else {
      //Update the existing settings record
      Settings__c updateSettings = new Settings__c(URL__c = URL);
        
        try {
            update updateSettings;
        } catch (DMLException e) {
            updateSettings.addError('There was a problem updating the settings. The error message returned is: ' + e.getMessage());
        }
    }
  }
}

 VF page code

<apex:page controller="Settings">
<apex:form >
  <apex:outputlabel value="URL"/>
  <apex:inputtext value="{!URL}"/>
  <apex:outputlabel value="Default Status"/>
  <apex:inputtext value="{!DefaultStatus}"/>
  <apex:inputText value="{!SettingID}"/>
  <apex:commandButton action="{!save}" value="Save Settings"/>
</apex:form>    
</apex:page>