Hi everyone,

I am new to the whole force.com platform and with the help of these discussion boards was able to write quite a bit of the code below.

here is what i am trying to achieve: I am trying to capture the unit price associated with each product on an opportunity level and display it in a new object (called- RevenueObject)

These product names are named like this:

eg. test/email/testproduct/ with Unit price say 400

I have to read these product names to search for key words like "/email" and then capture the revenue associated with it and update a counter field.

RevenueObject Fields-

FieldA - Counter number field ; FieldB - Currency; FieldC - Counter number field ; FieldD - Currency

The code below is able to read these product names and capture revenue and update counter. But here is the issue, it updates the revenue and counter fields (FieldA, FieldB, FieldC, FieldD) every time I save the opportunity- in turn double counting. I just want to capture one instance of it.

Currently RevenueObject UI shows (I saved the opportunity twice) -

FieldA - 2 (should be 1)

FieldB - $800 (should be $400)

Here is my code-

trigger RevenueProject2 on Opportunity (after insert, after update) {

String myString1 = '/email';
String myString2 = '/rb';

RevenueObject__c rO = [Select FieldA__c, FieldB__c, FieldC__c, FieldD__c from RevenueObject__c where Id='a0tW0000000JwFu'] ;
                              
List <RevenueObject__c> rOList = new List<RevenueObject__c>();

double i=0.0;
decimal j= 0.00;



 // This is to create a list of all product names 
 List<OpportunityLineItem>   Product = 
        [Select CustomProdName__c, UnitPrice
         from OpportunityLineItem 
         where Opportunity.StageName != 'Closed Lost' 
         ]; // excluded FOR update
        
       
// The for loop is to go through each product name and to categorize product types     
    
for(OpportunityLineItem prdct: Product) {
        
        
        if(prdct.CustomProdName__c.contains(myString1)) 
        {   
        if(rO.FieldA__c !=null || rO.FieldB__c !=null)
        	{ 
        	i = rO.FieldA__c; 
        	i++;                     //Updates Counter
        	rO.FieldA__c = i;       // Assigns counter to field  
        	j = prdct.UnitPrice;
        	rO.FieldB__c += j;
        	}
        	else{
        	rO.FieldA__c = 0;	// To avoid null exception
        	rO.FieldB__c = 0;
        	i = rO.FieldA__c; 
        	i++;                   //Updates Counter
        	rO.FieldA__c = i;     // Assigns counter to field  
        	j = prdct.UnitPrice;
        	rO.FieldB__c += j;
        	}
        }
        else
        if(prdct.CustomProdName__c.contains(myString2)) 
        {
            if(rO.FieldC__c !=null || rO.FieldD__c !=null)
            {
                i = rO.FieldC__c;  
        	i++;                    //Updates Counter
        	rO.FieldC__c = i;      // Assigns counter to field  
        	j = prdct.UnitPrice;
        	rO.FieldD__c += j;
            }
            else{
            rO.FieldC__c = 0;
            rO.FieldD__c = 0;
           i = rO.FieldC__c;  
        	i++;                    //Updates Counter
        	rO.FieldC__c = i;      // Assigns counter to field  
        	j = prdct.UnitPrice;
        	rO.FieldD__c += j;
            }
        }
    
    }// for loop
    
    // for updating field
     
     	update rO;
     
     
} // for trigger

In my revenue object I do have a Lookip relationship field to the opportunity. I understand that i should check for for opportunity id in the code..but I am having a hard time tryiing to figure this out.

I apoloize for the long post. but any help will be a bonus for me.

thanks in advance for al the help.