Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25 2. Test environment support @testVisible , @testSetUp as well 3. Unit test is to test particular piece of code working properly or not . 4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword . 5. To deploy to production at-least 75% code coverage is required 6. System.debug statement are not counted as a part of apex code limit. 7. Test method and test classes are not counted as a part of code limit 9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record . Single Action -To verify that the the single record produces the correct an expected result . Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records . Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit . Negative Testcase :-Not to add future date , Not to specify negative amount. Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest . 11 . @isTest annotation with test method is equivalent to testMethod keyword . 12. Test method should static and no void return type . 13. Test class and method default access is private ,no matter to add access specifier . 14. classes with @isTest annotation can't be a interface or enum . 15. Test method code can't be invoked by non test request . 16. Stating with salesforce API 28.0 test method can not reside inside non test classes . 17. @Testvisible annotation to make visible private methods inside test classes. 18. Test method can not be used to test web-service call out . Please use call out mock . 19. You can't send email from test method. 20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) . 21. SeeAllData=true will not work for API 23 version eailer . 22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName'). 23. Create TestFactory class with @isTest annotation to exclude from organization code size limit . 24. @testSetup to create test records once in a method and use in every test method in the test class . 25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API. 26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization. 27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing . 28. System.runAs will not enforce user permission or field level permission . 29. Every test to runAs count against the total number of DML issued in the process .
public List<SelectOption> statusOptions {get;set;}
public string id{get;set;}
public User__c user{get; set;}
public UserController() { statusOptions = new List<SelectOption>(); statusOptions.add(new SelectOption('Active', 'Active')); statusOptions.add(new SelectOption('Inactive', 'Inactive')); id = apexpages.currentpage().getparameters().get('id'); user = new User__c();
if (id != null) { user = [SELECT Id, FirstName__c, LastName__c, MobilePhone__c, Username__c, Status__c FROM User__c where id =:id]; } }
Please let us know if this will help u
All Answers
Please check below blog for more information on test classes
http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html
Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .
Please let us know if this post will help you
Thanks
Amit Chaudhary
Thanks for your help. Still its not covered those lines.
Kind Regards,
Mohan
This is my controlller:
public with sharing class UserController {
public List<SelectOption> statusOptions {get;set;}
public string id{get;set;}
public User__c user{get; set;}
public UserController()
{
statusOptions = new List<SelectOption>();
statusOptions.add(new SelectOption('Active', 'Active'));
statusOptions.add(new SelectOption('Inactive', 'Inactive'));
id = apexpages.currentpage().getparameters().get('id');
user = new User__c();
if (id != null) {
user = [SELECT Id, FirstName__c, LastName__c, MobilePhone__c, Username__c, Status__c FROM User__c where id =:id];
}
}
public pageReference saveUser()
{
try {
if (id == null) {
User__c users = new User__c();
users.Username__c = user.Username__c;
users.FirstName__c = user.FirstName__c;
users.LastName__c = user.LastName__c;
users.MobilePhone__c = user.MobilePhone__c;
users.Status__c = user.Status__c;
DMLManager.insertAsUser(users);
} else {
DMLManager.updateAsUser(user);
}
pageReference pg = new pagereference('/apex/UserList?sfdc.tabName=01r24000000B6hf');
pg.setRedirect(true);
return pg;
} catch (Exception e) {
ApexPages.Message msg = new ApexPages.Message(ApexPages.Severity.ERROR, 'Username already exists: '+user.Username__c);
ApexPages.addMessage(msg);
return null;
}
}
}
Test Class:
@isTest
public with sharing class TestUserController {
static testMethod void testUserController() {
User__c user = new User__c();
user.FirstName__c = 'Mohan';
user.LastName__c = 'p';
user.MobilePhone__c = '079666665';
user.Username__c = 'mohan.puttu@test.com';
user.Status__c = 'Active';
insert user;
UserController userc = new UserController();
userc.id = null;
userc.saveUser();
if(user.id != null){
User__c userGet = [SELECT id, FirstName__c From User__c where Id = :user.id];
userc.saveUser();
system.assertEquals(user.FirstName__c, userGet.FirstName__c);
}
PageReference page = new PageReference('/apex/UserList?sfdc.tabName=01r24000000B6hf');
Test.setCurrentPage(page);
page.setRedirect(true);
System.assertNotEquals(null, page);
System.assertEquals('/apex/UserList?sfdc.tabName=01r24000000B6hf',page.getUrl());
}
}
Its not covered the following code lines. Its coverage 83% only.
user = [SELECT Id, FirstName__c, LastName__c, MobilePhone__c, Username__c, Status__c FROM User__c where id =:id];
pageReference pg = new pagereference('/apex/UserList?sfdc.tabName=01r24000000B6hf');
pg.setRedirect(true);
return pg;
Please help out this issue.
Kind Regrds,
Mohan
Please let us know if this will help u
Thank you very much for your help, I have added some test cases now that code coverage 100%.
Kind Regards,
Mohan