function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Eelco LitjensEelco Litjens 

Need test class for trigger(s)

i edited 2 triggers for my org. i tried to deploy them to production, but got code coverage error.
Is ther anybody who can help me with writing a test class for them. I must confess i don't get how to write that..

the first trigger: 
	trigger updateQuoteLine1 on QuoteLineItem (before insert,before update) {

    string vMenuinformation;
    string vOptyId;
    string vPricebookEntryId;
    string vQuote;
 
    for(QuoteLineItem quoteLine : Trigger.new){
           
        vOptyId = quoteLine.OpportunityId__c;
        vPricebookEntryId = quoteLine.PricebookEntryId;
        
        for(OpportunityLineItem oppLine : [select Id, Menu_chart_Product_description__c from OpportunityLineItem where (OpportunityId = :vOptyId and PricebookEntryId = :vPricebookEntryId)]){
            vMenuinformation = oppLine.Menu_chart_Product_description__c;
        }
        
        quoteLine.Menu_chart_description__c = vMenuinformation;
   
    }
}

Second: 
trigger updateQuoteLine on OpportunityLineItem (after insert,after update) {

    string vMenuinformation;
    //string vOptyId;
    string vPricebookEntryId;
    string vQuoteId;
 
    for(OpportunityLineItem oppLine : Trigger.new){
    
        vMenuinformation = oppLine.Menu_chart_Product_description__c;
        //vOptyId = oppLine.OpportunityId;
        vPricebookEntryId = oppLine.PricebookEntryId;
        vQuoteId = oppLine.QuoteId__c;
    }
    for(QuoteLineItem quoteLine : [select Id from QuoteLineItem where (QuoteId = :vQuoteId and PricebookEntryId = :vPricebookEntryId)]){
        quoteLine.Menu_chart_description__c = vMenuinformation;
        update(quoteLine);
    }
    
}
Amit Chaudhary 8Amit Chaudhary 8
Please check below post. How to write Test class in salesforce. I hope that will help you
http://amitsalesforce.blogspot.in/search/label/Test%20Class
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
Eelco LitjensEelco Litjens
Hi Amit,
i'm afraid that i don't understand that, i don't know where to start, or what to write as i seem to fail to understand the logic of it all.
Abhishek BansalAbhishek Bansal
Hi Eelco,

Please try below test class :
 
@isTest
public class UpdateQuoteTest{
	static testMethod void UpdateQuoteTest() {
       
        Pricebook2 pb = new Pricebook2(Name = 'Standard Price Book 2009', Description = 'Price Book 2009 Products', IsActive = true );
        insert pb;
        Product2 prod = new Product2(Name = 'Testing Product', Family = 'Best Practices', IsActive = true);
        insert prod;
        List<Pricebook2> standardPbList = [select id, name, isActive from Pricebook2 where IsStandard = true ];
        List<PricebookEntry> listPriceBook = new List<PricebookEntry>();
        for(Pricebook2 p : standardPbList ){
        	PricebookEntry pbe = New PricebookEntry ();
        	pbe = new PricebookEntry(Pricebook2Id = p.Id, Product2Id = prod.Id, UnitPrice = 10000, IsActive = true, UseStandardPrice = false);
        	listPriceBook.add(pbe);
        }
        insert listPriceBook;
        
        Opportunity opp = new Opportunity(Name = 'Test Syndicated 2010', Type = 'Syndicated - New', StageName = 'Planning', CloseDate = system.today());
        insert opp;
        List<OpportunityLineItem> opplineList = new List<OpportunityLineItem>();
        for(PricebookEntry pricebook : listPriceBook){
        	OpportunityLineItem oli = new OpportunityLineItem ();
        	oli  = new OpportunityLineItem(opportunityId = opp.Id, pricebookentryId = pricebook.Id, Quantity = 1, UnitPrice = 7500, Description = '2007 CMR #4 - Anti-Infectives');
        	opplineList.add(oli);
        }
        insert opplineList;
        
        Quote quttest = new Quote (Name = 'qoutetest' , OpportunityId = opp.id , Pricebook2Id = pb.id );
        insert quttest ;
        //If Opportunity__c is not your custom object name than replace it with original API name.
        Opportunity__c testOpp = new Opportunity__c(Name = 'Test');
        insert testOpp;
        List<QuoteLineItem> listval = new   List<QuoteLineItem>();
        for(PricebookEntry pricebook : listPriceBook){
        	QuoteLineItem qutlineitemtest = new QuoteLineItem ();
        	qutlineitemtest = new QuoteLineItem(QuoteId = quttest .id ,Opportunity__c = testOpp.id, Quantity = 3.00 ,Annual_Vol__c = 1000 ,UnitPrice = 12 , PricebookEntryId = pricebook.id);
        	 listval.add(qutlineitemtest);
        }
        insert listval;
        
        opplineList[0].UnitPrice = 10000;
        update opplineList[0];
    }
}

It will cover your both triggers.
Let me know if you need any help.

Regards,
Abhishek
Eelco LitjensEelco Litjens
Hi Abhishek, 
first, thank you for the code. i changed it a bit, due to some errors while testing in sandbox.
now i think i almost got it right.. but can't understand last error.

Error Message System.DmlException: Insert failed. First exception on row 0; first error: FIELD_INTEGRITY_EXCEPTION, Price Book Entry ID: id value of incorrect type: 01s110000006CDbAAM: [PricebookEntryId]
Stack Trace Class.UpdateQuoteTest.UpdateQuoteTest: line 39, column 1

here is the code: 
@isTest(SeeAllData=true)
public class UpdateQuoteTest{
    static testMethod void UpdateQuoteTest() {
       
        Pricebook2 pb = new Pricebook2(Name = 'Standard Price Book 2009', Description = 'Price Book 2009 Products', IsActive = true );
        insert pb;
        Product2 prod = new Product2(Name = 'Testing Product', Family = 'Best Practices', IsActive = true);
        insert prod;
        List<Pricebook2> standardPbList = [select id, name, isActive from Pricebook2 where IsStandard = true ];
        List<PricebookEntry> listPriceBook = new List<PricebookEntry>();
        for(Pricebook2 p : standardPbList ){
            PricebookEntry pbe = New PricebookEntry ();
            pbe = new PricebookEntry(Pricebook2Id = p.Id, Product2Id = prod.Id, UnitPrice = 10000, IsActive = true, UseStandardPrice = false);
            listPriceBook.add(pbe);
        }
        insert listPriceBook;
        
        Opportunity opp = new Opportunity(Name = 'Test Syndicated 2010', StageName = 'Twinfield preferred supplier', CloseDate = system.today());
        insert opp;
        List<OpportunityLineItem> opplineList = new List<OpportunityLineItem>();
        for(PricebookEntry pricebook : listPriceBook){
            OpportunityLineItem oli = new OpportunityLineItem ();
            oli  = new OpportunityLineItem(opportunityId = opp.Id, pricebookentryId = pricebook.Id, Quantity = 1, UnitPrice = 10000, Description = '2007 CMR #4 - Anti-Infectives');
            opplineList.add(oli);
        }
        insert opplineList;
        
        Quote quttest = new Quote (Name = 'qoutetest' , OpportunityId = opp.id , Pricebook2Id = pb.id );
        insert quttest ;
        //If Opportunity__c is not your custom object name than replace it with original API name.
        Opportunity testOpp = new Opportunity(Name = 'Test', StageName = 'Twinfield preferred supplier', CloseDate = system.today());
        insert testOpp;
        List<QuoteLineItem> listval = new   List<QuoteLineItem>();
        for(PricebookEntry pricebook : listPriceBook){
            QuoteLineItem qutlineitemtest = new QuoteLineItem ();
            qutlineitemtest = new QuoteLineItem(QuoteId = quttest .id , Quantity = 3.00 ,UnitPrice = 12 , PricebookEntryId = pb.id);
             listval.add(qutlineitemtest);
        }
        insert listval;
        
        opplineList[0].UnitPrice = 10000;
        update opplineList[0];
    }
}

 
Abhishek BansalAbhishek Bansal
Hi Eelco,

Please change line no. 36 to :
qutlineitemtest = new QuoteLineItem(QuoteId = quttest .id , Quantity = 3.00 ,UnitPrice = 12 , PricebookEntryId = listPriceBook[0].id);

Let me know if you have any other issue.

Thanks,
Abhishek.
Eelco LitjensEelco Litjens
I changed it, and now getting: Error Message System.DmlException: Insert failed. First exception on row 0; first error: FIELD_INTEGRITY_EXCEPTION, The pricebook entry is in a different pricebook than the one assigned to the Order Confirmation, or Order Confirmation has no pricebook assigned.: [PricebookEntryId]
Stack Trace Class.UpdateQuoteTest.UpdateQuoteTest: line 39, column 1

The so called "Order Confirmation" is the Quote object in SFDC