function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
David HagenDavid Hagen 

Help with Code coverage and Unit test

Hi, I'm totally new to salesforce.  I have a trigger which calls external URL on insert and update.
I can't get 100% code coverage. I get 81% at sandbox but on production i get less then 75%.
Here is my trigger
trigger EmsTrigger on Contact (after insert, after update){
    List<Contact> contactsToUpdate = new List<Contact>{};
    String id;
   for (Contact con: Trigger.new){
        contactsToUpdate.add(con);
        id=con.Id;
   }
   if(!contactsToUpdate.isEmpty()){
      if(UserInfo.getProfileId()!='hidden profileid'){
        Integer i=[select count() from Enrolment__c WHERE contact__c=:id];
          if(i>0){
            String JSONString = JSON.serialize(contactsToUpdate);
            Ems.doCallout(JSONString);
          }
      }
        
    }
}
My unit test
@IsTest

public class testEmsTrigger {
    
    static testmethod void insertContact(){
      Contact con = new Contact();
      con.FirstName='David';
      con.LastName='Hagen';
      insert con;
     
       Test.startTest();
       Test.setMock(HttpCalloutMock.class, new ExampleCalloutMock());
       Test.stopTest();
    }
}

I think issue is here in the following line which does not excute when test is run.
if(i>0){
}
 
Best Answer chosen by David Hagen
Amit Chaudhary 8Amit Chaudhary 8
Please try below code.
@IsTest
public class testEmsTrigger 
{
    static testmethod void insertContact()
	{
		Contact con = new Contact();
		con.FirstName='David';
		con.LastName='Hagen';
		insert con;
		
		Enrolment__c enrol = new Enrolment__c();
		enrol.Contact__c=con.Id;
		enrol.CourseStartDate__c=Date.newInstance( 2016, 5, 5 ) ;
		enrol.Addedon__c=Date.newInstance( 2016, 5, 5 );
		insert enrol;
		
		Test.startTest();
			Test.setMock(HttpCalloutMock.class, new ExampleCalloutMock());
            con.FirstName ='Test1';
			update con;
			
		Test.stopTest();
    }
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Let us know if this will help you

Thanks
Amit Chaudhary
 

All Answers

JethaJetha
yes exactly, So to cover this line you have to create one Enrolment__c record. Please insert it as you have done for contact and then try again.

Let me know if you face the same isssue again...

​Thanks
Abu HashimAbu Hashim
U may need to insert a samle enrollement__c record associated with the Contact id u r inserting.
Ex:  
@IsTest

public class testEmsTrigger {
    
    static testmethod void insertContact(){
      Contact con = new Contact();
      con.FirstName='David';
      con.LastName='Hagen';
      insert con;
       Enrolment__c enr = new Enrolment__c();
       enr.contact__c = con.id;
       insert enr;

       Test.startTest();
       Test.setMock(HttpCalloutMock.class, new ExampleCalloutMock());
       Test.stopTest();
    }
}
Abu HashimAbu Hashim
Can u please put a debug statement as system.debug('Contactid+++++'+con.id); see if it's returning the value in logs!!!???
If it's null, please query the contact record and assign the contact id....
Amit Chaudhary 8Amit Chaudhary 8
Please try below code.
@IsTest
public class testEmsTrigger 
{
    static testmethod void insertContact()
	{
		Contact con = new Contact();
		con.FirstName='David';
		con.LastName='Hagen';
		insert con;
		
		Enrolment__c enrol = new Enrolment__c();
		enrol.Contact__c=con.Id;
		enrol.CourseStartDate__c=Date.newInstance( 2016, 5, 5 ) ;
		enrol.Addedon__c=Date.newInstance( 2016, 5, 5 );
		insert enrol;
		
		Test.startTest();
			Test.setMock(HttpCalloutMock.class, new ExampleCalloutMock());
            con.FirstName ='Test1';
			update con;
			
		Test.stopTest();
    }
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Let us know if this will help you

Thanks
Amit Chaudhary
 
This was selected as the best answer
David HagenDavid Hagen
Hi Guys,
Thank you all for your help. I don't know what I had to the following code which made the code coverage 100%
con.FirstName ='Test1';
       update con;

Final code
@IsTest

public class testEmsTrigger {
    
    static testmethod void insertContact(){
      Contact con = new Contact();
      con.FirstName='David';
      con.AccountId='xxxxxx';
      con.recordTypeId='xxxxx';
      con.LastName='Hagen';
      insert con;
     System.debug('Contact id' + con.Id);
     Enrolment__c enrol = new Enrolment__c();
      enrol.Contact__c=con.Id;
      enrol.CourseStartDate__c=Date.newInstance( 2016, 5, 5 ) ;
      enrol.Addedon__c=Date.newInstance( 2016, 5, 5 );
      insert enrol;
      System.debug('Enrol id' + enrol.Id);
     
       Test.startTest();
       Test.setMock(HttpCalloutMock.class, new ExampleCalloutMock());
       con.FirstName ='Test1';
       update con;
       Test.stopTest();
    }
}

 
Amit Chaudhary 8Amit Chaudhary 8
Some information for  you
1) I just performed the update in your test class to execute the trigger. At the time of insert you willnot get the Enrolment__c object but before contact updated i added Enrolment__c record
2) I see you are using hardcord account id and recordtype id please try below code
 
@IsTest
public class testEmsTrigger 
{
    
    static testmethod void insertContact()
	{
		Account acc = new Account();
		acc.name ='Test Account';
		insert acc;

		// add just name or record type in below line
		Id contRecordTypeId = Schema.SObjectType.Contact.getRecordTypeInfosByName().get('NameOfRecordType').getRecordTypeId(); 
		
		Contact con = new Contact();
		con.FirstName='David';
		con.AccountId=acc.id;
		con.recordTypeId=contRecordTypeId;
		con.LastName='Hagen';
		insert con;
		System.debug('Contact id' + con.Id);
		
		Enrolment__c enrol = new Enrolment__c();
		enrol.Contact__c=con.Id;
		enrol.CourseStartDate__c=Date.newInstance( 2016, 5, 5 ) ;
		enrol.Addedon__c=Date.newInstance( 2016, 5, 5 );
		insert enrol;
		
		System.debug('Enrol id' + enrol.Id);

		Test.startTest();
			Test.setMock(HttpCalloutMock.class, new ExampleCalloutMock());
			con.FirstName ='Test1';
			update con;
		Test.stopTest();
    }
}

Let us know if this will help  you

Thanks
Amit Chaudhary
David HagenDavid Hagen
Thank you Sir. I still don't get the idea of con.FirstName ='Test1'; update con; As Abu Hisam suggest the debug the Contact ID and Enrolment ID. I was getting both Ids. Thanks againf for your help.
Amit Chaudhary 8Amit Chaudhary 8
As per your trigger code. you are fatching Enrolment__c record and checking size of that
Integer i=[select count() from Enrolment__c WHERE contact__c=:id];
          if(i>0)
          {
            String JSONString = JSON.serialize(contactsToUpdate);
            Ems.doCallout(JSONString);
          }
      

So at the time of insert size of Enrolment__c is zero because we added Enrolment__c record after contact insert.
So to execute trigger again i just added update call.

con.FirstName ='Test1'; // you can update any field
update con; // We just need this update call

I hope this will help you
David HagenDavid Hagen
I just got a quick question for the trigger. I don't let the trigger to be executed if the user is let's say 'ABC'.  To test and get code coverage 100% I need to run unit test as different user. If I logged in as ABC and do the test and code coverage, I don't get good result. Is there tips so I can put condition like if it is test then add condtion 'if(UserInfo.getProfileId()!='hidden profileid'){' otherwise, use this condition
David HagenDavid Hagen
I get the following errors when tries to deploy
 
System.DmlException: Insert failed. First exception on row 0; first error: INSUFFICIENT_ACCESS_ON_CROSS_REFERENCE_ENTITY, insufficient access rights on cross-reference id: 001p0000004MwlH: [] 
Stack Trace: Class.testEmsTrigger.insertContact: line 11, column 1