You need to sign in to do that
Don't have an account?
colin Berrouard
Insert trigger
I am new in Salesforce
When I insert an object, I want to update a record of another object.
So I use a trigger after insert
My code
trigger TRG_Reservation on Reservation_Field__c (after insert) {
Available_Field__c a = [SELECT Name FROM Available_Field__c WHERE Name = :name];
a.available_flag = 'NO';
update a;
}
Thanks for your help
colin
When I insert an object, I want to update a record of another object.
So I use a trigger after insert
My code
trigger TRG_Reservation on Reservation_Field__c (after insert) {
Available_Field__c a = [SELECT Name FROM Available_Field__c WHERE Name = :name];
a.available_flag = 'NO';
update a;
}
Thanks for your help
colin
All Answers
1) you have to use the array trigger.new . You should google that.
2) your custom fields api name must end with __c
3) you should also check what happens if select returns empty...
Here is a basic code that should work:
trigger TRG_Reservation on Reservation_Field__c (after insert) {
Available_Field__c a = [SELECT id, Name FROM Available_Field__c WHERE Name = :trigger.new[0].name];
a.available_flag__c = 'NO';
update a;
}
1st thing you can't write trigger on field make sure you are writing on object
Sample trigger:
Trigger tiggername on objectname (after insert,after update,before insert)
{
if(Trigger.isAfter && Trigger.isInsert)
{
List<Available_Field__c> af = new List<Available_Field__c> () ;
for(Available_Field__c aa:[SELECT id, Name FROM Available_Field__c WHERE Name IN :trigger.new.name])
{
aa.available_flag__c = 'NO';
af.add(aa);
}
update af;
}
}
It look like you are learning Apex trigger. I will recommend you to please work on below trailhead module for learning in a fun way.
1) https://developer.salesforce.com/trailhead/module/apex_triggers
2) https://developer.salesforce.com/trailhead/apex_triggers/apex_triggers_bulk
3) https://developer.salesforce.com/trailhead/apex_triggers/apex_triggers_intro
Sample code for you to update other object from trigger.
Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework
1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts
2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.
3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers
4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.
5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception
6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits
7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore
8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found
9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
Let us know if this will help you
Thanks
Amit Chaudhary
Please find the below trigger:
Here I considered:
(1) Naming Convention
(2) Bulkifying the code.
(3) Tested the code in DE environment and everything looks good.
For your example:
I couldn't test your code as I don't have setup in my environment.
Please do let me know if it helps you.
Regards,
Mahesh
I am geting this error : Error: Compile Error: Loop must iterate over a collection type: Terrain_Disponible__c at line 8 column 38
You can use above code.
Regards,
Mahesh
trigger TRG_Reservation2 on Reservation_Terrain__c (after insert) {
Set<String> nameSet = new Set<String>();
for(Terrain_disponible__c rf: Trigger.new) {
nameSet.add(rf.Name);
}
List<Terrain_disponible__c> afList = [SELECT Id, Name FROM Terrain_disponible__c WHERE Name IN: nameSet];
if(afList != null && !afList.isEmpty()) {
for(Terrain_disponible__c af: afList) {
af.available = 'NO';
}
update afList;
}
}
Here my schema objects
the Insert trigger is on "Reservation Terrain" object, when I insert a record in this object by selecting a record from "Terrain Disponible" object. I want to update "Available" field (from Yes to No) in "Terrain Disponible" object.
Please find the below Code:
Regards,
Mahesh
Error: Compile Error: Initial term of field expression must be a concrete SObject: Set<Id> at line 8 column 9
colin
A big thank for your time
colin
Glad it worked and helped you.
Please mark it solved so that it will be helpful to others in the future.
Regards,
Mahesh