function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
John NeffJohn Neff 

Why am I getting a code coverage error if my test coverage is 75% and my new class has a corresponding test?

Hello, 

I am trying to deploy an apex class and corresponding test class, but I am recieving a code coverage error during deployment. 

Before deployment, the "Estimate my Org's Code Coverage" link says I am 75% covered, and when I "run all tests" every test that is not part of a managed package passes. 

However, when I go to deploy my latest class and test class, I get an error saying that my code coverage is only at 73%.  Here is what I am trying to deploy: 

Class
public with sharing class CloseQTRController
{

public List <Buyer__c> Buyer {get;set;}
public list<String> salesqtrs {get;set;}

public void load() 
{
  salesqtrs= new List<String>();
  Buyer = [Select id, name, Routing_Status__c, Sales_Quarter__c, Funds_Collected_All_Time__c, Sales_Origination_Date__c, Sales_LN__c from Buyer__c WHERE Current_FQ_Buyer__c = FALSE ORDER BY Sales_Origination_Date__c ASC]; 
  
  Set<String> salesqtrSet = new Set<String>();
  for (Buyer__c j : Buyer)
      salesqtrSet.add(j.Sales_Quarter__c);
      
      for (String salesqtr : salesqtrSet) 
      {
            salesqtrs.add(salesqtr);
      }
      salesqtrs.sort();
    }
}

Test Class
@isTest(seeAllData = false)
public class CloseQTRControllerTest{
    // Unit test Method
    static testmethod void UnitTest() {
        //Create your buyer__c record with required field
        //Buyer__c b = new Buyer(Current_FQ_Buyer__c = TRUE);
        //insert b;
        test.startTest();
            CloseQTRControllerTest qt = new CloseQTRControllerTest();
        test.stopTest();
    }   
}

What can/should I do to get this to pass?  Why is this one class bringing my code coverage down 2%?  I am not an expert by any means, so I would really appreciate the help!

Thanks in advance!

John
Best Answer chosen by John Neff
Amit Chaudhary 8Amit Chaudhary 8
I see you are not creating Test Data in your test class that is why your code coverage is getting down.
Please try below code and add all required field in your test class.
@isTest
public class CloseQTRControllerTest
{
    static testmethod void UnitTest() 
	{
        Buyer__c b = new Buyer();
        b.Current_FQ_Buyer__c = FALSE ;
		// add all required field here
		insert b;
		
        test.startTest();
            CloseQTRControllerTest qt = new CloseQTRControllerTest();
        test.stopTest();
    }   
}

Please check below post to learn about test class.
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/search/label/Test%20Class
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

All Answers

Temoc MunozTemoc Munoz
Hi Jon.

Please remember that the test coverage percentage is related to your Production Org. If you have 75% in Sandbox, this does not mean you also have 75% in Production or that you're going to hit 75% once you upload your class.

So, 
- Make sure you upload all necessary classes in your change set.
- Make sure the same class CloseQTRControlleris also in Production as well. 
- Make sure CloseQTRController is the same in both instances, if not, make sure that you're testing the correct paths in the code.
- If your overall coverage is only 75%, I will suggest increasing the other classes as well. Run all tests in Production and check which classes are low in coverage. At least 75% is required, but gettting 90% or above would be ideal.

Thanks
Amit Chaudhary 8Amit Chaudhary 8
I see you are not creating Test Data in your test class that is why your code coverage is getting down.
Please try below code and add all required field in your test class.
@isTest
public class CloseQTRControllerTest
{
    static testmethod void UnitTest() 
	{
        Buyer__c b = new Buyer();
        b.Current_FQ_Buyer__c = FALSE ;
		// add all required field here
		insert b;
		
        test.startTest();
            CloseQTRControllerTest qt = new CloseQTRControllerTest();
        test.stopTest();
    }   
}

Please check below post to learn about test class.
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/search/label/Test%20Class
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
This was selected as the best answer
John NeffJohn Neff
Thank you very much Amit that did the trick!