function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Toby TarczyToby Tarczy 

Problem with test class and lookup fields

I have had some help in creating a trigger to populate the Name field of a customer object, Work_Request_Resource_c, Now I am trying to create a test class for the trigger and this is what I have come up with:

Trigger:

trigger WorkResourceTrigger on Work_Request_Resource__c( before insert, before update )
{
    Set<Id> contactIds = new Set<Id>();
    for( Work_Request_Resource__c res : trigger.new )
    {
        if( res.Contact__c != null )
        {
            contactIds.add( res.Contact__c );
        }
    }
    
    Map<Id, Contact> contactMap = new Map<Id, Contact>([ Select Id, Name from Contact where Id IN :contactIds ]);
    
    for( Work_Request_Resource__c res : trigger.new )
    {
        if( res.Contact__c != null )
        {
            res.Name = contactMap.get( res.Contact__c ).Name;
        }
    }
}

Test Class

@IsTest
public class WorkRequestResource {

    static testmethod void insertWork_Request_Resource_c(){
    
    Work_Request_Resource__c r = new Work_Request_Resource__c();
    
  
    r.name = 'Temp';
    
    //Get list of Accounts
    
    r.supplier__c = 'DCCL';
    r.contact__c = 'Julian, Rogers';
    
    insert r;
    
    }
    }

I am not sure how to test the  2 lookup fields, Supplier - Accounts which have been filtered on Type, to be "Supplier", and Resource.Name__c looking up the Contacts from the selected Supplier.

I have been trying to find some sample code on Google but I have not been able to get pass this point. many thanks in advance
Best Answer chosen by Toby Tarczy
Toby TarczyToby Tarczy
Thank you so much, worked the first time!

All Answers

Shikha AgashiShikha Agashi
Try following way:
 
static testmethod void insertWork_Request_Resource_c(){
    
    
    
	 Account testAccount = new Account();
	testAccount.Name='Test Account' ;
    insert testAccount;
	
	Contact cont = new Contact();
	cont.FirstName='Test';
	cont.LastName='Test';
	cont.Accountid= testAccount.id;
	insert cont;
	
	Work_Request_Resource__c r = new Work_Request_Resource__c();
    r.name = 'Temp';
    
    //Get list of Accounts
    
    r.supplier__c = testAccount.Id;
    r.contact__c = Cont.Id;
    
    insert r;
    
    }
    }

 
Amit Chaudhary 8Amit Chaudhary 8
Please try below test class. I hope that will help you
@IsTest
public class WorkRequestResource 
{
    static testmethod void insertWork_Request_Resource_c()
	{
		Account testAccount = new Account();
	    testAccount.Name='DCCL' ;
	    insert testAccount;

	    Contact cont = new Contact();
	    cont.FirstName='Julian';
	    cont.LastName='Rogers';
	    cont.Accountid= testAccount.id;
	    insert cont;
		
		Work_Request_Resource__c r = new Work_Request_Resource__c();
		r.name = 'Temp';
		r.supplier__c = testAccount.id ; // If it is account lookup
		r.contact__c = cont.id; // if it is contact lookup
		insert r;
    
    }
}
Please check below post to learn about test classes .
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html
Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 
Toby TarczyToby Tarczy
Thank you so much, worked the first time!
This was selected as the best answer
Toby TarczyToby Tarczy
Thank you fro pointing me in the right direction, it si a mine field out there trying to find good examples to work from.
Toby TarczyToby Tarczy
Apologies I thought I had. I am not a big fan of the how the web pages are laid out. But thank you for your great support! Kind Regards, Toby Tarczy www.calvella.com M: +44 77991 33349 Calvella Limited This message is confidential and may contain privileged information. It is for use by the person or entity to which it is addressed only. If you are not the intended recipient, you must not use, disclose, distribute, copy, print, rely on this message or make any other use of it. If an addressing or transmission error has miss-directed this e-mail, please notify the author by replying to this e-mail and delete the material from any computer. Calvella Limited accepts no responsibility for changes made neither to this message after it was sent nor for any loss or damage arising from its receipt or use. You are advised to check the message for computer viruses using your own software before opening any attachments. Calvella Limited, reserves the right to monitor e-mails and any replies sent back. Registered address, 62 The Street, Ashtead, Surrey, KT21 1AT, United Kingdom. Registered in England and Wales Company No. 6052142; Vat Reg. No 894273877.