function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Elizabeth1842Elizabeth1842 

Creating test code for simple controller

This is probably pretty basic but I'm new to Visualforce.

I'm looking for how I would create a test for controller like the trailhead on Creating & Using Custom Controllers.
https://developer.salesforce.com/trailhead/visualforce_fundamentals/visualforce_custom_controllers

The test page code is:
<apex:page controller="ContactsListController">
    <apex:form>
        <apex:pageBlock title="Contacts List" id="contacts_list">
            
<apex:pageBlockTable value="{! contacts }" var="ct"> 
<apex:column value="{! ct.FirstName }"/> 
<apex:column value="{! ct.LastName }"/> 
<apex:column value="{! ct.Title }"/> 
<apex:column value="{! ct.Email }"/>
 </apex:pageBlockTable>

        </apex:pageBlock>
    </apex:form>
</apex:page>
And the controller code:
public class ContactsListController {

private String sortOrder = 'LastName';
    
public List<Contact> getContacts() {
    
    List<Contact> results = Database.query(
        'SELECT Id, FirstName, LastName, Title, Email ' +
        'FROM Contact ' +
        'ORDER BY ' + sortOrder + ' ASC ' +
        'LIMIT 10'
    );
    return results;
}

public void sortByLastName() {
    this.sortOrder = 'LastName';
}
    
public void sortByFirstName() {
    this.sortOrder = 'FirstName';
}

}
I have similiar code working in my sandbox, but am not sure where to start to create run tests for this. Any help would be appreciated.

Thanks.


 
Best Answer chosen by Elizabeth1842
Amit Chaudhary 8Amit Chaudhary 8
Hi,

Please check below post to learn about test classes in salesforce
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please check below post for multiple exaple of test classes for Trigger, Controller and Extension etc
1) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please try to use below best pratice for test classes.
1) Try to avoid SeeAllData (http://amitsalesforce.blogspot.in/2015/09/test-classes-with-istest.html)in test class.
2) Try to use Assert (http://amitsalesforce.blogspot.in/2015/06/salesforce-testing-best-practice.html)in test classes.
3) Use StartTest (http://amitsalesforce.blogspot.in/2015/02/starttest-and-stoptest-method.html)and stopTest Method .

Please try below class.
@isTest
public class ContactsListControllerTest 
{
	static testMethod void testSortByLastName() 
	{
		Account acc = new Account();
		acc.Name='Test Account' ;
		insert acc;
		
		List<Contact> lstCont = new List<Contact>();
		for(Integer i = 1; i <=10 ;i++)
		{
			Contact cont = new Contact();
			cont.FirstName='Test '+i;
			cont.LastName='Test';
			cont.Email='demo@demo.com';
			cont.Accountid=acc.id;
			lstCont.add(cont);
		}
		
		insert lstCont;

		Test.StartTest();		
		
			ContactsListController contListCont = new ContactsListController();
			contListCont.sortByLastName();
			List<Contact> conList = contListCont.getContacts();
			System.assert(conList.size() > 0);
			
			contListCont.sortByFirstName();
			conList = contListCont.getContacts();
			System.assert(conList.size() > 0);	
			
		Test.StopTest();		
		
	}
}


Please do let me know if it helps you.
 

All Answers

Mahesh DMahesh D
Hi,

Please find the Test Class for your Controller:
 
@isTest
public class TestContactsListController {
	@isTest
	public static void testSortByLastName() {
		Account acc = new Account();
		acc.Name='Test Account' ;
		insert acc;

		Contact cont = new Contact();
		cont.FirstName='Test';
		cont.LastName='Test';
		cont.Email='demo@demo.com';
		cont.Accountid=acc.id;
		insert cont;
		
		ContactsListController clc = new ContactsListController();
		clc.sortByLastName();
		List<Contact> conList = clc.getContacts();
		System.assert(conList.size() > 0);
		clc.sortByFirstName();
		conList = clc.getContacts();
		System.assert(conList.size() > 0);		
	}
}

Please check below post for test classes.
1) https://developer.salesforce.com/page/An_Introduction_to_Apex_Code_Test_Methods


Please follow below salesforce Best Practice for Test Classes :

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process.

Please do let me know if it helps you.

Regards,
Mahesh
Amit Chaudhary 8Amit Chaudhary 8
Hi,

Please check below post to learn about test classes in salesforce
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please check below post for multiple exaple of test classes for Trigger, Controller and Extension etc
1) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please try to use below best pratice for test classes.
1) Try to avoid SeeAllData (http://amitsalesforce.blogspot.in/2015/09/test-classes-with-istest.html)in test class.
2) Try to use Assert (http://amitsalesforce.blogspot.in/2015/06/salesforce-testing-best-practice.html)in test classes.
3) Use StartTest (http://amitsalesforce.blogspot.in/2015/02/starttest-and-stoptest-method.html)and stopTest Method .

Please try below class.
@isTest
public class ContactsListControllerTest 
{
	static testMethod void testSortByLastName() 
	{
		Account acc = new Account();
		acc.Name='Test Account' ;
		insert acc;
		
		List<Contact> lstCont = new List<Contact>();
		for(Integer i = 1; i <=10 ;i++)
		{
			Contact cont = new Contact();
			cont.FirstName='Test '+i;
			cont.LastName='Test';
			cont.Email='demo@demo.com';
			cont.Accountid=acc.id;
			lstCont.add(cont);
		}
		
		insert lstCont;

		Test.StartTest();		
		
			ContactsListController contListCont = new ContactsListController();
			contListCont.sortByLastName();
			List<Contact> conList = contListCont.getContacts();
			System.assert(conList.size() > 0);
			
			contListCont.sortByFirstName();
			conList = contListCont.getContacts();
			System.assert(conList.size() > 0);	
			
		Test.StopTest();		
		
	}
}


Please do let me know if it helps you.
 
This was selected as the best answer