function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
ChickenOrBeefChickenOrBeef 

Test class for custom controller (A first for me!)

Hey everyone,

I had to create my first custom controller that allows for one of my visual flows to be re-directed to the created record (an Account) at the end of the flow. The controller works great, but now I need to create my first custom controller test class.

Here is the custom controller:
 
public class ControllerNewSubAccount{

    public ControllerNewSubAccount(ApexPages.StandardController controller) {

    }

    
 public Flow.Interview.Create_Account_w_Parent crAcc {get;set;}
    
 public PageReference prFinishLocation {
     
     get{
         
         PageReference prRef = new PageReference('/' + strOutputVariable);
         prRef.setRedirect(true);
         return prRef;
         
     }
     set{prFinishLocation = value;}
     
 }

 public String strOutputVariable {
     
     get{
         
         String strTemp = '';
        
         if(crAcc != null) {
             
         	strTemp = string.valueOf(crAcc.getVariableValue('AccountID'));
             
         }
        
         return strTemp;
         
     }
     set{strOutputVariable = value;}
     
 }
 
}

Here is the beginnings of the test class I created (but obviously this only covers the first few lines):
 
@isTest
public class TestVisualforceControllers {
    
    static testmethod void testControllerNewSubAccount(){
        
        Account a = New Account(Name='Tester');
        INSERT a;
        ApexPages.StandardController sc = new ApexPages.standardController(a);
        ControllerNewSubAccount e = new ControllerNewSubAccount(sc);
        
    }

}

I have no idea how to approach this. I'm assuming I need to trigger the flow somehow, or something along those lines.

Thanks,
Greg
Best Answer chosen by ChickenOrBeef
Amit Chaudhary 8Amit Chaudhary 8
Please try below test class.
@isTest
public class TestVisualforceControllers {
    
    static testmethod void testControllerNewSubAccount()
	{
        
        Account a = New Account(Name='Tester');
        INSERT a;
		
        ApexPages.StandardController sc = new ApexPages.standardController(a);
        ControllerNewSubAccount contrObj = new ControllerNewSubAccount(sc);
        String strstrOutputVariable  = contrObj.strOutputVariable ;
		PageReference  p = contrObj.prFinishLocation ;
		
    }

}
Please check below post for test classes.
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html


Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
 

All Answers

Amit Chaudhary 8Amit Chaudhary 8
Please try below test class.
@isTest
public class TestVisualforceControllers {
    
    static testmethod void testControllerNewSubAccount()
	{
        
        Account a = New Account(Name='Tester');
        INSERT a;
		
        ApexPages.StandardController sc = new ApexPages.standardController(a);
        ControllerNewSubAccount contrObj = new ControllerNewSubAccount(sc);
        String strstrOutputVariable  = contrObj.strOutputVariable ;
		PageReference  p = contrObj.prFinishLocation ;
		
    }

}
Please check below post for test classes.
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html


Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
 
This was selected as the best answer
ChickenOrBeefChickenOrBeef
That got me to 76% coverage. Very nice. I heard that these visual flow re-direct controllers can't be fully covered, so I'm happy with that result.

Thank you sir!
-Greg