+ Start a Discussion
Angel HFAngel HF 

Wrapper Class Constructor not defined: [defLeadContact.lead].<Constructor>()

Hi Community

I need you help

I am not able to test  a wrapper class when I am trying to cretate a class on my tesstclass I am getting always an error I tried on several ways. The last erro I got it is :

--
Constructor not defined: [defLeadContact.lead].<Constructor>()
--
I have the constructor defined

Here i share part of the code that I cannot coverage, the wrapper class

public with sharing class  defLeadContact {
    @TestVisible public contact[] contactFields {get; set;}

// here code

     AggregateResult[] results2 = Database.query(
           'SELECT count(Id) Quantity, Country Status FROM Contact WHERE CreatedDate >= 2012-08-01T00:00:00Z AND CreatedDate <= 2016-03-23T00:00:00Z GROUP BY ROLLUP(Status, Country)'
        );
        
        contactFields = new List<contact>();
        for (AggregateResult ar : results2) {
            contactFields.add(new contact(ar));
        }


    // wrapper class to hold aggregate data    
    @TestVisible public class contact {
        public Integer Quantity { get; private set; }
        public String Country { get; private set;}
        public String Status{ get; private set;}
        

        @TestVisible public contact(AggregateResult ar) {
            Quantity = (Integer) ar.get('Quantity');
            Country = (String) ar.get('Country ');
        Status= (String) ar.get('Status');
        }
        
    }
}

This is my test

@isTest
private class TestLeadContact {

    @isTest static  void testContact() {
        defLeadContact.lead l =new defLeadContact.lead();
       
        
        //some code
    }
    
}
Thanks in advanse
Best Answer chosen by Angel HF
Amit Chaudhary 8Amit Chaudhary 8
Hi Angel,

I found some issue in your code.
1) All code you write inside class. Try to use constructor or method
2) no need to TestVisible for public variable
3) Try to avoid to use standard object Name.
4) You are using wrong field Name Country and status on contact. Actual Name is mailingCountry.

Please try below code.
public with sharing class defLeadContact 
{
    //@TestVisible no need to TestVisible for public variable

    public contactWrapper[] contactFields {get; set;}
    public AggregateResult[] results2 ;
    
    public defLeadContact() 
    {    
        String strQuery ='SELECT count(Id) Quantity, mailingCountry FROM Contact WHERE CreatedDate >= 2012-08-01T00:00:00Z AND CreatedDate <= 2016-04-23T00:00:00Z GROUP BY ROLLUP(mailingCountry)' ;
    
        if(Test.isRunningTest())
        {
            // This block is required as we cannt create the record in back date
            strQuery ='SELECT count(Id) Quantity, mailingCountry FROM Contact GROUP BY ROLLUP(mailingCountry)' ;
        }
        results2 =  Database.query(   strQuery   );
        
        contactFields = new List<contactWrapper>();
        for (AggregateResult ar : results2) 
        {
            contactFields.add(new contactWrapper(ar));
        }
    }
    
    //  Please try to avoid using same name as Standard object 
    public class contactWrapper 
    {
        public Integer Quantity { get; private set; }
        public String Country { get; private set;}
        public String Status{ get; private set;}
        

        public contactWrapper(AggregateResult ar) 
        {
            Quantity = (Integer) ar.get('Quantity');
            Country = (String) ar.get('mailingCountry');
            //Status = (String) ar.get('Status');
        }
    }
}

Test class.
@isTest
private class TestLeadContact {

    @isTest static  void testContact() {
        
        Account acc = new Account();
        acc.Name='Test Account' ;
        insert acc;

        Contact cont = new Contact();
        cont.FirstName='Test';
        cont.LastName='Test';
        cont.Email='demo@demo.com';
        cont.Accountid=acc.id;
        cont.mailingCountry ='USA';
        insert cont;

        defLeadContact dlc =new defLeadContact();
    }
}
I tested same code in my developer org and code is working fine with 93% code coverage,
User-added image

Please check below post for test classes.
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html


Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
 

All Answers

Mahesh DMahesh D
Hi Angel,

Please find the modified code:
 
public with sharing class defLeadContact {
    @TestVisible 
    public contact[] contactFields {get; set;}

    AggregateResult[] results2 = Database.query(
           'SELECT count(Id) Quantity, Country, Status FROM Contact WHERE CreatedDate >= 2012-08-01T00:00:00Z AND CreatedDate <= 2016-04-23T00:00:00Z GROUP BY ROLLUP(Status, Country)');
    
    public defLeadContact() {    
        contactFields = new List<contact>();
        for (AggregateResult ar : results2) {
            contactFields.add(new contact(ar));
        }
    }

    // wrapper class to hold aggregate data    
    @TestVisible 
    public class contact {
        public Integer Quantity { get; private set; }
        public String Country { get; private set;}
        public String Status{ get; private set;}
        

        @TestVisible public contact(AggregateResult ar) {
            Quantity = (Integer) ar.get('Quantity');
            Country = (String) ar.get('Country ');
            Status = (String) ar.get('Status');
        }
    }
}
Test Class:
 
@isTest
private class TestLeadContact {

    @isTest static  void testContact() {
        
        Account acc = new Account();
        acc.Name='Test Account' ;
        insert acc;

        Contact cont = new Contact();
        cont.FirstName='Test';
        cont.LastName='Test';
        cont.Email='demo@demo.com';
        cont.Accountid=acc.id;
        insert cont;

        defLeadContact dlc =new defLeadContact();
    }
}

But I am not sure about Country and Status fields under Contact object.

Please do let me know if it helps you.

Regards,
Mahesh

 
Amit Chaudhary 8Amit Chaudhary 8
Hi Angel,

I found some issue in your code.
1) All code you write inside class. Try to use constructor or method
2) no need to TestVisible for public variable
3) Try to avoid to use standard object Name.
4) You are using wrong field Name Country and status on contact. Actual Name is mailingCountry.

Please try below code.
public with sharing class defLeadContact 
{
    //@TestVisible no need to TestVisible for public variable

    public contactWrapper[] contactFields {get; set;}
    public AggregateResult[] results2 ;
    
    public defLeadContact() 
    {    
        String strQuery ='SELECT count(Id) Quantity, mailingCountry FROM Contact WHERE CreatedDate >= 2012-08-01T00:00:00Z AND CreatedDate <= 2016-04-23T00:00:00Z GROUP BY ROLLUP(mailingCountry)' ;
    
        if(Test.isRunningTest())
        {
            // This block is required as we cannt create the record in back date
            strQuery ='SELECT count(Id) Quantity, mailingCountry FROM Contact GROUP BY ROLLUP(mailingCountry)' ;
        }
        results2 =  Database.query(   strQuery   );
        
        contactFields = new List<contactWrapper>();
        for (AggregateResult ar : results2) 
        {
            contactFields.add(new contactWrapper(ar));
        }
    }
    
    //  Please try to avoid using same name as Standard object 
    public class contactWrapper 
    {
        public Integer Quantity { get; private set; }
        public String Country { get; private set;}
        public String Status{ get; private set;}
        

        public contactWrapper(AggregateResult ar) 
        {
            Quantity = (Integer) ar.get('Quantity');
            Country = (String) ar.get('mailingCountry');
            //Status = (String) ar.get('Status');
        }
    }
}

Test class.
@isTest
private class TestLeadContact {

    @isTest static  void testContact() {
        
        Account acc = new Account();
        acc.Name='Test Account' ;
        insert acc;

        Contact cont = new Contact();
        cont.FirstName='Test';
        cont.LastName='Test';
        cont.Email='demo@demo.com';
        cont.Accountid=acc.id;
        cont.mailingCountry ='USA';
        insert cont;

        defLeadContact dlc =new defLeadContact();
    }
}
I tested same code in my developer org and code is working fine with 93% code coverage,
User-added image

Please check below post for test classes.
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html


Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
 
This was selected as the best answer
Angel HFAngel HF
Hello Amit,

Thank you for your comments, when I edited  the class and  run your proposed tests I  am not getting a good percent pelase have a look what parts are not being coverage
User-added image
------------
User-added image

Thanks in advance

 
Amit Chaudhary 8Amit Chaudhary 8
Hi Angel,

I tested above code and test class in mt developer org and i got 93% code coverage.
Can you please post your apex class and test class which you are using ?
 
Angel HFAngel HF
Hi Amit,

I was Out, Thank you for your help ;)