function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
uHaveOptionsuHaveOptions 

Variable does not exist: Trigger --- field for getting date

What am I missing here?

trigger updateLastCallDate on Task (after insert, after update, after delete) {

    Set<Id> con_set = new Set<Id>();
    
    List<Contact> con_list = new List<Contact>();
    
    for(Task T: Trigger.new()){
        if(String.valueof(T.WhatId).startsWith('001') && T.Status=='Completed' && T.Subject=='Call' ){
            con_set.add(T.WhatId);
        }
        
     }
     
     for(AggregateResult aggregateResult:[SELECT max(createdDate)MaxCDate,WhatId FROM Task WHERE WhatID IN: con_set AND Status ='Completed' AND Subject ='Call' Group By WhatId]){
         con_list.add(new Contact(Id=(id)aggregateResult.get('WhatId'),Last_Call__c=date.valueof(aggregateResult.get('MaxCDate'))));
         
     }
     
     try{
     
         if(con_list !=null && con_list.size()>0){
             update con_list;
         }
     
     }Catch(Exception e){
         system.debug('Exception ***'+e.getMessage());
      
      }

}
Best Answer chosen by uHaveOptions
Amit Chaudhary 8Amit Chaudhary 8
NOTE:- WhatID is used for account, Oppottunity and all custom object
WHOID is used for contact and lead.

IF you want to use contact then please use whoID.
trigger updateLastCallDate on Task (after insert, after update, after delete) 
{
    Set<Id> con_set = new Set<Id>();
    List<Contact> con_list = new List<Contact>();
    for( Task T: Trigger.new )
	{
        if(String.valueof(T.whoid).startsWith('003') && T.Status=='Completed' && T.Subject=='Call' )
		{
            con_set.add(T.whoid);
        }
    }
     
     for(AggregateResult aggregateResult:[SELECT max(createdDate)MaxCDate,whoid FROM Task WHERE whoid IN: con_set AND Status ='Completed' AND Subject ='Call' Group By whoid])
	 {
        con_list.add(new Contact(Id=(id)aggregateResult.get('whoid'),Last_Call__c=date.valueof(aggregateResult.get('MaxCDate'))));
     }
     
    try
	{
     
         if(con_list !=null && con_list.size()>0)
		 {
             update con_list;
         }
     
    }Catch(Exception e){
         system.debug('Exception ***'+e.getMessage());
      
     }

}
Please check below post how to get prefix dynamicly
http://amitsalesforce.blogspot.in/2015/12/standard-field-record-id-prefix-decoder.html

Please let us know if this will help u

All Answers

Paul_BoikoPaul_Boiko
Hi Jon,
new is not method in Trigger. remove "()" so it's: 
 
for (Task t: Trigger.new) {

As a common practice mark best answer if it helped you.
Amit Chaudhary 8Amit Chaudhary 8
Please check below post. I hope that will help you for Trigger.
1) Trigger Context Variables http://amitsalesforce.blogspot.in/2015/10/trigger-context-variables.html
2) Trigger Best Practices | Sample Trigger Example | Implementing Trigger Framework http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

Please try below code. I hope that will help you
trigger updateLastCallDate on Task (after insert, after update, after delete) 
{
    Set<Id> con_set = new Set<Id>();
    List<Contact> con_list = new List<Contact>();
    for( Task T: Trigger.new )
	{
        if(String.valueof(T.WhatId).startsWith('001') && T.Status=='Completed' && T.Subject=='Call' )
		{
            con_set.add(T.WhatId);
        }
    }
     
     for(AggregateResult aggregateResult:[SELECT max(createdDate)MaxCDate,WhatId FROM Task WHERE WhatID IN: con_set AND Status ='Completed' AND Subject ='Call' Group By WhatId])
	 {
        con_list.add(new Contact(Id=(id)aggregateResult.get('WhatId'),Last_Call__c=date.valueof(aggregateResult.get('MaxCDate'))));
     }
     
    try
	{
     
         if(con_list !=null && con_list.size()>0)
		 {
             update con_list;
         }
     
    }Catch(Exception e){
         system.debug('Exception ***'+e.getMessage());
      
     }

}
1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers


4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Please let us know if this will help you
uHaveOptionsuHaveOptions

It's giving me an error...

Trigger name exists on different SObject type: Contact

If I change Task to contact then I have to change all "Task" then it gives me an error that WHATID doesnt exist.  Isnt the sObject has to be on contact?

Amit Chaudhary 8Amit Chaudhary 8
NOTE:- WhatID is used for account, Oppottunity and all custom object
WHOID is used for contact and lead.

IF you want to use contact then please use whoID.
trigger updateLastCallDate on Task (after insert, after update, after delete) 
{
    Set<Id> con_set = new Set<Id>();
    List<Contact> con_list = new List<Contact>();
    for( Task T: Trigger.new )
	{
        if(String.valueof(T.whoid).startsWith('003') && T.Status=='Completed' && T.Subject=='Call' )
		{
            con_set.add(T.whoid);
        }
    }
     
     for(AggregateResult aggregateResult:[SELECT max(createdDate)MaxCDate,whoid FROM Task WHERE whoid IN: con_set AND Status ='Completed' AND Subject ='Call' Group By whoid])
	 {
        con_list.add(new Contact(Id=(id)aggregateResult.get('whoid'),Last_Call__c=date.valueof(aggregateResult.get('MaxCDate'))));
     }
     
    try
	{
     
         if(con_list !=null && con_list.size()>0)
		 {
             update con_list;
         }
     
    }Catch(Exception e){
         system.debug('Exception ***'+e.getMessage());
      
     }

}
Please check below post how to get prefix dynamicly
http://amitsalesforce.blogspot.in/2015/12/standard-field-record-id-prefix-decoder.html

Please let us know if this will help u
This was selected as the best answer
uHaveOptionsuHaveOptions
I renamed a couple of times and the same error :(
uHaveOptionsuHaveOptions

@Amit I'm using this on the sObject: Contact

How come it's saying Trigger name exists on different SObject type: Contact
even if I rename it 10x already?