+ Start a Discussion
KnowledgeseekerKnowledgeseeker 

Need a Test Class for this simple Opportunity Trigger

Just wrote my first trigger and i need to write a test class for it. I'm not sure how to go about this. but it's a before update trigger (see below) and all it does is update a field on the Opportunity if another field is changed and is a certain value. I know i need to write a test class for this trigger to go into PROD.Thoughts on this one?

trigger UpdateOldStage on Opportunity (before insert, before Update) 
{
    for(Opportunity opp : trigger.new)
    {
        Opportunity oldopp = trigger.oldMap.get(opp.id);
        {
        If(opp.New_Stage__c != NULL)
        {
                If( opp.New_Stage__c != oldopp.New_Stage__c && opp.New_Stage__c == 'Close Opportunity')
                {
                    opp.StageName = 'Category 1';
                }
                else if(opp.New_Stage__c != oldopp.New_Stage__c && opp.New_Stage__c == 'Generate Opportunity')
                {
                    opp.StageName = 'Category 4';
                }  
                else if(opp.New_Stage__c != oldopp.New_Stage__c && opp.New_Stage__c == 'Gain Sponsorship')
                {
                    opp.StageName = 'Category 3';
                }
                else if(opp.New_Stage__c != oldopp.New_Stage__c && opp.New_Stage__c == 'Confirm Solution')
                {
                    opp.StageName = 'Category 2';
                }
                else if(opp.New_Stage__c != oldopp.New_Stage__c && opp.New_Stage__c == 'Closed/No Decision')
                {
                    opp.StageName = 'Closed/No Decision';
                }
                else if(opp.New_Stage__c != oldopp.New_Stage__c && opp.New_Stage__c == 'Closed Lost')
                {
                    opp.StageName = 'Closed Lost';
                }
       }
       }
    }
}
J CesarJ Cesar
The idea of a test class is to execute all possible scenarios in the code you intend to cover.

So, you would start with your test class and test method, then initiate 6 Opportunity records (1 for each scenario), then start your test with test.startTest();
Inside the test you insert all 6 opportunities: insert Opp1; insert Opp2; etc...
Make sure you set New_Stage__c field for each of the opportunities (you can do so in the object constructor) and after insert and before update change that value.
You can also elect to perform updates right after inserts: simply put update Opp1; update Opp2; etc...
Stop the test with test.stopTest();
Then perform system validation:
System.assertEquals(expected value, actual value); //for each of your test opportunities

Expected value is 'Category 1' for first opportunity and actual value would be Opp1.StageName, and so on for all the rest of them.

That's all it should require to give you 100% code coverage.

Although to be honest, I don't understand why you need before insert on the trigger if you're only checking for changed values...
KnowledgeseekerKnowledgeseeker
Thanks Cesar 16! Very consise. I'm going to remove the before insert part. Eventually I want to set the StageName based on New_Stage__c  value on insert (i have to figure this out) but until then i will remove. Also, could you help clarify how to set the New Stage on insert using the object constructor? As you mentioned above. Very much appreciated.
J CesarJ Cesar
Opportunity Opp1 = new Opportunity (Name='Test Opp 1', StageName='Category 1', ClosedDate=date.Today() + 30, New_Stage__c='Close Opportunity');

That's how you pass New Stage into Opportunity object constructor, other fields I'm passing are required fields for Opportunity. You perform the insert afterwards.
While you can update StageName based on New_Stage__c you need to set an initial value or the insert will fail because it's a required field (and you need the insert before you can perform update to run your test).
Amit Chaudhary 8Amit Chaudhary 8
Please try below test class.
@isTest 
public class UpdateOldStageTest 
{
	static testMethod void testMethod1() 
	{
		
		Account testAcct = new Account (Name = 'My Test Account');
		insert testAcct;

		Opportunity oppt = new Opportunity();
		oppt.Name ='New mAWS Deal';
		oppt.AccountID = testAcct.ID;
		oppt.StageName = 'Generate Opportunity';
		oppt.Amount = 3000;
		oppt.CloseDate = System.today();
		oppt.New_Stage__c = 'Generate Opportunity';
		insert oppt;

		oppt.New_Stage__c = 'Gain Sponsorship';
		update oppt;

		oppt.New_Stage__c = 'Confirm Solution';
		update oppt;
		
		oppt.New_Stage__c = 'Closed/No Decision';
		update oppt;

		oppt.New_Stage__c = 'Close Opportunity';
		update oppt;

		oppt.New_Stage__c = 'Closed Lost';
		update oppt;

	}
}
Please check below post for Test classes
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
KnowledgeseekerKnowledgeseeker
Amit i'm getting a error for this. I'm not sure what it is...User-added image any ideas?
Amit Chaudhary 8Amit Chaudhary 8
Please try to execute the Test class from salesforce UI.
User-added image

Please let us know if that will work
 
KnowledgeseekerKnowledgeseeker
I modified the testclass to the below; getting "Assertion Failed: Expected: Category 3, Actual: Category 4". Got 68% code Coverage for the Trigger. though.

@isTest (seeAllData=false)
public class UpdateOldStageTest
{
    static testMethod void testMethod1()
    {
        Account testAcct = new Account (Name = 'My Test Account',Legal_Name__c='My Test Account',BillingCountry='US',BillingStreet='409 Maple Ave',BillingPostalCode='18929',BillingCity='Maple',BillingState='PA',BU__c='Ambulatory',Type='Private Practice',Practice_Specialty__c='Cardiology');
        insert testAcct;

        Opportunity oppt = new Opportunity();
        oppt.Name ='New AWS Deal';
        oppt.AccountID = testAcct.ID;
        oppt.StageName = 'Category 4';
        oppt.CloseDate = System.today();
        oppt.New_Stage__c = 'Generate Opportunity';
        insert oppt;
        
Test.startTest();
        oppt.New_Stage__c = 'Gain Sponsorship';
        update oppt;
test.stopTest();
    System.assertEquals('Category 3', oppt.StageName);

Test.startTest();
        oppt.New_Stage__c = 'Confirm Solution';
        update oppt;
test.stopTest();
    System.assertEquals('Category 2', oppt.StageName);

Test.startTest();
        oppt.New_Stage__c = 'Closed/No Decision';
        update oppt;
test.stopTest();
    System.assertEquals('Closed/No Decision', oppt.StageName);

Test.startTest();
        oppt.New_Stage__c = 'Close Opportunity';
        update oppt;
test.stopTest();
    System.assertEquals('Category 1', oppt.StageName);

Test.startTest();
        oppt.New_Stage__c = 'Closed Lost';
        update oppt;
test.stopTest();
    System.assertEquals('Closed Lost', oppt.StageName);
    }
}

User-added image
Amit Chaudhary 8Amit Chaudhary 8
You need to query the same record again to check new value. Please update your code like below and let us know if this will help you
 
@isTest (seeAllData=false)
public class UpdateOldStageTest
{
    static testMethod void testMethod1()
    {
        Account testAcct = new Account (Name = 'My Test Account',Legal_Name__c='My Test Account',BillingCountry='US',BillingStreet='409 Maple Ave',BillingPostalCode='18929',BillingCity='Maple',BillingState='PA',BU__c='Ambulatory',Type='Private Practice',Practice_Specialty__c='Cardiology');
        insert testAcct;

        Opportunity oppt = new Opportunity();
        oppt.Name ='New AWS Deal';
        oppt.AccountID = testAcct.ID;
        oppt.StageName = 'Category 4';
        oppt.CloseDate = System.today();
        oppt.New_Stage__c = 'Generate Opportunity';
        insert oppt;
        
		Test.startTest();
			oppt.New_Stage__c = 'Gain Sponsorship';
			update oppt;
				
			oppt.New_Stage__c = 'Confirm Solution';
			update oppt;
				
			oppt.New_Stage__c = 'Closed/No Decision';
			update oppt;

			oppt.New_Stage__c = 'Close Opportunity';
			update oppt;

			oppt.New_Stage__c = 'Closed Lost';
			update oppt;

		Test.stopTest();
		
		List<Opportunity> lstOpp = [select id,StageName from Opportunity where id =:oppt.id];
		
		System.assertEquals('Closed Lost', lstOpp[0].StageName);

    }
}

 
Suraj Tripathi 47Suraj Tripathi 47
Hi Knowledgeseeker,

"You can try this code."
@isTest
public class CreateNewOpportunityTest
{
    @isTest
    public static void OpportunityTestMethod()
    {
      try{
        Account accountObj = new Account();
        accountObj .Name = 'Account1';
        insert accountObj ;
        
        Opportunity oppObj = new Opportunity();
        oppObj.Name = 'Opp1';
        oppObj.Accountid = accountObj.id;
        oppObj.StageName = 'Prospecting';
        oppObj.CloseDate = system.Today();
        oppObj.New_Stage__c = 'Generate Opportunity';
        insert oppObj;
       
    Test.startTest();
        oppObj.New_Stage__c = 'Closed Lost';
    update oppObj;            
    oppObj.New_Stage__c = 'Closed/No Decision';
    update oppObj;            
    oppt.New_Stage__c = 'Close Opportunity';
    update oppObj;
    oppObj.New_Stage__c = 'Confirm Solution';
    update oppObj;
    oppObj.New_Stage__c = 'Gain Sponsorship';
    update oppObj;

    Test.stopTest();
      }catch(Exception e){
        System.debug('Exception due to--->: '+e.getCause());
       }  
    }
}

If you find your Solution then mark this as the best answer. 

Thank you!

Regards 
Suraj Tripathi