function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
karan pkaran p 

please help me out to correct my test class

hello all

Below is my apex class could you please help me out to correct my test class to improve my code coverage 

public class callmeetings
{
    public Map<Id, Call_Meeting__c> cmMap {get; set;}
    public String selectedcm{get; set;}
    public String tuId;
    
    public callmeetings()
    {
        tuId = ApexPages.currentPage().getParameters().get('tId');        
        cmMap = new Map<Id, Call_Meeting__c>([Select Id, Name, User__c, User__r.Name, Treating_Unit__c from Call_Meeting__c WHERE Treating_Unit__c = null]);
    }
    
    
    public PageReference selectThis() {
        
        if(cmMap.containsKey(selectedcm))
        {
            Call_Meeting__c tempMeeting = cmMap.get(selectedcm);
            tempMeeting.Treating_Unit__c = tuId;
            update tempMeeting;
            return (new PageReference('/'+tuId));
        }
        else
        {
            return null;
        }
    }        
}

Test class 

@isTest
private class callmeetingsTest
{
    static testMethod void updateCallmeeting()
    {
        id uopAccountId;
        Schema.DescribeSObjectResult d1 = Schema.SObjectType.Account;
        Map<String,Schema.RecordTypeInfo> rtMap1 = d1.getRecordTypeInfosByName();
        Schema.RecordTypeInfo uoprt =rtMap1.get('UOP Accounts');
        uopAccountId=uoprt.getRecordTypeId(); 
       
        ContactRecordType__c rectype = new ContactRecordType__c();
        rectype.Name='UOP_AccountRecordType';
        rectype.UOP_Account_RecordType__c=uopAccountId;
        insert rectype;
        
        Profile p=[select id from Profile where Name='UOP - Business'];
        UOP_Profiles__c up=new UOP_Profiles__c();
        up.Name='UOP Profile ID List';
        up.UOP_Business__c=p.id;
        insert up;
        
        sales_district__c sd=new sales_district__c();
        sd.Name='INDIA';
        insert sd;
        system.debug('*******sales district********'+sd);
        
        Uop_geo_region__c ur=new Uop_geo_region__c ();
        ur.Name='INDIAN SUBCONTINENT';
        insert ur;
        system.debug('*******Uop_geo_region__c********'+ur); 
        
        SAP_Customer_Info__c testcustomer = new SAP_Customer_Info__c();       
        testcustomer.Name='100462';
        testcustomer.UOP_Company_Name__c='AGIPPETROIL SPA';
        testcustomer.UOP_Geographic_Region__c='EUR';
        testcustomer.UOP_Sales_District__c=sd.id;
        testcustomer.UOP_Geo_Region__c=ur.id;
        testcustomer.UOP_Address1__c='DEVKARAN MANSION IIND FLR';
        testcustomer.UOP_Address2__c='79 PRINCESS STREET';
        testcustomer.UOP_City__c='Hyderabad';
        testcustomer.UOP_Honeywell_Geo_Region__c='India';
        testcustomer.UOP_Country__c='INDIA';
        insert testcustomer; 
        system.debug('*******testcustomer********'+testcustomer);     
        
         
        Country__c c=new Country__c();
        c.Name='INDIA';
        c.Region__c='India';
        insert c;
        
        Account acc=new Account();
        acc.Name='Test Name';
        //acc.UOP_Delta_Type__c='Agent';
        acc.RecordTypeId=uopAccountId;
        acc.Sales_District__c=sd.id; 
        acc.SAP_Customer_Info__c=testcustomer.id;                
        acc.BillingStreet ='sfdc';
        acc.BillingState ='sfdc';
        acc.BillingCountry ='INDIA';
        acc.BillingPostalCode='12221';
        insert acc;
        system.debug('Account.country'+acc.BillingCountry);

        acc= [Select OwnerID, Owner.ID From Account where ID = :acc.id];
        system.assertNOTEquals(null,acc.OwnerID);
        system.assertNOTEquals(null,acc.Owner.ID);
        
        Treating_Units__c TU = New Treating_Units__c ();
        TU.Account__c=acc.ID;
        TU.Unit_Reference_number__c='D-206';
        TU.Contaminants_Removed__c='H2O';
        TU.Carrier_Stream__c='Natural GAS';
        insert TU;
        
        Call_Meeting__c CM = New Call_Meeting__c ();
        CM.Company__c= acc.ID;
        CM.Due_Date__c = Datetime.newInstance(2016, 8, 16);
        CM.Meeting_Location__c='Teleconference';
        insert CM; 
    }
}
Swaraj Behera 7Swaraj Behera 7
Hi Karan,Please use below test class.
 
@isTest
private class callmeetingsTest
{
    static testMethod void updateCallmeeting()
    {
        id uopAccountId;
        Schema.DescribeSObjectResult d1 = Schema.SObjectType.Account;
        Map<String,Schema.RecordTypeInfo> rtMap1 = d1.getRecordTypeInfosByName();
        Schema.RecordTypeInfo uoprt =rtMap1.get('UOP Accounts');
        uopAccountId=uoprt.getRecordTypeId(); 
       
        ContactRecordType__c rectype = new ContactRecordType__c();
        rectype.Name='UOP_AccountRecordType';
        rectype.UOP_Account_RecordType__c=uopAccountId;
        insert rectype;
        
        Profile p=[select id from Profile where Name='UOP - Business'];
        UOP_Profiles__c up=new UOP_Profiles__c();
        up.Name='UOP Profile ID List';
        up.UOP_Business__c=p.id;
        insert up;
        
        sales_district__c sd=new sales_district__c();
        sd.Name='INDIA';
        insert sd;
        system.debug('*******sales district********'+sd);
        
        Uop_geo_region__c ur=new Uop_geo_region__c ();
        ur.Name='INDIAN SUBCONTINENT';
        insert ur;
        system.debug('*******Uop_geo_region__c********'+ur); 
        
        SAP_Customer_Info__c testcustomer = new SAP_Customer_Info__c();       
        testcustomer.Name='100462';
        testcustomer.UOP_Company_Name__c='AGIPPETROIL SPA';
        testcustomer.UOP_Geographic_Region__c='EUR';
        testcustomer.UOP_Sales_District__c=sd.id;
        testcustomer.UOP_Geo_Region__c=ur.id;
        testcustomer.UOP_Address1__c='DEVKARAN MANSION IIND FLR';
        testcustomer.UOP_Address2__c='79 PRINCESS STREET';
        testcustomer.UOP_City__c='Hyderabad';
        testcustomer.UOP_Honeywell_Geo_Region__c='India';
        testcustomer.UOP_Country__c='INDIA';
        insert testcustomer; 
        system.debug('*******testcustomer********'+testcustomer);     
        
         
        Country__c c=new Country__c();
        c.Name='INDIA';
        c.Region__c='India';
        insert c;
        
        Account acc=new Account();
        acc.Name='Test Name';
        //acc.UOP_Delta_Type__c='Agent';
        acc.RecordTypeId=uopAccountId;
        acc.Sales_District__c=sd.id; 
        acc.SAP_Customer_Info__c=testcustomer.id;                
        acc.BillingStreet ='sfdc';
        acc.BillingState ='sfdc';
        acc.BillingCountry ='INDIA';
        acc.BillingPostalCode='12221';
        insert acc;
        system.debug('Account.country'+acc.BillingCountry);

        acc= [Select OwnerID, Owner.ID From Account where ID = :acc.id];
        system.assertNOTEquals(null,acc.OwnerID);
        system.assertNOTEquals(null,acc.Owner.ID);
        
        Treating_Units__c TU = New Treating_Units__c ();
        TU.Account__c=acc.ID;
        TU.Unit_Reference_number__c='D-206';
        TU.Contaminants_Removed__c='H2O';
        TU.Carrier_Stream__c='Natural GAS';
        insert TU;
        
        Call_Meeting__c CM = New Call_Meeting__c ();
        CM.Company__c= acc.ID;
        CM.Due_Date__c = Datetime.newInstance(2016, 8, 16);
        CM.Meeting_Location__c='Teleconference';
        insert CM; 

        Test.startTest();
        callmeetings calm = new callmeetings();
        calm.selectThis();
        Test.stopTest();



    }
}

Please keep below points in mind some point while writing Test class.

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .

Thanks,
Swaraj Behera
Amit Chaudhary 8Amit Chaudhary 8
You need to set tid like below
            ApexPages.currentPage().getParameters().put('tId',TU.id);
and selectedcm before calling selectThis method


Please update your test class like below
@isTest
private class callmeetingsTest
{
    static testMethod void updateCallmeeting()
    {
        id uopAccountId;
        Schema.DescribeSObjectResult d1 = Schema.SObjectType.Account;
        Map<String,Schema.RecordTypeInfo> rtMap1 = d1.getRecordTypeInfosByName();
        Schema.RecordTypeInfo uoprt =rtMap1.get('UOP Accounts');
		uopAccountId=uoprt.getRecordTypeId(); 
       
        ContactRecordType__c rectype = new ContactRecordType__c();
        rectype.Name='UOP_AccountRecordType';
        rectype.UOP_Account_RecordType__c=uopAccountId;
        insert rectype;
        
        Profile p=[select id from Profile where Name='UOP - Business'];
        UOP_Profiles__c up=new UOP_Profiles__c();
        up.Name='UOP Profile ID List';
        up.UOP_Business__c=p.id;
        insert up;
        
        sales_district__c sd=new sales_district__c();
        sd.Name='INDIA';
        insert sd;
        system.debug('*******sales district********'+sd);
        
        Uop_geo_region__c ur=new Uop_geo_region__c ();
        ur.Name='INDIAN SUBCONTINENT';
        insert ur;
        system.debug('*******Uop_geo_region__c********'+ur); 
        
        SAP_Customer_Info__c testcustomer = new SAP_Customer_Info__c();       
        testcustomer.Name='100462';
        testcustomer.UOP_Company_Name__c='AGIPPETROIL SPA';
        testcustomer.UOP_Geographic_Region__c='EUR';
        testcustomer.UOP_Sales_District__c=sd.id;
        testcustomer.UOP_Geo_Region__c=ur.id;
        testcustomer.UOP_Address1__c='DEVKARAN MANSION IIND FLR';
        testcustomer.UOP_Address2__c='79 PRINCESS STREET';
        testcustomer.UOP_City__c='Hyderabad';
        testcustomer.UOP_Honeywell_Geo_Region__c='India';
        testcustomer.UOP_Country__c='INDIA';
        insert testcustomer; 
        system.debug('*******testcustomer********'+testcustomer);     
        
         
        Country__c c=new Country__c();
        c.Name='INDIA';
        c.Region__c='India';
        insert c;
        
        Account acc=new Account();
        acc.Name='Test Name';
        //acc.UOP_Delta_Type__c='Agent';
        acc.RecordTypeId=uopAccountId;
        acc.Sales_District__c=sd.id; 
        acc.SAP_Customer_Info__c=testcustomer.id;                
        acc.BillingStreet ='sfdc';
        acc.BillingState ='sfdc';
        acc.BillingCountry ='INDIA';
        acc.BillingPostalCode='12221';
        insert acc;
		
        system.debug('Account.country'+acc.BillingCountry);

        acc= [Select OwnerID, Owner.ID From Account where ID = :acc.id];
        system.assertNOTEquals(null,acc.OwnerID);
        system.assertNOTEquals(null,acc.Owner.ID);
        
        Treating_Units__c TU = New Treating_Units__c ();
        TU.Account__c=acc.ID;
        TU.Unit_Reference_number__c='D-206';
        TU.Contaminants_Removed__c='H2O';
        TU.Carrier_Stream__c='Natural GAS';
        insert TU;
        
        Call_Meeting__c CM = New Call_Meeting__c ();
        CM.Company__c= acc.ID;
        CM.Due_Date__c = Datetime.newInstance(2016, 8, 16);
        CM.Meeting_Location__c='Teleconference';
        insert CM; 

        Test.startTest();
		
			ApexPages.currentPage().getParameters().put('tId',TU.id);
			callmeetings calm = new callmeetings();
			calm.selectedcm = CM.id;
			calm.selectThis();
        Test.stopTest();

    }
}

let u know is this will help you