function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Gerald HarmensGerald Harmens 

Adding a Test Class to a Trigger

I need to create a test class for an apex trigger in order to upload it from sandbox to production. I need help creating the test class as I am failry new at Salesforce development. Here is the apex trigger:

trigger Appointment_Closed on i360__Appointment__c (before insert) {
List<ID> ProspectIds = New List<ID>();
    
   for(i360__Appointment__c o : Trigger.new){
    if(o.i360__Result__c == 'Sold' | o.i360__Prospect__c != null){
      ProspectIds.add(o.i360__Prospect__c);
    }
  }
   List<i360__Prospect__c> ProspectList = [SELECT id, Appointment_Closed__c FROM i360__Prospect__c WHERE id in :ProspectIds];
  for(integer i = 0 ; i < ProspectList.size(); i++){
      ProspectList[i].Appointment_Closed__c = 1;
  
  }
  update ProspectList;
}
Ankit SehgalAnkit Sehgal
@isTest
public class testAppointment_Closed 
{
      static testMethod void test()
      {      
              //insert necessary records here like account or contact if i360__Appointment__c  has any lookup fields

              // Creating i360__Appointment__c object
              i360__Appointment__c testObj=new i360__Appointment__c (i360__Result__c ='Sold', Name= 'test');
              //inserting test object
              insert testObj;
             
      }
}

this wil just provide code coverage. In oder to test you need to insert i360__Prospect__c object and use system assert to test it
Gerald HarmensGerald Harmens
Thank you for the reply Ankit. I am new at this and do not understand you directions. What do you mean by "insert necessary records here" and "insert i360__Prospect__c object and use system assert to test it"?
J CesarJ Cesar
@isTest
public class Appointment_ClosedTEST{
@isTest
public static void TestAppointmentClosed(){
i360__Prospect__c prospect = new i360__Prospect__c();
insert prospect;
i360__Appointment__c appointment = new i360__Appointment__c(i360_Result__c='Sold');
appointment.i360__Prospect__c = prospect.Id;
test.startTest();
insert appointment;
​test.stopTest();
List<i360__Prospect__c> pList = [SELECT Id, Appointment_Closed__c FROM i360__Prospect__c WHERE Id =: prospect.Id];
System.asserEquals(1, pList.Appointment_Closed__c);
}
}

This should do the trick, you might have to add some fields to your custom object constructors if you have other mandatory fields on them.
Amit Chaudhary 8Amit Chaudhary 8
Hi ,
I did minor change in your Trigger code.
trigger Appointment_Closed on i360__Appointment__c (before insert) 
{
	Set<ID> ProspectIds = New Set<ID>();
    
	for(i360__Appointment__c o : Trigger.new)
	{
		if( o.i360__Result__c == 'Sold' || o.i360__Prospect__c != null)
		{
			ProspectIds.add(o.i360__Prospect__c);
		}
	}
	
	if(ProspectIds.size() > 0 )
	{
		List<i360__Prospect__c> ProspectList = [SELECT id, Appointment_Closed__c FROM i360__Prospect__c WHERE id in :ProspectIds];
		for(integer i = 0 ; i < ProspectList.size(); i++)
		{
			ProspectList[i].Appointment_Closed__c = 1;
		}
		update ProspectList;
	}
}

Please try below test class
@isTest
public class testAppointment_Closed 
{
    static testMethod void test()
    {      
			i360__Prospect__c prospect = new i360__Prospect__c();
			// Add all required field here
			//prospect.Name ='Test';
			insert prospect;
			
			test.startTest();
				
				i360__Appointment__c appointment = new i360__Appointment__c();
				// Add all required field here
				//appointment.Name ='Test';
				appointment.i360_Result__c='Sold'
				appointment.i360__Prospect__c = prospect.Id;
				insert appointment;
				
			test.stopTest();
			
			List<i360__Prospect__c> pList = [SELECT Id, Appointment_Closed__c FROM i360__Prospect__c WHERE Id =: prospect.Id];
			System.asserEquals(1, pList[0].Appointment_Closed__c);
	}
}

Please check below test classes to learn about test classes
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
Ankit SehgalAnkit Sehgal
Hi Gerald,
When we run a test class it is unable to access any records in the organisation, so we have to insert them manually.Some times there are validation rules or lookup fields on a object which are required to be filled then we need to fill them up also.

Suppose your object has a lookup field reffering the account object and is required to be filled in order to insert that object, in that case i have to insert an account object first which will generate an id for that and then pass Id of that object to my custom lookup field.
 
Account a=new Account(Name='test');
insert a;

//Assuming that there is an Account__c custom lookup field on i360__Appointment__c

i360__Appointment__c testObj=new i360__Appointment__c (Account__c=a.id);
insert testObj;

 
Gerald HarmensGerald Harmens
Thank you for all the help.

I'm getting this error: Error: Compile Error: Method does not exist or incorrect signature: System.asserEquals(Integer, Decimal) at line 23 column 13

For this line: System.asserEquals(1, pList[0].Appointment_Closed__c);
Amit Chaudhary 8Amit Chaudhary 8
Please try below code

System.asserEquals(1, Integer.valueOf( pList[0].Appointment_Closed__c ) );


 
Gerald HarmensGerald Harmens
Thank you. I'm still getting the same error. How would I know which fields are required and what value do I point them to?
J CesarJ Cesar
Hi Gerald,

I made a type in my code and everyone else on this thread has subsequently copied that typo:
System.assertEquals(1, pList[0].Appointment_Closed__c);
There was a missing 't' in assertEquals. While you're at it, check if you left the default 2 decimal places in Appointment_Closed__c and change the decimal places to 0.

Required fields are on 2 levels in Salesforce: page and object. If a field is only required on page then you're still able to save a record with that field blank in Apex. However, if a field is required on the object you won't be able to save the record (insert/update) if that field is left blank.
Name fields of text type and master-detail relationships are always required, and any custom fields you might have made required when creating them. In order to see which fields are required on an object you need to open field by field and check if Required checkbox is ticked.

I hope that resolves your issue.
Gerald HarmensGerald Harmens
I got the code below to save without errors but I get this error when I try to upload it to production.
One or more components failed Version Compatibility Check.
This change set contains components that require the "37.0" or higher platform version. Please select an organization with a platform version of "37.0" or higher, or remove all incompatible components.


@isTest
public class testAppointment_Closed 
{
    static testMethod void test()
    {      
            i360__Prospect__c prospect = new i360__Prospect__c();
            prospect.i360__Primary_Last_Name__c = '360 Test';
            prospect.i360__Primary_Email__c = 'test@gmail.com';
            insert prospect;
            
            test.startTest();
                
                i360__Appointment__c appointment = new i360__Appointment__c();
                appointment.Name ='Test';
                appointment.i360__Result__c ='Sold';
                appointment.i360__Prospect__c = prospect.Id;
                insert appointment;
                
            test.stopTest();
            
            List<i360__Prospect__c> pList = [SELECT Id, Appointment_Closed__c FROM i360__Prospect__c WHERE Id =: prospect.Id];
            System.assertEquals(1, pList[0].Appointment_Closed__c);
    }
}

 
Ankit SehgalAnkit Sehgal
Go to developer console and change the API version of class from 37 to 36.0.
Gerald HarmensGerald Harmens
Thank you that worked! I clicked Validate in production and chose Test Option 'Run specified tests' and I typed the name of the test class (Appointment_Closedtest). I'm not sure if I did this correctly but I get this message now.

testAppointment_ClosedtestSystem.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, The appointment must reference a valid Lead Source: [i360__Lead_Source__c] 
Stack Trace: Class.testAppointment_Closed.test: line 18, column 1