function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Gary Payne 9Gary Payne 9 

Need help with test on apex controller that lists Assets on a Case page

I need help to write tests for an apex controller that lists the Assets of the Account on a Case page layout with a VF page.  Following is my Apex Class:
public class DisplayAllAccountCases {

    public Account AccountInfo{get;set;}
    public DisplayAllAccountCases(ApexPages.StandardController controller) {
        string accountId=[select accountId from case where id=:Apexpages.currentpage
       ().getparameters().get('id')].accountId;
        AccountInfo=new Account(id=accountId);
    }
 }

What tests do I need to provide at least 75% code coverage?  I'm an Admin, not a developer and really need help to code this so it can be deployed to production.  Any help is certainly appreciated.
 
Best Answer chosen by Gary Payne 9
Amit Chaudhary 8Amit Chaudhary 8
Hi Gary Payne 9,

Please check below post to learn about test classes,
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please try below test class.
@isTest 
public class DisplayAllAccountCasesTest 
{
	static testMethod void testMethod1() 
	{
		Account testAccount = new Account();
			// add all required field here
			testAccount.Name='Test Account' ;
		insert testAccount;

		Case caseObj = new Case();
			// add all required field here
			caseObj.AccountId = testAccount.Id;
			caseObj.Status = 'Working';
			caseObj,Origin = 'Phone';
		Insert caseObj;
		
		Test.StartTest(); 
		

			PageReference pageRef = Page.AccountPlan; // Add your VF page Name here
			pageRef.getParameters().put('id', String.valueOf(caseObj.Id));
			Test.setCurrentPage(pageRef);

			ApexPages.StandardController sc = new ApexPages.StandardController(caseObj);
			DisplayAllAccountCases obj = new DisplayAllAccountCases(sc);

		Test.StopTest();
	}
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

All Answers

Anupama SamantroyAnupama Samantroy
Hi Gary,
Please find below a sample class. You can add all details in the test class.
 
@isTest
public class DisplayAllAccountCasesTest{
	@TestSetup
    static void setup(){
		//insert the account with all the required fields
		Account a = new account(Name='TestAccount');
		insert a;
		//insert few cases for that account with all required fields
		Case c1 = new Case(AccountId = a.Id);
		insert c1;
	}
	
	@isTest
	public static void testDisplayCases(){
		Case caseObj =[select id, accountId from Case LIMIT 1];
        
        PageReference pageRef = Page.Your_Page_Name;
        pageRef.getParameters().put('Id', String.valueOf(caseObj.Id));
        Test.setCurrentPage(pageRef);
        ApexPages.StandardController sc = new ApexPages.StandardController(caseObj);
        DisplayAllAccountCases   ctrl = new DisplayAllAccountCases(sc);	
        
	}
}

Hope this helps. Please get in touch if you need more help.

Thanks
Anupama
Amit Chaudhary 8Amit Chaudhary 8
Hi Gary Payne 9,

Please check below post to learn about test classes,
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please try below test class.
@isTest 
public class DisplayAllAccountCasesTest 
{
	static testMethod void testMethod1() 
	{
		Account testAccount = new Account();
			// add all required field here
			testAccount.Name='Test Account' ;
		insert testAccount;

		Case caseObj = new Case();
			// add all required field here
			caseObj.AccountId = testAccount.Id;
			caseObj.Status = 'Working';
			caseObj,Origin = 'Phone';
		Insert caseObj;
		
		Test.StartTest(); 
		

			PageReference pageRef = Page.AccountPlan; // Add your VF page Name here
			pageRef.getParameters().put('id', String.valueOf(caseObj.Id));
			Test.setCurrentPage(pageRef);

			ApexPages.StandardController sc = new ApexPages.StandardController(caseObj);
			DisplayAllAccountCases obj = new DisplayAllAccountCases(sc);

		Test.StopTest();
	}
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
This was selected as the best answer
Gary Payne 9Gary Payne 9
Thanks Anupama, this worked great for me. I tested to 100% code coverage with this test method. Following is my final Test code: @isTest public class DisplayAllAccountCasesTest { static testMethod void testMethod1() { Account testAccount = new Account(); // add all required fields here testAccount.Name='Test Account'; testAccount.RecordTypeId='01260000000YJr3'; testAccount.Account_Status__c='Prospect'; testAccount.Primary_Line_of_Business__c='Hospital'; testAccount.Market_Reporting__c='Post-Acute Care'; testAccount.Secondary_Line_of_Business__c='In Patient'; testAccount.Team__c='Acute'; insert testAccount; Case caseObj = new Case(); // add all required fields here caseObj.AccountId = testAccount.Id; caseObj.RecordTypeId='01260000000YJr6'; caseObj.Origin='Email'; caseObj.Source__c='Customer Request'; caseObj.Case_Reason__c='Value Not Recognized'; caseObj.Status='New'; Insert caseObj; Test.StartTest(); PageReference pageRef = Page.Case_Assets; // Add your VF page Name here pageRef.getParameters().put('id', String.valueOf(caseObj.Id)); Test.setCurrentPage(pageRef); ApexPages.StandardController sc = new ApexPages.StandardController(caseObj); DisplayAllAccountCases obj = new DisplayAllAccountCases(sc); Test.StopTest(); } } Regards, Gary Payne Salesforce Administrator ABILITY® One Metro Center
4010 Boy Scout Blvd. Suite 900
Tampa, FL 33607 P 813.580.5603 | C 714.474.5915 abilitynetwork.com
Amit Chaudhary 8Amit Chaudhary 8
Hi Gary,

Never use hard coded ID in test class. otherwised code will fail once you will deloy in production.
Please do minir change in your code like below
@isTest 
public class DisplayAllAccountCasesTest 
{ 
	static testMethod void testMethod1() 
	{ 
		Account testAccount = new Account(); 
		// add all required fields here 
		testAccount.Name='Test Account'; 
		testAccount.RecordTypeId= Schema.SObjectType.Account.getRecordTypeInfosByName().get('NameOfRecordType').getRecordTypeId(); // Add RecordType Name here
		testAccount.Account_Status__c='Prospect'; 
		testAccount.Primary_Line_of_Business__c='Hospital'; 
		testAccount.Market_Reporting__c='Post-Acute Care'; 
		testAccount.Secondary_Line_of_Business__c='In Patient'; 
		testAccount.Team__c='Acute'; 
		insert testAccount; 
		
		Case caseObj = new Case(); 
		// add all required fields here 
		caseObj.AccountId = testAccount.Id; 
		caseObj.RecordTypeId= Schema.SObjectType.Case.getRecordTypeInfosByName().get('NameOfRecordType').getRecordTypeId(); // Add RecordType Name here
		caseObj.Origin='Email'; 
		caseObj.Source__c='Customer Request'; 
		caseObj.Case_Reason__c='Value Not Recognized'; 
		caseObj.Status='New'; 
		Insert caseObj; 
		
			Test.StartTest(); 
				PageReference pageRef = Page.Case_Assets; // Add your VF page Name here 
				pageRef.getParameters().put('id', String.valueOf(caseObj.Id)); 
				Test.setCurrentPage(pageRef); 
				ApexPages.StandardController sc = new ApexPages.StandardController(caseObj); 
				DisplayAllAccountCases obj = new DisplayAllAccountCases(sc); 
			Test.StopTest(); 
	} 
}

Let us know if this will help you

NOTE: When adding code please use the "Add a code sample" button (icon <>) to increase readability and make it easier to reference.
 
Gary Payne 9Gary Payne 9
The following code is failing:
@isTest 
public class DisplayAllAccountCasesTest 
{
	static testMethod void testMethod1() 
	{
		Account testAccount = new Account();
			// add all required fields here
			testAccount.Name='Test Account';
        	testAccount.RecordTypeId= Schema.SObjectType.Account.getRecordTypeInfosByName().get
                ('Customer_Account').getRecordTypeId();



The Account record type label is "Customer Account", while the record type name is "Customer_Account".  The error code states: "Variable does not exist: testAccount.Name".  What needs to be changed for this to work?
Amit Chaudhary 8Amit Chaudhary 8
You Please check your org have any apex class with "Account" name.
Gary Payne 9Gary Payne 9
There are other Apex Classes that include the text string “Account” but they all have additional text, like AccountDAO, AccountService, etc. Gary Payne Salesforce Administrator ABILITY® One Metro Center
4010 Boy Scout Blvd. Suite 900
Tampa, FL 33607 P 813.580.5603 | C 714.474.5915 abilitynetwork.com