function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
Jaicen83Jaicen83 

Code Coverage for Custom Controller on visualforce page.

I have a custom controller that basically changes a Lookup Field to a picklist select showing all records that are related to the account the opportunity is on.

Basically I am giving sales the ability to have a list of multiple Ship-To's on accounts.

I am trying to right test coverage and seem to be hitting a wall when I just have to right test coverage that does not need to create new records and validate.

Here is the Controller that I wrote
public class OpportunityShipToSelectExtension {  
    private final ApexPages.standardController controller;  
    private final Opportunity obj; 
        

    public OpportunityShipToSelectExtension(ApexPages.StandardController stdController) {  
        this.controller = stdController;  
        this.obj = (opportunity)stdController.getRecord();
    }  
  
    public SelectOption[] getShipToOptions() {  
        SelectOption[] ShipTo = new SelectOption[]{};  
        ShipTo.add(new SelectOption('','--Default Shipping Address--'));  
        for (ERP_Address__c A : [select Id, Name , Address_Line_1__c, Address_Line_2__c, Address_City__c, Address_State__c FROM ERP_Address__c where Do_Not_Display_in_Search_Results__c = False AND Address_Type__c = 'Del' AND Bill_To__r.SFDC_Account__r.ID <> null AND Bill_To__r.SFDC_Account__r.ID = : obj.AccountID ORDER BY Address_Line_1__c ASC NULLS LAST ]) {  
            ShipTo.add(new SelectOption(A.id, A.name + ' (' + A.Address_Line_1__c + ', ' + A.Address_Line_2__c + ', ' + A.Address_City__c + ',' + A.Address_State__c + ')'));  
        }  
        return ShipTo;  
    }  
}

 
Best Answer chosen by Jaicen83
Amit Chaudhary 8Amit Chaudhary 8
Please check below post to learn about test classes
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please try below test class
@isTest 
public class OpportunityShipToSelectExtensionTest 
{
	static testMethod void testMethod1() 
	{
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;

		opportunity oppr = new opportunity();
		oppr.Name='testing' ;
		oppr.AccountId= testAccount.Id;
		oppr.StageName = 'Prospecting';
        oppr.CloseDate = closeDt;
		insert oppr;


		Test.StartTest(); 
			ApexPages.StandardController sc = new ApexPages.StandardController(oppr);
			OpportunityShipToSelectExtension obj = new OpportunityShipToSelectExtension(sc);
		
			List<SelectOption> lstSO = obj.getShipToOptions();
		Test.StopTest();
	}
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

All Answers

Amit Chaudhary 8Amit Chaudhary 8
Please check below post to learn about test classes
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please try below test class
@isTest 
public class OpportunityShipToSelectExtensionTest 
{
	static testMethod void testMethod1() 
	{
		Account testAccount = new Account();
		testAccount.Name='Test Account' ;
		insert testAccount;

		opportunity oppr = new opportunity();
		oppr.Name='testing' ;
		oppr.AccountId= testAccount.Id;
		oppr.StageName = 'Prospecting';
        oppr.CloseDate = closeDt;
		insert oppr;


		Test.StartTest(); 
			ApexPages.StandardController sc = new ApexPages.StandardController(oppr);
			OpportunityShipToSelectExtension obj = new OpportunityShipToSelectExtension(sc);
		
			List<SelectOption> lstSO = obj.getShipToOptions();
		Test.StopTest();
	}
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
This was selected as the best answer
Jaicen83Jaicen83
88% Code Coverage

I will take it thanks