I am attempting to peform a few things with the below trigger and I am getting errors on having too many SOQL queries. Essentially I need to bulkify this and am looking for advice on how to clean this up:
trigger AccountChildRollup on account (after delete, after update, after insert) {
set<id> accountids = new set<id>();
list<account> accounttoupdate = new list<account>();
list<account> childupdate = new list<account>();
integer childcount;
integer livechildcount;
string practiceid;
if (trigger.isinsert) {
for (account child : trigger.new)
if (child.parentid != null) {
accountids.add(child.parentid);
aggregateresult childacc = [select count(id) from account where parentid != null and parentid in :accountids];
childcount = integer.valueof(childacc.get('expr0'));
aggregateresult livechildacc = [select count(id) from account where type = 'Live' and parentid != null and parentid in :accountids];
livechildcount = integer.valueof(livechildacc.get('expr0'));
}
}
if (trigger.isupdate || trigger.isdelete) {
for (account child : trigger.old)
if (child.parentid != null) {
accountids.add(child.parentid);
aggregateresult childacc = [select count(id) from account where parentid != null and parentid in :accountids];
childcount = integer.valueof(childacc.get('expr0'));
aggregateresult livechildacc = [select count(id) from account where type = 'Live' and parentid != null and parentid in :accountids];
livechildcount = integer.valueof(livechildacc.get('expr0'));
}
}
if (childcount > 0) {
map<id,account> parentmap = new map<id,account>([select parentid, id, button_validate__c, count_child_accounts__c, validation_override1__c, validation_override__c from account where parentid = null and id in :accountids]);
for (account[] accpracticeid : [select id, practiceid__c from account where parentid in :accountids limit 1]){
practiceid = accpracticeid[0].practiceid__c;
}
if (!AccountChildRollupRecursiveHelper.hasalreadyupdated()) {
for (account a : [select id, validation_override__c, button_validate__c from account where parentid = null and id in :accountids]){
parentmap.get(a.id).count_child_accounts__c = childcount;
parentmap.get(a.id).count_live_child_accounts__c = livechildcount;
parentmap.get(a.id).validation_override__c = datetime.now();
parentmap.get(a.id).button_validate__c = datetime.now();
a.validation_override__c = datetime.now();
a.button_validate__c = datetime.now();
if (childcount > 0 && livechildcount < 1){
parentmap.get(a.id).this_is_a_parent_account__c = true;
} else {
if (livechildcount > 0){
aggregateresult golivedate = [select min(go_live_date__c), phreesia_server_version__c from account where type = 'Live' and go_live_date__c != null and parentid in :accountids group by phreesia_server_version__c limit 1];
date mingolivedate = date.valueof(golivedate.get('expr0'));
string server = string.valueof(golivedate.get('phreesia_server_version__c'));
parentmap.get(a.id).type = 'Live';
parentmap.get(a.id).go_live_date__c = mingolivedate;
parentmap.get(a.id).this_is_a_parent_account__c = true;
parentmap.get(a.id).phreesia_server_version__c = server;
}
}
childupdate.add(a);
accounttoupdate.add(parentmap.get(a.id));
}
AccountChildRollupRecursiveHelper.setalreadyupdated();
update childupdate;
update accounttoupdate;
}
}
}
I am trying to update a field (practiceid__c) on child accounts of a parent account when the parent is updated. Unfortunately I hit the governor limits because for some reason, the trigger iterates through all my accounts and not just the ones associated with my trigger. How do I confine the update to only the children of the account I am updating? Here is my simple trigger:
trigger wfpracticeid on account (after update) {
list<account> children = [select c.parent.practiceid__c, c.practiceid__c
from account c
where parentid in :trigger.new];
for (account child :children) {
child.practiceid__c = child.parent.practiceid__c;
}
update children;
}
I am geeting the following error on my trigger and cannot figure out why I am getting it. Can anyone help?
trigger wfcallupdate on Case (after insert) {
//Declare Variable
public set<id> caseid = new set<id>();
public set<id> oppid = new set<id>();
public list<opportunity> opptoupdate = [select id from opportunity where id in :oppid];
if(Trigger.isInsert){
for(case c: Trigger.new){
if(c.recordtype.name == 'Workflow')
oppid.add(c.opportunity__r.id);
caseid.add(c.id);
}
}
//Update Opportunity
if(oppid.size()>0){
for(opportunity o: [Select id, workflow_case__c from opportunity where id in :oppid])
opptoupdate.add(new opportunity(id=o.id, workflow_case__c=caseid));
}
update opptoupdate;
}
Error: Compile Error: Invalid initial expression type for field Opportunity.Workflow_Case__c, expecting: Id at line 18 column 63
For some reason, my Save on my Visualforce Page is no longer working with the release of Spring 2012. Below is my very simple class and page, but it has recently stopped working. Can anyone help?
Class
public class updateProductSales {
public updateProductSales(ApexPages.StandardSetController controller){
}
}
I am having trouble with the below class and am hoping to get some help. I have a Junction Object that is connecting two custom Objects, Order__c and Product_Bundle__c and I am creating a Visualforce Page that will allow the User to create the Junction Objects by adding Quantity to the records and saving the page. The class is designed to:
1. Query the Product_Bundle__c Custom Object for available Product Bundles and assocate them behind the scenes with the current Order__c
2. Display them on a VF page with the inputField Quantity__c exposed
3. If the User enters a quantity and clicks "Save", the system will create those Junction Objects associating the Product Bundles to the Order
I cannot seem to get my PageBlockTable to use the list in my Controller:
public class oitemController
{
public List<Product_Bundle__c> lstbundle = new List<Product_Bundle__c>();
public List<Order_Item_Junction__c> lstoitem = new List<Order_Item_Junction__c>();
public string orderid;
public boolean proceed {get;set;}
public boolean setproceed()
{
return true;
}
public oitemController(ApexPages.StandardController controller)
{
string flag = '';
//Order ID
orderid = ApexPages.currentPage().getparameters().get('oid');
//Record Type
string orecordtype = ApexPages.currentPage().getparameters().get('rectype');
//Use this variable to test the code coverage of try-catch block within constructor and set to 'true'
String calledFromTestClass = ApexPages.currentPage().getparameters().get('calledFromTestClass');
if(orecordtype == 'New Order')
{
flag = 'new';
//Fetch all Product Bundles where Order_Availability__c = New Order
lstbundle = [Select Order_Availability__c, Name, Id From Product_Bundle__c where Order_Availability__c =:'New Order' and Completed__c =: TRUE order by Name];
}
else if(orecordtype == 'Return Order')
{
flag = 'return';
//Fetch all Product Bundles where Order_Availability__c = Return Oder
lstbundle = [Select Order_Availability__c, Name, Id From Product_Bundle__c where Order_Availability__c =:'Return Order' and Completed__c =: TRUE order by Name];
}
List<Order_Item_Junction__c> lstoitem = new List<Order_Item_Junction__c>();
if(calledFromTestClass == 'true') {
lstoitem = null;
}
try{
for(integer i=0;i<lstbundle.size();i++)
{
Order_Item_Junction__c oitem = new Order_Item_Junction__c();
oitem.Product_Bundle__c = lstbundle[i].Id;
oitem.Order__c = orderid;
lstoitem.add(oitem);
}
}catch(Exception ex){
// Adding exeption message onto the page
ApexPages.addmessage(new ApexPages.message(ApexPages.severity.ERROR,'Error:'+ ex.getMessage()));
System.debug(ex.getMessage());
}
}
}
I am trying to create a Custom List Button where I would like to update a Custom Object (Asset__c) from the Related List of another Custom Object (Inventory_Request__c) that are joined by a Junction Object (Asset_Request_Junction__c). In a nutshell, I am on the Inventory Request Screen, I select my Asset Request Junction records, and want to update the Assets associated to theose Junction records. The error I am getting is saying that the Ids are not defined...can anyone help me with this one?
{!REQUIRESCRIPT("/soap/ajax/16.0/connection.js")}
var assetItems = {!GETRECORDIDS($ObjectType.Asset_Request_Junction__c)};
var SelectedIds='';
for(var i=0;i < assetItems.length; i++) {
SelectedIds+="'"+assetItems[i]+"',";
}
SelectedIds=SelectedIds.substring(0,SelectedIds.length - 1);
var updatedAssets = [];
if(assetItems.length<1) {
alert("Please choose at least one Asset to update.");
} else {
var r = confirm("Click ''OK'' to update Assets.");
if (r == true) {
try {
var aiQuery = "select Asset__r.Id from Asset_Request_Junction__c where Id in ("+SelectedIds+")";
var result = sforce.connection.query(aiQuery);
var records = result.getArray("records");
for (var n=0; n<records.length; n++) {
if (records[n].get("Asset_Status__c") != "Good Firefox") {
var a = new sforce.SObject("Asset__c");
a.id = records[n].id;
a.Asset_Status__c = "Good Firefox";
updatedAssets.push(a);
}
}
result = sforce.connection.update(updatedAssets);
window.location.reload();
if (result[0].getBoolean("success")) {
alert("Assets Updated");
} else {
alert("Failed to update Assets" + result[0]);
}
}
catch (e) {
alert(e);
}
}
}
I read in some other posts that this may be a bug, but I did not see resolution. Here is my code for my trigger and it works just fine in the Sandbox, but it does not work in production. Can anyone help with this?
trigger PhysicianUpdateAccountContactCount on Contact (after delete, after insert, after undelete,
after update) {
// Declare the variables
public set<Id> AccountIDs = new Set<Id>();
public list<Account> AccountToUpdate = new List<Account>();
// Build the list of Accounts to update
if(Trigger.isInsert || Trigger.isUnDelete || Trigger.isUpdate){
for(Contact c: Trigger.new){
if(c.role__c == 'Physician')
AccountIDs.add(c.accountid);
}
}
if(Trigger.isDelete || Trigger.isUpdate){
for(Contact c: Trigger.old){
if(c.role__c == 'Physician')
AccountIDs.add(c.accountid);
}
}
// Update the Accounts
if(AccountIDs.size()>0){
for(Account a: [Select a.Id, a.Calc_Physicians__c,
(Select Id From Contacts where Role__c = 'Physician')
From Account a where Id in :AccountIDs])
AccountToUpdate.add(new Account(Id=a.Id, Calc_Physicians__c = a.Contacts.size()));
}
update AccountToUpdate;
}
I am attempting to peform a few things with the below trigger and I am getting errors on having too many SOQL queries. Essentially I need to bulkify this and am looking for advice on how to clean this up:
trigger AccountChildRollup on account (after delete, after update, after insert) {
set<id> accountids = new set<id>();
list<account> accounttoupdate = new list<account>();
list<account> childupdate = new list<account>();
integer childcount;
integer livechildcount;
string practiceid;
if (trigger.isinsert) {
for (account child : trigger.new)
if (child.parentid != null) {
accountids.add(child.parentid);
aggregateresult childacc = [select count(id) from account where parentid != null and parentid in :accountids];
childcount = integer.valueof(childacc.get('expr0'));
aggregateresult livechildacc = [select count(id) from account where type = 'Live' and parentid != null and parentid in :accountids];
livechildcount = integer.valueof(livechildacc.get('expr0'));
}
}
if (trigger.isupdate || trigger.isdelete) {
for (account child : trigger.old)
if (child.parentid != null) {
accountids.add(child.parentid);
aggregateresult childacc = [select count(id) from account where parentid != null and parentid in :accountids];
childcount = integer.valueof(childacc.get('expr0'));
aggregateresult livechildacc = [select count(id) from account where type = 'Live' and parentid != null and parentid in :accountids];
livechildcount = integer.valueof(livechildacc.get('expr0'));
}
}
if (childcount > 0) {
map<id,account> parentmap = new map<id,account>([select parentid, id, button_validate__c, count_child_accounts__c, validation_override1__c, validation_override__c from account where parentid = null and id in :accountids]);
for (account[] accpracticeid : [select id, practiceid__c from account where parentid in :accountids limit 1]){
practiceid = accpracticeid[0].practiceid__c;
}
if (!AccountChildRollupRecursiveHelper.hasalreadyupdated()) {
for (account a : [select id, validation_override__c, button_validate__c from account where parentid = null and id in :accountids]){
parentmap.get(a.id).count_child_accounts__c = childcount;
parentmap.get(a.id).count_live_child_accounts__c = livechildcount;
parentmap.get(a.id).validation_override__c = datetime.now();
parentmap.get(a.id).button_validate__c = datetime.now();
a.validation_override__c = datetime.now();
a.button_validate__c = datetime.now();
if (childcount > 0 && livechildcount < 1){
parentmap.get(a.id).this_is_a_parent_account__c = true;
} else {
if (livechildcount > 0){
aggregateresult golivedate = [select min(go_live_date__c), phreesia_server_version__c from account where type = 'Live' and go_live_date__c != null and parentid in :accountids group by phreesia_server_version__c limit 1];
date mingolivedate = date.valueof(golivedate.get('expr0'));
string server = string.valueof(golivedate.get('phreesia_server_version__c'));
parentmap.get(a.id).type = 'Live';
parentmap.get(a.id).go_live_date__c = mingolivedate;
parentmap.get(a.id).this_is_a_parent_account__c = true;
parentmap.get(a.id).phreesia_server_version__c = server;
}
}
childupdate.add(a);
accounttoupdate.add(parentmap.get(a.id));
}
AccountChildRollupRecursiveHelper.setalreadyupdated();
update childupdate;
update accounttoupdate;
}
}
}
I am trying to update a field (practiceid__c) on child accounts of a parent account when the parent is updated. Unfortunately I hit the governor limits because for some reason, the trigger iterates through all my accounts and not just the ones associated with my trigger. How do I confine the update to only the children of the account I am updating? Here is my simple trigger:
trigger wfpracticeid on account (after update) {
list<account> children = [select c.parent.practiceid__c, c.practiceid__c
from account c
where parentid in :trigger.new];
for (account child :children) {
child.practiceid__c = child.parent.practiceid__c;
}
update children;
}
I am geeting the following error on my trigger and cannot figure out why I am getting it. Can anyone help?
trigger wfcallupdate on Case (after insert) {
//Declare Variable
public set<id> caseid = new set<id>();
public set<id> oppid = new set<id>();
public list<opportunity> opptoupdate = [select id from opportunity where id in :oppid];
if(Trigger.isInsert){
for(case c: Trigger.new){
if(c.recordtype.name == 'Workflow')
oppid.add(c.opportunity__r.id);
caseid.add(c.id);
}
}
//Update Opportunity
if(oppid.size()>0){
for(opportunity o: [Select id, workflow_case__c from opportunity where id in :oppid])
opptoupdate.add(new opportunity(id=o.id, workflow_case__c=caseid));
}
update opptoupdate;
}
Error: Compile Error: Invalid initial expression type for field Opportunity.Workflow_Case__c, expecting: Id at line 18 column 63
For some reason, my Save on my Visualforce Page is no longer working with the release of Spring 2012. Below is my very simple class and page, but it has recently stopped working. Can anyone help?
Class
public class updateProductSales {
public updateProductSales(ApexPages.StandardSetController controller){
}
}
I am having trouble with the below class and am hoping to get some help. I have a Junction Object that is connecting two custom Objects, Order__c and Product_Bundle__c and I am creating a Visualforce Page that will allow the User to create the Junction Objects by adding Quantity to the records and saving the page. The class is designed to:
1. Query the Product_Bundle__c Custom Object for available Product Bundles and assocate them behind the scenes with the current Order__c
2. Display them on a VF page with the inputField Quantity__c exposed
3. If the User enters a quantity and clicks "Save", the system will create those Junction Objects associating the Product Bundles to the Order
I cannot seem to get my PageBlockTable to use the list in my Controller:
public class oitemController
{
public List<Product_Bundle__c> lstbundle = new List<Product_Bundle__c>();
public List<Order_Item_Junction__c> lstoitem = new List<Order_Item_Junction__c>();
public string orderid;
public boolean proceed {get;set;}
public boolean setproceed()
{
return true;
}
public oitemController(ApexPages.StandardController controller)
{
string flag = '';
//Order ID
orderid = ApexPages.currentPage().getparameters().get('oid');
//Record Type
string orecordtype = ApexPages.currentPage().getparameters().get('rectype');
//Use this variable to test the code coverage of try-catch block within constructor and set to 'true'
String calledFromTestClass = ApexPages.currentPage().getparameters().get('calledFromTestClass');
if(orecordtype == 'New Order')
{
flag = 'new';
//Fetch all Product Bundles where Order_Availability__c = New Order
lstbundle = [Select Order_Availability__c, Name, Id From Product_Bundle__c where Order_Availability__c =:'New Order' and Completed__c =: TRUE order by Name];
}
else if(orecordtype == 'Return Order')
{
flag = 'return';
//Fetch all Product Bundles where Order_Availability__c = Return Oder
lstbundle = [Select Order_Availability__c, Name, Id From Product_Bundle__c where Order_Availability__c =:'Return Order' and Completed__c =: TRUE order by Name];
}
List<Order_Item_Junction__c> lstoitem = new List<Order_Item_Junction__c>();
if(calledFromTestClass == 'true') {
lstoitem = null;
}
try{
for(integer i=0;i<lstbundle.size();i++)
{
Order_Item_Junction__c oitem = new Order_Item_Junction__c();
oitem.Product_Bundle__c = lstbundle[i].Id;
oitem.Order__c = orderid;
lstoitem.add(oitem);
}
}catch(Exception ex){
// Adding exeption message onto the page
ApexPages.addmessage(new ApexPages.message(ApexPages.severity.ERROR,'Error:'+ ex.getMessage()));
System.debug(ex.getMessage());
}
}
}
I am trying to create a Custom List Button where I would like to update a Custom Object (Asset__c) from the Related List of another Custom Object (Inventory_Request__c) that are joined by a Junction Object (Asset_Request_Junction__c). In a nutshell, I am on the Inventory Request Screen, I select my Asset Request Junction records, and want to update the Assets associated to theose Junction records. The error I am getting is saying that the Ids are not defined...can anyone help me with this one?
{!REQUIRESCRIPT("/soap/ajax/16.0/connection.js")}
var assetItems = {!GETRECORDIDS($ObjectType.Asset_Request_Junction__c)};
var SelectedIds='';
for(var i=0;i < assetItems.length; i++) {
SelectedIds+="'"+assetItems[i]+"',";
}
SelectedIds=SelectedIds.substring(0,SelectedIds.length - 1);
var updatedAssets = [];
if(assetItems.length<1) {
alert("Please choose at least one Asset to update.");
} else {
var r = confirm("Click ''OK'' to update Assets.");
if (r == true) {
try {
var aiQuery = "select Asset__r.Id from Asset_Request_Junction__c where Id in ("+SelectedIds+")";
var result = sforce.connection.query(aiQuery);
var records = result.getArray("records");
for (var n=0; n<records.length; n++) {
if (records[n].get("Asset_Status__c") != "Good Firefox") {
var a = new sforce.SObject("Asset__c");
a.id = records[n].id;
a.Asset_Status__c = "Good Firefox";
updatedAssets.push(a);
}
}
result = sforce.connection.update(updatedAssets);
window.location.reload();
if (result[0].getBoolean("success")) {
alert("Assets Updated");
} else {
alert("Failed to update Assets" + result[0]);
}
}
catch (e) {
alert(e);
}
}
}
