Hi, could use some thoughts here.  Trying to get a trigger to populate a lookup field when an account record is created or updated.  I have a custom object, Sales_Grid_Assignment__c, for storing zipcodes and related data.  The intent of the trigger is to match the account's zipcode to a custom object record and populate the lookup field with the custom object record id.   Code works great in Sandbox.  In production, if the account record creation is by lead conversion, I get following error, but only if the user wants to create an opportunity upon conversion as well as a new company record.

Error: System.LimitException: Too many query rows: 50001 (System Code) Class.AssignSalesGrid.getGrid: line 6, column 1 Trigger.PrimaryAccountTrigger: line 4, column 1

I don't have anywhere near 50,000 custom object records, but I tried putting a LIMIT on the query anyway.  No joy.  Anyone see any glaring omissions or mistakes?  Thanks!

Here is the code for Trigger and Class...

TRIGGER:

trigger PrimaryAccountTrigger on Account (before insert, before update) {
    
 LIST<Account> company = Trigger.new;
 AssignSalesGrid.getGrid(company);

}

CLASS:

public class AssignSalesGrid {

    public static void getGrid(LIST<Account> company){
        
        List<Sales_Grid_Assignment__c> salesgrids = new List<Sales_Grid_Assignment__c>();
        salesgrids = [Select Id, Name
                from Sales_Grid_Assignment__c LIMIT 50000];
        
        Map <string,Id> mapGrids = new Map<string,Id>();
            for (Sales_Grid_Assignment__c sg: salesgrids)  {
          
                mapGrids.put(sg.Name,sg.Id);    
            }
    for (Account a :company){
            a.Sales_Grid_Assignment__c = mapGrids.get(a.BillingPostalCode);
        }
        
    }
}

Has anyone run into this?  I pass filter parameters via an annotated url to a report, and it works just fine for me, but if one of my users clicks the link with the same url, the parameter does not pass.  In fact, the filter that the parameter feeds disappears entirely from the report.

Any thoughts?

Hi All,

I'm not getting code coverage I need on this class.  Red lines aren't covered.  The test class is at the end of this post..

Any thoughts on how to cover these lines?  Thanks for any help!

UpdateMaxReviewDate (Code Covered: 69%)

Here's my Test Code

@isTest
private class UpdateMaxReviewDateTest {

public static testMethod void testReviewDates() {
        
        Date d = Date.today();
        
        //Create Test Account
        Account atest = new Account();
        atest.Name = 'New Test Account';
        atest.PM_Report_Review__c = d;
        Database.insert(atest);
        
        //Create Test imnaccount
        IMNAccount__c itest = new IMNAccount__c();
        itest.Name = 'New Test Imnaccount';
        Database.insert (itest);
        
        //Create Test Report Review
        List<Report_Review__c> rList = new List<Report_Review__c>();
        for (Integer i=0; i<21; i++){
            Report_Review__c rtest = new Report_Review__c();
            rtest.Review_Date__c = d-i;
            rList.add(rtest);
        }
        
        Database.insert(rList);    
        
        Test.startTest();
        
        //instantiate class to be tested and call method
        UpdateMaxReviewDate urd = new UpdateMaxReviewDate();
        urd.updReviews();
        
        
        //validate
        for (IMNAccount__c imn : [Select i.Last_Report_Review__c, i.Id,
                            i.Company__r.PM_Report_Review__c, i.PM_Report_Review_Date__c
                            From IMNAccount__c i]){
                            Date a = imn.Company__r.PM_Report_Review__c;
                            Date b = imn.PM_Report_Review_Date__c;
                            System.assertEquals(a,b);
                                
                            AggregateResult agr = [Select Max(Review_Date__c) rd From Report_Review__c
                                        WHERE imnaccount__c = :imn.Id];
                            Date c = (Date) agr.get('rd');
                            Date e = imn.Last_Report_Review__c;
                            System.assertEquals(c,e);   
           }
           Test.stopTest();
}
}

Hello All, new to apex coding and running into a production issue.  Scheduled class runs fine in sandbox, deployed successfully with 100% code coverage, but now the job isn't executing in production.  Scheduled with the Schedule Apex tool in UI just as in Sandbox.  The job shows up in Scheduled Jobs but nothing happens, no errors, nothing to see in Apex Jobs.  Anyone see anything wrong with the following...

 This is the scheduler

this is the class and method the scheduler should execute.  imnaccount is a custom object.

Hi, could use some thoughts here.  Trying to get a trigger to populate a lookup field when an account record is created or updated.  I have a custom object, Sales_Grid_Assignment__c, for storing zipcodes and related data.  The intent of the trigger is to match the account's zipcode to a custom object record and populate the lookup field with the custom object record id.   Code works great in Sandbox.  In production, if the account record creation is by lead conversion, I get following error, but only if the user wants to create an opportunity upon conversion as well as a new company record.

Error: System.LimitException: Too many query rows: 50001 (System Code) Class.AssignSalesGrid.getGrid: line 6, column 1 Trigger.PrimaryAccountTrigger: line 4, column 1

I don't have anywhere near 50,000 custom object records, but I tried putting a LIMIT on the query anyway.  No joy.  Anyone see any glaring omissions or mistakes?  Thanks!

Here is the code for Trigger and Class...

TRIGGER:

trigger PrimaryAccountTrigger on Account (before insert, before update) {
    
 LIST<Account> company = Trigger.new;
 AssignSalesGrid.getGrid(company);

}

CLASS:

public class AssignSalesGrid {

    public static void getGrid(LIST<Account> company){
        
        List<Sales_Grid_Assignment__c> salesgrids = new List<Sales_Grid_Assignment__c>();
        salesgrids = [Select Id, Name
                from Sales_Grid_Assignment__c LIMIT 50000];
        
        Map <string,Id> mapGrids = new Map<string,Id>();
            for (Sales_Grid_Assignment__c sg: salesgrids)  {
          
                mapGrids.put(sg.Name,sg.Id);    
            }
    for (Account a :company){
            a.Sales_Grid_Assignment__c = mapGrids.get(a.BillingPostalCode);
        }
        
    }
}

Has anyone run into this?  I pass filter parameters via an annotated url to a report, and it works just fine for me, but if one of my users clicks the link with the same url, the parameter does not pass.  In fact, the filter that the parameter feeds disappears entirely from the report.

Any thoughts?

Hi All,

I'm not getting code coverage I need on this class.  Red lines aren't covered.  The test class is at the end of this post..

Any thoughts on how to cover these lines?  Thanks for any help!

UpdateMaxReviewDate (Code Covered: 69%)

Here's my Test Code

@isTest
private class UpdateMaxReviewDateTest {

public static testMethod void testReviewDates() {
        
        Date d = Date.today();
        
        //Create Test Account
        Account atest = new Account();
        atest.Name = 'New Test Account';
        atest.PM_Report_Review__c = d;
        Database.insert(atest);
        
        //Create Test imnaccount
        IMNAccount__c itest = new IMNAccount__c();
        itest.Name = 'New Test Imnaccount';
        Database.insert (itest);
        
        //Create Test Report Review
        List<Report_Review__c> rList = new List<Report_Review__c>();
        for (Integer i=0; i<21; i++){
            Report_Review__c rtest = new Report_Review__c();
            rtest.Review_Date__c = d-i;
            rList.add(rtest);
        }
        
        Database.insert(rList);    
        
        Test.startTest();
        
        //instantiate class to be tested and call method
        UpdateMaxReviewDate urd = new UpdateMaxReviewDate();
        urd.updReviews();
        
        
        //validate
        for (IMNAccount__c imn : [Select i.Last_Report_Review__c, i.Id,
                            i.Company__r.PM_Report_Review__c, i.PM_Report_Review_Date__c
                            From IMNAccount__c i]){
                            Date a = imn.Company__r.PM_Report_Review__c;
                            Date b = imn.PM_Report_Review_Date__c;
                            System.assertEquals(a,b);
                                
                            AggregateResult agr = [Select Max(Review_Date__c) rd From Report_Review__c
                                        WHERE imnaccount__c = :imn.Id];
                            Date c = (Date) agr.get('rd');
                            Date e = imn.Last_Report_Review__c;
                            System.assertEquals(c,e);   
           }
           Test.stopTest();
}
}

Hello All, new to apex coding and running into a production issue.  Scheduled class runs fine in sandbox, deployed successfully with 100% code coverage, but now the job isn't executing in production.  Scheduled with the Schedule Apex tool in UI just as in Sandbox.  The job shows up in Scheduled Jobs but nothing happens, no errors, nothing to see in Apex Jobs.  Anyone see anything wrong with the following...

 This is the scheduler

this is the class and method the scheduler should execute.  imnaccount is a custom object.