I have the following Trigger: trigger SeekSerialNumberinCase on Case(before insert, before update) {
Map<String, Case> CaseMap = new Map<String, Case>(); for (Case Ca : System.Trigger.new) { // if ((Ca.Serial_Number__c != null) && // (Ca.Serial_Number__c != System.Trigger.oldMap.get(Ca.Id).Serial_Number__c)) { if (CaseMap.containsKey(Ca.Serial_Number__c)) { // Ca.Serial_Number__c.addError('Another Case has the ' + 'same Serial_Number__c.'); } else { CaseMap.put(Ca.Serial_Number__c, Ca); // } } } for (Case Ca : [SELECT Serial_Number__c FROM Case WHERE Serial_Number__c IN :CaseMap.KeySet()]) { Case newCase = CaseMap.get(Ca.Serial_Number__c); newCase.Rerepair__c = TRUE; // newCase.Serial_Number__c.addError('A Case with this Serial_Number__c ' + 'already exists.'); } }
Which seeks if a Serial number exists in cases. If yes , it assigns a pic sotred in the documents.
Which works fine and has passed 100 and works in production. But when it comes running batch using the apex data loader and the .xml, it reaches the governing limit of 100 giving the message:
«Definitely you are using one or more soql query in a loop and hence the number of query executed in one run time is crossing the governing limit of 100 query.......The alternative is to get the values in map beforehand and use map values instead of query in loop.......»
Any suggestions on how to skip the for and introduce a map?
Which is to update a picklist item in the child object when we change the same picklist in the parent.
This works fine and I do not see any Governance limitation.
I have built this test class:
@istest public class UpdateLocationStatusonLocationClass{ Private Static testmethod void TesttrgOnArticulo(){ Test.startTest(); Account ACC = new Account();
I am to Simulate an edit/save on parent object, which is a custom object, Cunsumer__c from its child, a Standard, Solutions.
The code I wrote is:
trigger AutoUpdateConsumer on Solution (after insert,after update) { List<Solution> S = [Select Solution.Consumer__c From Solution];
// String Sol = '0000000042'; id Sol = S[0].Consumer__c;
List<Consumer__c> Con = [Select Consumer__c.Name From Consumer__c where Consumer__c.Name =: Sol ];
Database.update(Con);
}
This works fine for Sol = '0000000042' (in comments) but not for a dynamic, the id which is valid when we edit the specific Solution record and everyone which has the same parent Cunsumer.
Although both Triggers got 100% coverage in the dev,, funny enough, in the prod it wil not validate since it requires as it says 100% coverage!!!
Trigger 1:
trigger CalculateTotalAmount on Consumer__c (before update) {
Integer i = 0;
Consumer__c parObj = Trigger.new[i];
// Current parent opportunity ID String intTest = Trigger.new[i].Id;
//Step 2. Create a list of opportunities who are children of this parent opportunity record. List<Solution> opp = [Select Solution.Id, Solution.Points__c From Solution where Solution.Consumer__c =: intTest];
Double j = 0; Double jj = 0;
// Loop through the filtered Consumers and sum up their amounts. for(Solution op : opp) { If ( op.Points__c != Null )
trigger CalculateTotalAmountAccount on Account (before update) {
Integer i = 0;
Account parObj = Trigger.new[i];
// Current parent opportunity ID String intTest = Trigger.new[i].Id;
//Step 2. Create a list of Consumer__c who are children of this parent opportunity record. List<Consumer__c> opp = [Select Consumer__c.Id, Consumer__c.Basket__c From Consumer__c where Consumer__c.Ophelia__c =: intTest];
Double j = 0;
// Loop through the filtered Consumers and sum up their amounts. for(Consumer__c op : opp) { If ( op.Basket__c != Null )
{ j += op.Basket__c; } } parObj.Basket__c = j;
Test Class:
@istest public class TesttrgOnArticulo{ Private Static testmethod void TesttrgOnArticulo(){ //Insert Participacion__c Record Consumer__c Con = new Consumer__c (); Con.Mobile__c = '1234'; Test.startTest(); insert Con;
//Insert Articulo__c Record for(Integer i = 0; i < 50; i++){ Solution Sol = new Solution(); Sol.SolutionName = 'Test'; Sol.Status= 'Reviewed'; Sol.PointConvertion__c = 'Προσθήκη Πόντων'; Sol.Total_Amount__c = 100; Sol.PointConvertion__c = '10'; Sol.Consumer__c = Con.id; Sol.Points__c = 0; Sol.Points__c = Sol.Points__c +1; insert Sol; update Sol; }
Con.Mobile__c = '5678'; update Con;
//Insert Participacion__c Record Account Acc = new Account(); Acc.Name= 'TEST'; insert Acc ;
1 for a custom object which sums points from the Standard Soltution to a custom object:
--------------------------
trigger CalculateTotalAmount on Consumer__c (before update) {
Integer i = 0;
Consumer__c parObj = Trigger.new[i];
// Current parent opportunity ID String intTest = Trigger.new[i].Id;
//Step 2. Create a list of opportunities who are children of this parent opportunity record. List<Solution> opp = [Select Solution.Id, Solution.Points__c From Solution where Solution.Consumer__c =: intTest];
Double j = 0; Double jj = 0;
// Loop through the filtered Consumers and sum up their amounts. for(Solution op : opp) { If ( op.Points__c != Null )
2nd Trigger , Similar, this time standard is the Accounts:
trigger CalculateTotalAmountAccount on Account (before update) {
Integer i = 0;
Account parObj = Trigger.new[i];
// Current parent opportunity ID String intTest = Trigger.new[i].Id;
//Step 2. Create a list of Consumer__c who are children of this parent opportunity record. List<Consumer__c> opp = [Select Consumer__c.Id, Consumer__c.Basket__c From Consumer__c where Consumer__c.Ophelia__c =: intTest];
Double j = 0;
// Loop through the filtered Consumers and sum up their amounts. for(Consumer__c op : opp) { If ( op.Basket__c != Null )
{ j += op.Basket__c; } } parObj.Basket__c = j;
}
------------------------------
Both Triggers work fine.
I have written the following Test Class for both which only gets 66%:
@istest public class TesttrgOnArticulo{ Private Static testmethod void TesttrgOnArticulo(){
//Insert Participacion__c Record Consumer__c Con = new Consumer__c (); Con.Mobile__c = '1234'; Test.startTest(); insert Con;
Con.Mobile__c = '5678'; update Con;
//Insert Articulo__c Record for(Integer i = 0; i < 50; i++){
I am to Simulate an edit/save on parent object, which is a custom object, Cunsumer__c from its child, a Standard, Solutions.
The code I wrote is:
trigger AutoUpdateConsumer on Solution (after insert,after update) { List<Solution> S = [Select Solution.Consumer__c From Solution];
// String Sol = '0000000042'; id Sol = S[0].Consumer__c;
List<Consumer__c> Con = [Select Consumer__c.Name From Consumer__c where Consumer__c.Name =: Sol ];
Database.update(Con);
}
This works fine for Sol = '0000000042' (in comments) but not for a dynamic, the id which is valid when we edit the specific Solution record and everyone which has the same parent Cunsumer.
1 for a custom object which sums points from the Standard Soltution to a custom object:
--------------------------
trigger CalculateTotalAmount on Consumer__c (before update) {
Integer i = 0;
Consumer__c parObj = Trigger.new[i];
// Current parent opportunity ID String intTest = Trigger.new[i].Id;
//Step 2. Create a list of opportunities who are children of this parent opportunity record. List<Solution> opp = [Select Solution.Id, Solution.Points__c From Solution where Solution.Consumer__c =: intTest];
Double j = 0; Double jj = 0;
// Loop through the filtered Consumers and sum up their amounts. for(Solution op : opp) { If ( op.Points__c != Null )
2nd Trigger , Similar, this time standard is the Accounts:
trigger CalculateTotalAmountAccount on Account (before update) {
Integer i = 0;
Account parObj = Trigger.new[i];
// Current parent opportunity ID String intTest = Trigger.new[i].Id;
//Step 2. Create a list of Consumer__c who are children of this parent opportunity record. List<Consumer__c> opp = [Select Consumer__c.Id, Consumer__c.Basket__c From Consumer__c where Consumer__c.Ophelia__c =: intTest];
Double j = 0;
// Loop through the filtered Consumers and sum up their amounts. for(Consumer__c op : opp) { If ( op.Basket__c != Null )
{ j += op.Basket__c; } } parObj.Basket__c = j;
}
------------------------------
Both Triggers work fine.
I have written the following Test Class for both which only gets 66%:
@istest public class TesttrgOnArticulo{ Private Static testmethod void TesttrgOnArticulo(){
//Insert Participacion__c Record Consumer__c Con = new Consumer__c (); Con.Mobile__c = '1234'; Test.startTest(); insert Con;
Con.Mobile__c = '5678'; update Con;
//Insert Articulo__c Record for(Integer i = 0; i < 50; i++){
