Hi,

I am getting a apex heap size error in my batch apex class. - System.LimitException: Apex heap size too large: 6030143.

The records that needs to be processed are in the range of 10k to 50K. I think it is because of the map that I am using in my code.

 This is how my code looks like

global class CreatePortfolioReport implements Database.Batchable<sObject>, Database.Stateful{
	public String query;
	global String email;

	Map<String, Purchase_Sales_Report__c[]> purchaseMap = new Map<String, Purchase_Sales_Report__c[]>();
	Map<String, Purchase_Sales_Report__c[]> salesMap = new Map<String, Purchase_Sales_Report__c[]>();
	
	
	global Database.QueryLocator start(Database.BatchableContext BC){
        return Database.getQueryLocator(query);
    }
    
    global void execute(Database.BatchableContext BC, List<sObject> scope){
    	 for(sObject s: scope){
    	 	Purchase_Sales_Report__c ps = (Purchase_Sales_Report__c)s;
    	 	if(ps.Transaction__c != null){
	    	 	if(ps.Transaction__c.equals('Purchase')){
		    	 	if(!purchaseMap.isEmpty() && purchaseMap.containsKey(ps.Unique_Name__c)){
		    	 		purchaseMap.get(ps.Unique_Name__c).add(ps);
		    	 	}
		    	 	else{
		    	 		List<Purchase_Sales_Report__c> newList = new List<Purchase_Sales_Report__c>();
		    	 		newList.add(ps);
		    	 		purchaseMap.put(ps.Unique_Name__c, newList);
		    	 	}
	    	   }
	    	   else if(ps.Transaction__c.equals('Sales')){
	    	   		if(!salesMap.isEmpty() && salesMap.containsKey(ps.Unique_Name__c)){
		    	 		salesMap.get(ps.Unique_Name__c).add(ps);
		    	 	}
		    	 	else{
		    	 		List<Purchase_Sales_Report__c> newList = new List<Purchase_Sales_Report__c>();
		    	 		newList.add(ps);
		    	 		salesMap.put(ps.Unique_Name__c, newList);
		    	 	}
	    	   }
    	 	}
    	 } 
    	 System.debug('Purchase Map size'+purchaseMap.size());
    	 System.debug('Sales Map size'+salesMap.size());
    }
    
    global void finish(Database.BatchableContext BC){
    	Map<String, Double> salesUnits = new Map<String, Double>();
    	Map<String, Double> purchaseUnits = new Map<String, Double>();
    	Map<String, Portfolio_Report__c> portfolioMap = new Map<String, Portfolio_Report__c>();
    	List<Temp_Purchase_Report__c> purchaseList = new List<Temp_Purchase_Report__c>();
    	for(String uniqueName: salesMap.keySet()){
  			Double units = 0;
  			Double purchaseAmount = 0;
  			for(Purchase_Sales_Report__c ps:salesMap.get(uniqueName)){
  				
  				if(ps.Units__c != null){
  					units += ps.Units__c;
  				}
  			}
  			salesUnits.put(uniqueName, units);
  		}
  		System.debug('Sales Map'+salesMap.size());
  		for(String uniqueName: purchaseMap.keySet()){
  			
  	        Double units;
  			if(salesUnits.containsKey(uniqueName)){
  				units = Math.abs(salesUnits.get(uniqueName));
  			}
  			Double pUnits = 0;
  			Double product = 0;
  			Double portUnits = 0;
  			Double portAmount = 0;
  			Double divReinvAmount = 0;
  			Double divAmount = 0;
  			Double stpAmount = 0;
  			Boolean entityFlag = true;
  			Id entity;
  			String folio;
  			String assetClass;
  			String schemeName;
  			for(Purchase_Sales_Report__c ps:purchaseMap.get(uniqueName)){
  				
  				if(units != null && pUnits != units){
  					if(ps.Units__c != null){
  						pUnits += ps.Units__c;
  					}
  					
  				}
  				else{
  					
  					if(ps.Units__c != null){
  						portUnits += ps.Units__c;
  					}
  					if(ps.Amount__c != null && ps.Type__c != null){
  						
  						if(ps.Type__c.equalsIgnoreCase('NOR') || ps.Type__c.equalsIgnoreCase('SIP')){
  							portAmount += ps.Amount__c;
  						}
  						else if(ps.Type__c.equalsIgnoreCase('DIR')){
  							divReinvAmount += ps.Amount__c;
  						}
  						else if(ps.Type__c.equalsIgnoreCase('STI') || ps.Type__c.equalsIgnoreCase('SWI')){
  							stpAmount += ps.Amount__c;
  						}
  						else if(ps.Type__c.equalsIgnoreCase('DVP')){
  							divAmount += ps.Amount__c;
  						}
  					}
  					if(ps.Product__c != null){
  						product += ps.Product__c;
  					}
  					if(entityFlag){
	  					entity = ps.Entity__c;
	  					folio = ps.Folio_Number__c;
	  					assetClass = ps.Asset_Class__c;
	  					entityFlag = false;
	  					schemeName = ps.Scheme_Name__c;
  					}
  					System.debug('Create Port Units'+portUnits+'Amount'+portAmount+'Product'+product);
  				}
  				
  			}
  			if(portUnits != 0 && product != 0 && (portAmount != 0 || divAmount !=0 || divReinvAmount !=0 || divAmount != 0) ){
  				Temp_Purchase_Report__c pr = new Temp_Purchase_Report__c(Entity__c= entity, 
  																		 Folio_Number__c = folio, 
  																		 Asset_Class__c = assetClass,
  																		 UniqueName__c = uniqueName, 
  																		 Purchase_Amount__c= portAmount, 
  																		 Units_Quanitity__c = portUnits, 
  																		 Product__c = product,
  																		 Dividend_Reinvested__c = divReinvAmount,
  																		 Dividend__c = divAmount,
  																		 STP_Switch__c = stpAmount,
  																		 Scheme_Scrip_Name__c = schemeName);
  				purchaseList.add(pr);
  			}
  		}
  		System.debug('Purchase List'+purchaseList.size());
  		
  		upsert purchaseList UniqueName__c;
  		  		
  		AsyncApexJob a = [Select Id, 
                                 Status,
                                 NumberOfErrors, 
                                 JobItemsProcessed,  
                                 TotalJobItems, 
                                 CreatedBy.Email 
                                 from AsyncApexJob 
                                 where Id =:BC.getJobId()];
        // Create and send an email with the results of the batch.
        Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
        mail.setToAddresses(new String[] {email});
        mail.setReplyTo('');
        mail.setSenderDisplayName('Batch Processing');  
        mail.setSubject('Create Portfolio Report ' + a.Status);
        mail.setPlainTextBody('The batch apex job processed ' + a.TotalJobItems +   ' batches with ' + a.NumberofErrors + ' failures.');
    
        Messaging.sendEmail(new Messaging.SingleEmailMessage[] { mail });
  		
    }
}

 As I require the map for processing the data in my finish method, I cannot think of any other option to implement it.

Can you please suggest me ways to avoid the error?

Thanks,

Jina

Hi ,

I have written a batch apex to create/update  custom object records. I have two custom objects Purchase_Sales_Report__c and Portfolio_Report__c. Portfolio_Report__c is basically a summary of Purchase_Sales_Report__c records based on a Unique Key. They are both child of the Account object.

Every day I get a feed of Purchase_Sales_Report__c objects and based on those records I either need to create a new Portfolio_Report__c record or update the existing record based on a Unique key.

In the Database.queryLocator I send all the Purchase_Sales_Report__c records but inorder to update the existing Portfolio_Report__c report, I also require a list of all the existing Portfolio_Report__c records where I face an issue of 'Too many query rows 100001' as the number of records returned is more than 10 k.

here is my piece of code. The one in red is where I get an error,

global class CreateSummaryReport implements Database.Batchable<sObject>, Database.Stateful {
    global String query; 
    global Map<String, Portfolio_Report__c>  existingPortMap = new Map<String, Portfolio_Report__c>();
    global Map<String, Double> purchaseAmountMap = new Map<String, Double>();
    global Map<String, Double> productMap = new Map<String, Double>();
    global Map<String, Double> unitsMap = new Map<String, Double>();
    global Map<String, Purchase_Sales_Report__c> otherDetailsMap = new Map<String, Purchase_Sales_Report__c>();
    global String email;
    
    global CreateSummaryReport(){
        for(Portfolio_Report__c por: [Select Gain__c, 
                                            Units_Quanitity__c,
                                            Scheme_Scrip_Name__c, 
                                            Purchase_Amount__c, 
                                            Portfolio_Type__c, 
                                            Folio_Number__c, 
                                            Current_Value__c,
                                            Absolute_Ret__c,
                                            Annualized_Ret__c, 
                                            UniqueName__c,
                                            Dividend_Reivestment__c,
                                            Transaction_Type__c,
                                            Nav_p__c
                                            From Portfolio_Report__c] ){
            existingPortMap.put(por.UniqueName__c, por);
            
        }
        //email = email;
    }
    global Database.QueryLocator start(Database.BatchableContext BC){
        return Database.getQueryLocator(query);
    }
    
    global void execute(Database.BatchableContext BC, List<sObject> scope){
       
        for(sObject s: scope){
            Purchase_Sales_Report__c ps = (Purchase_Sales_Report__c)s;
            if(purchaseAmountMap.containsKey(ps.Unique_Name__c)){
            	if(ps.Amount__c != null){
	        		Double d = ps.Amount__c + purchaseAmountMap.get(ps.Unique_Name__c);
	                purchaseAmountMap.put(ps.Unique_Name__c, d);
            	}
            	                
            }
            else {
                   if(ps.Amount__c == null)
                   {
                   		ps.Amount__c = 0;
                   }
                purchaseAmountMap.put(ps.Unique_Name__c, ps.Amount__c);
            }
            if(productMap.containsKey(ps.Unique_Name__c)){
            	if(ps.Product__c != null) {
	                Double d = ps.Product__c + productMap.get(ps.Unique_Name__c);
	                productMap.put(ps.Unique_Name__c, d);
            	}
                
            }
            else {
                  if(ps.Product__c == null)
                  {
                  	ps.Product__c = 0;
                  }
                productMap.put(ps.Unique_Name__c, ps.Product__c);
            }
            if(unitsMap.containsKey(ps.Unique_Name__c)){
            	if(ps.Units__c != null){
	                Double d = ps.Units__c + unitsMap.get(ps.Unique_Name__c);
	                unitsMap.put(ps.Unique_Name__c, d);
            	}
                
            }
            else {
                  if(ps.Units__c == null)
                  {
                  	ps.Units__c = 0;
                  }
                unitsMap.put(ps.Unique_Name__c, ps.Units__c);
            }
            if(!otherDetailsMap.containsKey(ps.Unique_Name__c)){
                otherDetailsMap.put(ps.Unique_Name__c, ps);
            }
        }
        
    }
    global void finish(Database.BatchableContext BC){
        List<Portfolio_Report__c> updateList = new List<Portfolio_Report__c>();
        List<Portfolio_Report__c> newList = new List<Portfolio_Report__c>();
        
        for(String s: purchaseAmountMap.keySet()){
            if(existingPortMap.containsKey(s)){
                Portfolio_Report__c pr = existingPortMap.get(s);
                pr.Purchase_Amount__c = purchaseAmountMap.get(s);
                pr.Product__c = productMap.get(s);
                pr.Units_Quanitity__c = unitsMap.get(s);
                updateList.add(pr);
            }
            else {
                Portfolio_Report__c pr = new Portfolio_Report__c(UniqueName__c=s, 
                                                                 Scheme_Scrip_Name__c=otherDetailsMap.get(s).Scheme_Name__c,
                                                                 Folio_Number__c = otherDetailsMap.get(s).Folio_Number__c,
                                                                 Entity__c = otherDetailsMap.get(s).Entity__c,
                                                                 Product__c = productMap.get(s),
                                                                 Units_Quanitity__c = unitsMap.get(s),
                                                                 Purchase_Amount__c = purchaseAmountMap.get(s));
                newList.add(pr);
            }
        }
        
        insert newList;
        update updateList;
        
        AsyncApexJob a = [Select Id, 
                                 Status,
                                 NumberOfErrors, 
                                 JobItemsProcessed,  
                                 TotalJobItems, 
                                 CreatedBy.Email 
                                 from AsyncApexJob 
                                 where Id =:BC.getJobId()];
        // Create and send an email with the results of the batch.
        Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
        mail.setToAddresses(new String[] {email});
        mail.setReplyTo('tech@ffreedom.in');
        mail.setSenderDisplayName('Batch Processing');  
        mail.setSubject('Detailed Portfolio Report Update ' + a.Status);
        mail.setPlainTextBody('The batch apex job processed ' + a.TotalJobItems +   ' batches with ' + a.NumberofErrors + ' failures.');
    
        Messaging.sendEmail(new Messaging.SingleEmailMessage[] { mail });
    }
}

Can someone please give me a workaround for this?

Many Thanks,

Jina

Hi,

I would like to introduce the Ideas tab in our website which is built in Force.com sites but would like to change the look and feel of the Ideas Home page. To give an example, we would like to do something similar to what Star Bucks had done, giving it our own theme.

While going thru the internet, I found this presentation https://docs.google.com/present/view?id=agqxwgjz4qr3_621fpt7gzff but I could find any 'Ideas Base Theme' in Appexchange. Later came to know that it was just a pilot pahse.

Can someone please guide me with the steps on how to do that? Is it completely Visualforce where in all the backend functionality like posting idea, voting count is done thru a custom controller? Are there any APIs available which will ease the customization process?

Many Thanks,

Jina

Hi,

I am getting 'Too many script statements: 50001' exception in my trigger when I do a mass insert. I have not put any DML statements inside any for loop but still I am getting the error.

I have a object named Goal and the trigger is on insert. I need to insert all junction object records associated with the Goal object whenever any Goal record is inserted. There are 3 junction objects associated with the Goal - Insurance/Asset/PortfolioReport.

Here is the piece of code

trigger CreateGoalAssociations on Goal__c (after insert) {
	List<GoalAssetAssociation__c> assetList = new List<GoalAssetAssociation__c>();
	List<GoalInsuranceAssociation__c> insuranceList = new List<GoalInsuranceAssociation__c>();
	List<GoalIAULIPAssociation__c> pReport = new List<GoalIAULIPAssociation__c>();
	Map<Id, Id> entityIds = new Map<Id, Id>();
	Double d= 0;
	Map<Id, Id> goalAccountMap = new Map<Id, Id>();
	List<Goal__c> goalList = new List<Goal__c>();
	
	for(Goal__c g:Trigger.new){
		goalAccountMap.put(g.Id, g.Entity__c);
		goalList.add(g);
	}
    for(Account a: [select Id,Parent_Entity__c from Account where Parent_Entity__c IN :goalAccountMap.values()]){
		entityIds.put(a.Id, a.Id);
	}
    for(Asset__c a: [select Id, Asset_Type__c from Asset__c where Entity__c IN :goalAccountMap.values()
    					OR Entity__c IN :entityIds.keySet()]){
    	
    	for(Goal__c g: goalList){
    		GoalAssetAssociation__c gA = new GoalAssetAssociation__c(Goal__c = g.Id, Asset__c = a.Id, Allocation__c = d);
    		assetList.add(gA);
    	}
    }
    
    for(Insurance__c i: [select Id, Policy_Number_or_Name__c from Insurance__c where Entity__c IN :goalAccountMap.values()
    						OR Entity__c IN :entityIds.keySet()]){
    	for(Goal__c g:goalList){
    		GoalInsuranceAssociation__c gI = new GoalInsuranceAssociation__c(Goal__c = g.Id, Insurance__c = i.Id, Allocation__c = d);
    		insuranceList.add(gI);
    	}
    	
    }
    
    for(Portfolio_Report__c p: [select Id, Portfolio_Type__c  from Portfolio_Report__c where Entity__c IN :goalAccountMap.values()
    							OR Entity__c IN :entityIds.keySet()]){
    	for(Goal__c g:goalList){
    		GoalIAULIPAssociation__c gP = new GoalIAULIPAssociation__c(Goal__c = g.Id, Portfolio_Report__c = p.Id, Allocation__c = d);
    		pReport.add(gP);
    	}
    }
     insert assetList;
     insert insuranceList;
     insert pReport;
     
}

Is there any way I can modify the code to avoid the errors. I have highligted the places where I am getting the error.

Any help on this will be very much appreciated.

Many Thanks,

Jina

Hi,

I have to prepare two financial reports on nightly basis based on the every day feed that I get into salesforce. Here are the details -

1. There are two objects in salesforce Purchase Report and Portfolio Report and they are linked to the Account object. Account is the master for the two objects

2. Every day I get a feed of the Purchase Report which details out the money invested, date etc. Each record here requires some net gain % calculation which I am currently handling it thru a batch process.

3. Now based on the Purchase Report, I have to prepare  the Portfolio Report records which is the summary of the Purchse Report records..

  For e.g. - Account A has 100 records in the Purchase Report,out which there are 10 unique products..i.e. 10 records each for each product.

  So my summary report should generate 10 records, summing the total amount spent for 10 records and then other calculations like net gain % etc. Also, if there is already a record for the products in Portfolio Report object, it should just update the record instead of creating a new record. This will be something like the mutual find summary report and this update should run on nightly basis.

4. The daily feed that I would get may have around 50 K records.

I am confused on what approach should I take. If I use batch process, one batch will contain only 200 records and that might not include all the records for each product. I can store the summation on a stateful class variable but then how do I handle the after processing of data.

Should I do all my post calculations of calculating gain based on the summation in the 'finsh' method and upsert the records there? Is this a good a approach or there is some other way of doing it?

Many Thanks,

Jina

Hi,

I want to override the Convert Lead Button inorder to do a Javascript validation. I want the user to go ahead with Convert only if the Status is 'Closed -Converted'.

I have written an S-Control to do so, the check works fine but when the page is redirected to the leadConvert.jsp it goes into infinite loop.

Here is the code -

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <html> <head> <script type="text/javascript" src="/js/functions.js"></script> <script src="/soap/ajax/11.1/connection.js"></script> <script> function pageInit() { var leadStatus= "{!Lead.Status}"; if(leadStatus== 'Closed - Converted') { this.parent.frames.location.replace("/lead/leadconvert.jsp?retURL={!Lead.Id}&id={!Lead.Id}"); } else { alert('Error Message'); this.parent.frames.location.replace("/{!Lead.Id}"); } } pageInit(); </script> </html>

Can someone please help me in solving this?

Thanks,

Jina

Hi,

I have trigger on a custom object CPP__c on update where I am creating history records for that object if any desired value changes in the updated record. I am not using nay new id while inserting but still I get this error

Update_CPP_change_history: execution of AfterUpdate

caused by: System.DmlException: Insert failed. First exception on row 0 with id a04R000000141WOIAY; first error: INVALID_FIELD_FOR_INSERT_UPDATE, cannot specify Id in an insert call: [Id]

The trigger works fine on a single update, it only fails when I try to do a mass update through Apex Data Loader by matching the lookup fields on the CPP__c object.

Can someone please help me in solving this issue? I have inserting the code snippet below

trigger Update_CPP_change_history on CPP__c (before delete, after insert, after update) { List<CPP_Change_History__c> CPPs = new List<CPP_Change_History__c>{}; if (Trigger.isInsert) { for (CPP__c a : Trigger.new) { CPP_Change_History__c ch = new CPP_Change_History__c( Account_Name__c = a.Account__c, CPP__c = a.id, Business_Lost_Reason_New__c = a.Business_Lost_Reason__c, Business_Under_Threat_Reason_New__c = a.Business_Under_Threat_Reason__c, Business_Won_Reason_New__c = a.Business_Won_Reason__c, Change_Date__c = System.today(), Price_New__c = a.per_UOM__c, Status_New__c = a.Current_Status__c, Supplier_New__c = a.Supplier_Name__c, Producer_New__c = a.Producer_Name__c, Volume_New__c = a.Annual_KGs__c ); CPPs.add(ch); } insert CPPs; } else if (Trigger.isUpdate) { for (Integer i = 0; i < Trigger.new.size(); i++) { if ((Trigger.old[i].Supplier_Name__c != Trigger.new[i].Supplier_Name__c)|| (Trigger.old[i].Producer_Name__c != Trigger.new[i].Producer_Name__c) || (Trigger.old[i].Business_Lost_Reason__c != Trigger.new[i].Business_Lost_Reason__c) || (Trigger.old[i].Business_Under_Threat_Reason__c != Trigger.new[i].Business_Under_Threat_Reason__c)|| (Trigger.old[i].Business_Won_Reason__c != Trigger.new[i].Business_Won_Reason__c) || (Trigger.old[i].per_UOM__c != Trigger.new[i].per_UOM__c) || (Trigger.old[i].Current_Status__c != Trigger.new[i].Current_Status__c)|| (Trigger.old[i].Annual_KGs__c != Trigger.new[i].Annual_KGs__c) ) { //Creat CPP History only if certain fields change CPP_Change_History__c ch = new CPP_Change_History__c( CPP__c = Trigger.new[i].id, Change_Date__c = System.today(), Account_Name__c = Trigger.new[i].Account__c); if(Trigger.old[i].Supplier_Name__c != Trigger.new[i].Supplier_Name__c){ ch.Supplier_New__c = Trigger.new[i].Supplier_Name__c; ch.Supplier_Old__c = Trigger.old[i].Supplier_Name__c; } if(Trigger.old[i].Producer_Name__c != Trigger.new[i].Producer_Name__c){ ch.Producer_New__c = Trigger.new[i].Producer_Name__c; ch.Producer_Old__c = Trigger.old[i].Producer_Name__c; } if(Trigger.old[i].Business_Lost_Reason__c != Trigger.new[i].Business_Lost_Reason__c){ ch.Business_Lost_Reason_New__c = Trigger.new[i].Business_Lost_Reason__c; ch.Business_Lost_Reason_Old__c = Trigger.old[i].Business_Lost_Reason__c; } if(Trigger.old[i].Business_Under_Threat_Reason__c != Trigger.new[i].Business_Under_Threat_Reason__c){ ch.Business_Under_Threat_Reason_New__c = Trigger.new[i].Business_Under_Threat_Reason__c; ch.Business_Under_Threat_Reason_Old__c = Trigger.old[i].Business_Under_Threat_Reason__c; } if(Trigger.old[i].Business_Won_Reason__c != Trigger.new[i].Business_Won_Reason__c){ ch.Business_Won_Reason_New__c = Trigger.new[i].Business_Won_Reason__c; ch.Business_Won_Reason_Old__c = Trigger.old[i].Business_Won_Reason__c; } if(Trigger.old[i].per_UOM__c != Trigger.new[i].per_UOM__c){ ch.Price_New__c = Trigger.new[i].per_UOM__c; ch.Price_Old__c = Trigger.old[i].per_UOM__c; } if(Trigger.old[i].Current_Status__c != Trigger.new[i].Current_Status__c){ ch.Status_New__c = Trigger.new[i].Current_Status__c; ch.Status_Old__c = Trigger.old[i].Current_Status__c; } if(Trigger.old[i].Annual_KGs__c != Trigger.new[i].Annual_KGs__c){ ch.Volume_New__c = Trigger.new[i].Annual_KGs__c; ch.Volume_Old__c = Trigger.old[i].Annual_KGs__c; } CPPs.add(ch); } insert CPPs; } } else if (Trigger.isDelete){ for (Integer i = 0; i < Trigger.old.size(); i++) { CPP_Change_History__c[] doomedCPP = [select Id,Name from CPP_Change_History__c where CPP__C = : Trigger.old[i].id]; Database.DeleteResult[] DR_Dels = Database.delete(doomedCPP); } } }

Thanks,

Jina

Hi,

I am getting a apex heap size error in my batch apex class. - System.LimitException: Apex heap size too large: 6030143.

The records that needs to be processed are in the range of 10k to 50K. I think it is because of the map that I am using in my code.

 This is how my code looks like

global class CreatePortfolioReport implements Database.Batchable<sObject>, Database.Stateful{
	public String query;
	global String email;

	Map<String, Purchase_Sales_Report__c[]> purchaseMap = new Map<String, Purchase_Sales_Report__c[]>();
	Map<String, Purchase_Sales_Report__c[]> salesMap = new Map<String, Purchase_Sales_Report__c[]>();
	
	
	global Database.QueryLocator start(Database.BatchableContext BC){
        return Database.getQueryLocator(query);
    }
    
    global void execute(Database.BatchableContext BC, List<sObject> scope){
    	 for(sObject s: scope){
    	 	Purchase_Sales_Report__c ps = (Purchase_Sales_Report__c)s;
    	 	if(ps.Transaction__c != null){
	    	 	if(ps.Transaction__c.equals('Purchase')){
		    	 	if(!purchaseMap.isEmpty() && purchaseMap.containsKey(ps.Unique_Name__c)){
		    	 		purchaseMap.get(ps.Unique_Name__c).add(ps);
		    	 	}
		    	 	else{
		    	 		List<Purchase_Sales_Report__c> newList = new List<Purchase_Sales_Report__c>();
		    	 		newList.add(ps);
		    	 		purchaseMap.put(ps.Unique_Name__c, newList);
		    	 	}
	    	   }
	    	   else if(ps.Transaction__c.equals('Sales')){
	    	   		if(!salesMap.isEmpty() && salesMap.containsKey(ps.Unique_Name__c)){
		    	 		salesMap.get(ps.Unique_Name__c).add(ps);
		    	 	}
		    	 	else{
		    	 		List<Purchase_Sales_Report__c> newList = new List<Purchase_Sales_Report__c>();
		    	 		newList.add(ps);
		    	 		salesMap.put(ps.Unique_Name__c, newList);
		    	 	}
	    	   }
    	 	}
    	 } 
    	 System.debug('Purchase Map size'+purchaseMap.size());
    	 System.debug('Sales Map size'+salesMap.size());
    }
    
    global void finish(Database.BatchableContext BC){
    	Map<String, Double> salesUnits = new Map<String, Double>();
    	Map<String, Double> purchaseUnits = new Map<String, Double>();
    	Map<String, Portfolio_Report__c> portfolioMap = new Map<String, Portfolio_Report__c>();
    	List<Temp_Purchase_Report__c> purchaseList = new List<Temp_Purchase_Report__c>();
    	for(String uniqueName: salesMap.keySet()){
  			Double units = 0;
  			Double purchaseAmount = 0;
  			for(Purchase_Sales_Report__c ps:salesMap.get(uniqueName)){
  				
  				if(ps.Units__c != null){
  					units += ps.Units__c;
  				}
  			}
  			salesUnits.put(uniqueName, units);
  		}
  		System.debug('Sales Map'+salesMap.size());
  		for(String uniqueName: purchaseMap.keySet()){
  			
  	        Double units;
  			if(salesUnits.containsKey(uniqueName)){
  				units = Math.abs(salesUnits.get(uniqueName));
  			}
  			Double pUnits = 0;
  			Double product = 0;
  			Double portUnits = 0;
  			Double portAmount = 0;
  			Double divReinvAmount = 0;
  			Double divAmount = 0;
  			Double stpAmount = 0;
  			Boolean entityFlag = true;
  			Id entity;
  			String folio;
  			String assetClass;
  			String schemeName;
  			for(Purchase_Sales_Report__c ps:purchaseMap.get(uniqueName)){
  				
  				if(units != null && pUnits != units){
  					if(ps.Units__c != null){
  						pUnits += ps.Units__c;
  					}
  					
  				}
  				else{
  					
  					if(ps.Units__c != null){
  						portUnits += ps.Units__c;
  					}
  					if(ps.Amount__c != null && ps.Type__c != null){
  						
  						if(ps.Type__c.equalsIgnoreCase('NOR') || ps.Type__c.equalsIgnoreCase('SIP')){
  							portAmount += ps.Amount__c;
  						}
  						else if(ps.Type__c.equalsIgnoreCase('DIR')){
  							divReinvAmount += ps.Amount__c;
  						}
  						else if(ps.Type__c.equalsIgnoreCase('STI') || ps.Type__c.equalsIgnoreCase('SWI')){
  							stpAmount += ps.Amount__c;
  						}
  						else if(ps.Type__c.equalsIgnoreCase('DVP')){
  							divAmount += ps.Amount__c;
  						}
  					}
  					if(ps.Product__c != null){
  						product += ps.Product__c;
  					}
  					if(entityFlag){
	  					entity = ps.Entity__c;
	  					folio = ps.Folio_Number__c;
	  					assetClass = ps.Asset_Class__c;
	  					entityFlag = false;
	  					schemeName = ps.Scheme_Name__c;
  					}
  					System.debug('Create Port Units'+portUnits+'Amount'+portAmount+'Product'+product);
  				}
  				
  			}
  			if(portUnits != 0 && product != 0 && (portAmount != 0 || divAmount !=0 || divReinvAmount !=0 || divAmount != 0) ){
  				Temp_Purchase_Report__c pr = new Temp_Purchase_Report__c(Entity__c= entity, 
  																		 Folio_Number__c = folio, 
  																		 Asset_Class__c = assetClass,
  																		 UniqueName__c = uniqueName, 
  																		 Purchase_Amount__c= portAmount, 
  																		 Units_Quanitity__c = portUnits, 
  																		 Product__c = product,
  																		 Dividend_Reinvested__c = divReinvAmount,
  																		 Dividend__c = divAmount,
  																		 STP_Switch__c = stpAmount,
  																		 Scheme_Scrip_Name__c = schemeName);
  				purchaseList.add(pr);
  			}
  		}
  		System.debug('Purchase List'+purchaseList.size());
  		
  		upsert purchaseList UniqueName__c;
  		  		
  		AsyncApexJob a = [Select Id, 
                                 Status,
                                 NumberOfErrors, 
                                 JobItemsProcessed,  
                                 TotalJobItems, 
                                 CreatedBy.Email 
                                 from AsyncApexJob 
                                 where Id =:BC.getJobId()];
        // Create and send an email with the results of the batch.
        Messaging.SingleEmailMessage mail = new Messaging.SingleEmailMessage();
        mail.setToAddresses(new String[] {email});
        mail.setReplyTo('');
        mail.setSenderDisplayName('Batch Processing');  
        mail.setSubject('Create Portfolio Report ' + a.Status);
        mail.setPlainTextBody('The batch apex job processed ' + a.TotalJobItems +   ' batches with ' + a.NumberofErrors + ' failures.');
    
        Messaging.sendEmail(new Messaging.SingleEmailMessage[] { mail });
  		
    }
}

 As I require the map for processing the data in my finish method, I cannot think of any other option to implement it.

Can you please suggest me ways to avoid the error?

Thanks,

Jina

Hi,

I am getting 'Too many script statements: 50001' exception in my trigger when I do a mass insert. I have not put any DML statements inside any for loop but still I am getting the error.

I have a object named Goal and the trigger is on insert. I need to insert all junction object records associated with the Goal object whenever any Goal record is inserted. There are 3 junction objects associated with the Goal - Insurance/Asset/PortfolioReport.

Here is the piece of code

trigger CreateGoalAssociations on Goal__c (after insert) {
	List<GoalAssetAssociation__c> assetList = new List<GoalAssetAssociation__c>();
	List<GoalInsuranceAssociation__c> insuranceList = new List<GoalInsuranceAssociation__c>();
	List<GoalIAULIPAssociation__c> pReport = new List<GoalIAULIPAssociation__c>();
	Map<Id, Id> entityIds = new Map<Id, Id>();
	Double d= 0;
	Map<Id, Id> goalAccountMap = new Map<Id, Id>();
	List<Goal__c> goalList = new List<Goal__c>();
	
	for(Goal__c g:Trigger.new){
		goalAccountMap.put(g.Id, g.Entity__c);
		goalList.add(g);
	}
    for(Account a: [select Id,Parent_Entity__c from Account where Parent_Entity__c IN :goalAccountMap.values()]){
		entityIds.put(a.Id, a.Id);
	}
    for(Asset__c a: [select Id, Asset_Type__c from Asset__c where Entity__c IN :goalAccountMap.values()
    					OR Entity__c IN :entityIds.keySet()]){
    	
    	for(Goal__c g: goalList){
    		GoalAssetAssociation__c gA = new GoalAssetAssociation__c(Goal__c = g.Id, Asset__c = a.Id, Allocation__c = d);
    		assetList.add(gA);
    	}
    }
    
    for(Insurance__c i: [select Id, Policy_Number_or_Name__c from Insurance__c where Entity__c IN :goalAccountMap.values()
    						OR Entity__c IN :entityIds.keySet()]){
    	for(Goal__c g:goalList){
    		GoalInsuranceAssociation__c gI = new GoalInsuranceAssociation__c(Goal__c = g.Id, Insurance__c = i.Id, Allocation__c = d);
    		insuranceList.add(gI);
    	}
    	
    }
    
    for(Portfolio_Report__c p: [select Id, Portfolio_Type__c  from Portfolio_Report__c where Entity__c IN :goalAccountMap.values()
    							OR Entity__c IN :entityIds.keySet()]){
    	for(Goal__c g:goalList){
    		GoalIAULIPAssociation__c gP = new GoalIAULIPAssociation__c(Goal__c = g.Id, Portfolio_Report__c = p.Id, Allocation__c = d);
    		pReport.add(gP);
    	}
    }
     insert assetList;
     insert insuranceList;
     insert pReport;
     
}

Is there any way I can modify the code to avoid the errors. I have highligted the places where I am getting the error.

Any help on this will be very much appreciated.

Many Thanks,

Jina

Hi,

I have to prepare two financial reports on nightly basis based on the every day feed that I get into salesforce. Here are the details -

1. There are two objects in salesforce Purchase Report and Portfolio Report and they are linked to the Account object. Account is the master for the two objects

2. Every day I get a feed of the Purchase Report which details out the money invested, date etc. Each record here requires some net gain % calculation which I am currently handling it thru a batch process.

3. Now based on the Purchase Report, I have to prepare  the Portfolio Report records which is the summary of the Purchse Report records..

  For e.g. - Account A has 100 records in the Purchase Report,out which there are 10 unique products..i.e. 10 records each for each product.

  So my summary report should generate 10 records, summing the total amount spent for 10 records and then other calculations like net gain % etc. Also, if there is already a record for the products in Portfolio Report object, it should just update the record instead of creating a new record. This will be something like the mutual find summary report and this update should run on nightly basis.

4. The daily feed that I would get may have around 50 K records.

I am confused on what approach should I take. If I use batch process, one batch will contain only 200 records and that might not include all the records for each product. I can store the summation on a stateful class variable but then how do I handle the after processing of data.

Should I do all my post calculations of calculating gain based on the summation in the 'finsh' method and upsert the records there? Is this a good a approach or there is some other way of doing it?

Many Thanks,

Jina

Hi,

I have trigger on a custom object CPP__c on update where I am creating history records for that object if any desired value changes in the updated record. I am not using nay new id while inserting but still I get this error

Update_CPP_change_history: execution of AfterUpdate

caused by: System.DmlException: Insert failed. First exception on row 0 with id a04R000000141WOIAY; first error: INVALID_FIELD_FOR_INSERT_UPDATE, cannot specify Id in an insert call: [Id]

The trigger works fine on a single update, it only fails when I try to do a mass update through Apex Data Loader by matching the lookup fields on the CPP__c object.

Can someone please help me in solving this issue? I have inserting the code snippet below

trigger Update_CPP_change_history on CPP__c (before delete, after insert, after update) { List<CPP_Change_History__c> CPPs = new List<CPP_Change_History__c>{}; if (Trigger.isInsert) { for (CPP__c a : Trigger.new) { CPP_Change_History__c ch = new CPP_Change_History__c( Account_Name__c = a.Account__c, CPP__c = a.id, Business_Lost_Reason_New__c = a.Business_Lost_Reason__c, Business_Under_Threat_Reason_New__c = a.Business_Under_Threat_Reason__c, Business_Won_Reason_New__c = a.Business_Won_Reason__c, Change_Date__c = System.today(), Price_New__c = a.per_UOM__c, Status_New__c = a.Current_Status__c, Supplier_New__c = a.Supplier_Name__c, Producer_New__c = a.Producer_Name__c, Volume_New__c = a.Annual_KGs__c ); CPPs.add(ch); } insert CPPs; } else if (Trigger.isUpdate) { for (Integer i = 0; i < Trigger.new.size(); i++) { if ((Trigger.old[i].Supplier_Name__c != Trigger.new[i].Supplier_Name__c)|| (Trigger.old[i].Producer_Name__c != Trigger.new[i].Producer_Name__c) || (Trigger.old[i].Business_Lost_Reason__c != Trigger.new[i].Business_Lost_Reason__c) || (Trigger.old[i].Business_Under_Threat_Reason__c != Trigger.new[i].Business_Under_Threat_Reason__c)|| (Trigger.old[i].Business_Won_Reason__c != Trigger.new[i].Business_Won_Reason__c) || (Trigger.old[i].per_UOM__c != Trigger.new[i].per_UOM__c) || (Trigger.old[i].Current_Status__c != Trigger.new[i].Current_Status__c)|| (Trigger.old[i].Annual_KGs__c != Trigger.new[i].Annual_KGs__c) ) { //Creat CPP History only if certain fields change CPP_Change_History__c ch = new CPP_Change_History__c( CPP__c = Trigger.new[i].id, Change_Date__c = System.today(), Account_Name__c = Trigger.new[i].Account__c); if(Trigger.old[i].Supplier_Name__c != Trigger.new[i].Supplier_Name__c){ ch.Supplier_New__c = Trigger.new[i].Supplier_Name__c; ch.Supplier_Old__c = Trigger.old[i].Supplier_Name__c; } if(Trigger.old[i].Producer_Name__c != Trigger.new[i].Producer_Name__c){ ch.Producer_New__c = Trigger.new[i].Producer_Name__c; ch.Producer_Old__c = Trigger.old[i].Producer_Name__c; } if(Trigger.old[i].Business_Lost_Reason__c != Trigger.new[i].Business_Lost_Reason__c){ ch.Business_Lost_Reason_New__c = Trigger.new[i].Business_Lost_Reason__c; ch.Business_Lost_Reason_Old__c = Trigger.old[i].Business_Lost_Reason__c; } if(Trigger.old[i].Business_Under_Threat_Reason__c != Trigger.new[i].Business_Under_Threat_Reason__c){ ch.Business_Under_Threat_Reason_New__c = Trigger.new[i].Business_Under_Threat_Reason__c; ch.Business_Under_Threat_Reason_Old__c = Trigger.old[i].Business_Under_Threat_Reason__c; } if(Trigger.old[i].Business_Won_Reason__c != Trigger.new[i].Business_Won_Reason__c){ ch.Business_Won_Reason_New__c = Trigger.new[i].Business_Won_Reason__c; ch.Business_Won_Reason_Old__c = Trigger.old[i].Business_Won_Reason__c; } if(Trigger.old[i].per_UOM__c != Trigger.new[i].per_UOM__c){ ch.Price_New__c = Trigger.new[i].per_UOM__c; ch.Price_Old__c = Trigger.old[i].per_UOM__c; } if(Trigger.old[i].Current_Status__c != Trigger.new[i].Current_Status__c){ ch.Status_New__c = Trigger.new[i].Current_Status__c; ch.Status_Old__c = Trigger.old[i].Current_Status__c; } if(Trigger.old[i].Annual_KGs__c != Trigger.new[i].Annual_KGs__c){ ch.Volume_New__c = Trigger.new[i].Annual_KGs__c; ch.Volume_Old__c = Trigger.old[i].Annual_KGs__c; } CPPs.add(ch); } insert CPPs; } } else if (Trigger.isDelete){ for (Integer i = 0; i < Trigger.old.size(); i++) { CPP_Change_History__c[] doomedCPP = [select Id,Name from CPP_Change_History__c where CPP__C = : Trigger.old[i].id]; Database.DeleteResult[] DR_Dels = Database.delete(doomedCPP); } } }

Thanks,

Jina